Page MenuHomePhabricator

ddfisher (David Fisher)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 31 2012, 4:15 AM (398 w, 5 d)
Availability
Available

Pinkie Pie is best pony.

Recent Activity

Oct 20 2016

ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

We deployed D16714 and reran one of the failing tasks -- it completed cleanly as expected. Thanks!

Oct 20 2016, 7:52 PM · Bug Report

Oct 14 2016

ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Yep! It looks like that's the issue:

Oct 14 2016, 1:00 AM · Bug Report
ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

I'll give that a try. I think the associated diffs have enormous lines, so it seems likely that's what's going on.

Oct 14 2016, 12:38 AM · Bug Report

Oct 13 2016

ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

(Following up for Greg, as I'm now the oncall.)

mysql> select @@max_allowed_packet;
+----------------------+
| @@max_allowed_packet |
+----------------------+
|             67108864 |
+----------------------+
1 row in set (0.00 sec)

metamta.differential.inline-patches is 500.
metamta.email-body-limit is still the default of 524288.

Oct 13 2016, 11:24 PM · Bug Report

Nov 10 2015

ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

Thanks for the quick feedback and for spending the time to help me do things The Right Way (instead of the okay but expedient way)!

Nov 10 2015, 12:55 AM
ddfisher committed rPc589af51e8b3: add "update" mode to Diffusion coverage Conduit (authored by ddfisher).
add "update" mode to Diffusion coverage Conduit
Nov 10 2015, 12:52 AM
ddfisher closed D14428: add "update" mode to Diffusion coverage Conduit by committing rPc589af51e8b3: add "update" mode to Diffusion coverage Conduit.
Nov 10 2015, 12:52 AM
ddfisher retitled D14428: add "update" mode to Diffusion coverage Conduit from add "set_file" mode to Diffusion coverage Conduit to add "update" mode to Diffusion coverage Conduit.
Nov 10 2015, 12:49 AM
ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

"overwrite" + "update" sounds good to me! Changed.

Nov 10 2015, 12:48 AM
ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

With regards to the previous names: I think you got them backwards from what we originally came up with. Actually, they may be significantly better that way. Hmm...

Nov 10 2015, 12:31 AM
ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

The name change was motivated because I realized that the two operations differed only by level of granularity. It makes more sense to me if I imagine a set_commit level as well:

Nov 10 2015, 12:26 AM

Nov 9 2015

ddfisher retitled D14428: add "update" mode to Diffusion coverage Conduit from add "overwrite" mode to Diffusion coverage Conduit to add "set_file" mode to Diffusion coverage Conduit.
Nov 9 2015, 10:34 PM
ddfisher updated the diff for D14428: add "update" mode to Diffusion coverage Conduit.

make (branch, commit, file) entries unique in repository_coverage; tweak mode names

Nov 9 2015, 10:34 PM

Nov 7 2015

ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

Actually, would it make sense to enforce this uniqueness at the SQL level?

Nov 7 2015, 12:49 AM
ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

Oops! I absolutely agree the database should have at most one row per <branchID, commitID, pathID> tuple. I was confused about the behavior of the insert. Should've checked the database. <_<

Nov 7 2015, 12:44 AM

Nov 6 2015

ddfisher added a comment to D14428: add "update" mode to Diffusion coverage Conduit.

Conspicuously absent is the "merge" mode we discussed because I've forgotten how to write PHP. If you want that in this diff I can add it, though

Nov 6 2015, 11:10 PM
ddfisher retitled D14428: add "update" mode to Diffusion coverage Conduit from to add "overwrite" mode to Diffusion coverage Conduit.
Nov 6 2015, 11:03 PM

Aug 21 2014

ddfisher updated subscribers of T5698: Github-style Remarkup previews on a checked-in resource.

To bring this a bit back on topic, I think adding a Remarkup-rendered view that was not diff aware (as a first pass) would be very useful at pretty low implementation cost.

Aug 21 2014, 6:57 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Jul 24 2014

ddfisher added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

It looks like adding GFM or other markdown renderers has negative security implications, among other issues (see this discussion and T2849). We just want some sort of markdown renderer (i.e. remarkup) for checked-in files, which I think (without too much investigation) should be pretty straightforward to implement.

Jul 24 2014, 4:35 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup