Page MenuHomePhabricator

ddfisher (David Fisher)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 31 2012, 4:15 AM (768 w, 2 d)
Availability
Available

Pinkie Pie is best pony.

Recent Activity

Oct 20 2016

ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

We deployed D16714 and reran one of the failing tasks -- it completed cleanly as expected. Thanks!

Oct 20 2016, 7:52 PM · Bug Report

Oct 14 2016

ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Yep! It looks like that's the issue:

Oct 14 2016, 1:00 AM · Bug Report
ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

I'll give that a try. I think the associated diffs have enormous lines, so it seems likely that's what's going on.

Oct 14 2016, 12:38 AM · Bug Report

Oct 13 2016

ddfisher added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

(Following up for Greg, as I'm now the oncall.)

mysql> select @@max_allowed_packet;
+----------------------+
| @@max_allowed_packet |
+----------------------+
|             67108864 |
+----------------------+
1 row in set (0.00 sec)

metamta.differential.inline-patches is 500.
metamta.email-body-limit is still the default of 524288.

Oct 13 2016, 11:24 PM · Bug Report

Aug 21 2014

ddfisher updated subscribers of T5698: Github-style Remarkup previews on a checked-in resource.

To bring this a bit back on topic, I think adding a Remarkup-rendered view that was not diff aware (as a first pass) would be very useful at pretty low implementation cost.

Aug 21 2014, 6:57 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Jul 24 2014

ddfisher added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

It looks like adding GFM or other markdown renderers has negative security implications, among other issues (see this discussion and T2849). We just want some sort of markdown renderer (i.e. remarkup) for checked-in files, which I think (without too much investigation) should be pretty straightforward to implement.

Jul 24 2014, 4:35 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup