Committer identities ... they're currently stored in a JSON blob so there's no efficient way to query them.

That was sufficient to get what I needed, thanks so much.

Is there a way to find which object(s) an (unmapped) identity was discovered on?

Is there a way to find which object(s) an (unmapped) identity was discovered on? After a rebuild-identities, I have an empty string identity and a couple asdf-style garbage ones. I'd like to find the source of them and either fix them there or see the context to understand the appropriate identity mapping.

See https://discourse.phabricator-community.org/t/data-truncated-when-pushing-into-repository/3586/ for what is likely to be a related issue.

Perfect; thanks!

In the general case:

Sorry if this is a stupid question, but now that this is done, how do I actually map between Phabricator users and VCS user strings, in an existing Diffusion repo?

I think this doesn't have anything actionable left, see T13444 for some followups. This feature probably isn't 100% perfect quite yet, but I think remaining work is just cleanup.

In T6722#197239, @avivey wrote:

I think a more powerful approach is to support some kind of "templates", so that we can create a new "Android App" repo or "COM Module" repo directly, similar to how IDEs have project templates.

I think this is effectively resolved by T13277.

See D20419 and T13277.

I would like to add another use case where this would be beneficial.

Piece by piece, this was effectively untangled. Differential largely moved forward; Arcanist has a path forward in T13098 (although it's ultimately a "major version" sort of change), and Diffusion stuff has settled into relatively actionable plans in, e.g., T13075.

I did rebuild-identities on every instance

The "activity" migration went to production just now. I expect all production instances just bailed out, since I ran rebuild-identities some time ago, but I'll verify that:

In T12164#239595, @mydeveloperday wrote:

just wanted to give you some reference data (your mileage may vary), I have 2 Phabricator instances with multiple git repos

one has ~300,000 commits ( a mixture of read-only (mirrors) and hosted repos), the other ~200,000 (all hosted)

in both cases I ran rebuild-identities after doing the Week25 upgrade

time ./bin/repository rebuild-identities --all

it took

21 minutes on the one with 300,000 commits and
16 minutes on the one with 200,000

Can't help but think that this was most likely limited by the speed of the terminal output.

Hope that helps others

just wanted to give you some reference data (your mileage may vary), I have 2 Phabricator instances with multiple git repos

I deployed D19484 and db010, db024 and db025 finished up with no issues.

These hosts ultimately timed out on the initial rebuild-identities: db010, db024, db025.

From T13152 -- none of this is too important, just didn't want to lose it when I close that:

See PHI594, where a real user had the same human name as an external user from another project.

D18988 addresses the issue from D18105 (git grep 🐑 fails) more directly by calling @setlocale(LC_ALL, 'en_US.UTF-8') unconditionally during startup. The motivating case in T13060 is: