Page MenuHomePhabricator

SymbolsProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Sep 6 2018

epriestley added a comment to T3130: Improve recognition of symbols in Java.

D19637 doesn't actually improve this, but it brings us a step closer (since the logic is now in PHP and can be modified more easily to label symbols and add context).

Sep 6 2018, 5:35 PM · Symbols, libphutil
avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil

Sep 4 2018

epriestley added a revision to T3130: Improve recognition of symbols in Java: D19637: Port the Java fragment lexer to PHP.
Sep 4 2018, 9:01 PM · Symbols, libphutil

Apr 8 2018

epriestley added a revision to T13047: Plans: Symbol Indexes: D19307: Make repository symbol references work with DocumentEngine.
Apr 8 2018, 4:34 PM · Plans, Symbols

Mar 5 2018

epriestley moved T13047: Plans: Symbol Indexes from Backlog to Future on the Plans board.

The actual support issues were likely addressed or obsoleted by the above changes. The rest of this is still planned, probably won't move forward any time soon.

Mar 5 2018, 3:01 PM · Plans, Symbols

Feb 25 2018

epriestley added a project to T13047: Plans: Symbol Indexes: Plans.
Feb 25 2018, 3:28 PM · Plans, Symbols

Jan 26 2018

epriestley renamed T13047: Plans: Symbol Indexes from Figure out the state of affairs on symbol indexing to Plans: Symbol Indexes.
Jan 26 2018, 5:55 PM · Plans, Symbols
epriestley added a comment to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index.

I think a reasonable path forward here is for Diviner to have a {symbol} sort of syntax which executes a symbol index query. The symbol index can already be configured to know how to offer links to external documentation.

Jan 26 2018, 3:14 PM · Restricted Project, Symbols, Diviner
epriestley renamed T8533: Allow Diviner to fall back to (or link directly to) the Symbol index from Allow linking to external documentation to Allow Diviner to fall back to (or link directly to) the Symbol index.
Jan 26 2018, 3:07 PM · Restricted Project, Symbols, Diviner
epriestley added a revision to T13047: Plans: Symbol Indexes: D18940: Fix an issue with symbol lookup identifying path names in Diffusion.
Jan 26 2018, 2:45 PM · Plans, Symbols
epriestley added a revision to T13047: Plans: Symbol Indexes: D18939: Provide character position information to symbol queries.
Jan 26 2018, 2:34 PM · Plans, Symbols
epriestley added a revision to T13047: Plans: Symbol Indexes: D18937: When available, pass path, line and repository hints to external symbol queries.
Jan 26 2018, 3:22 AM · Plans, Symbols
epriestley added a revision to T13047: Plans: Symbol Indexes: D18936: When users click a symbol in Differential to jump to the definition, include path/line context.
Jan 26 2018, 2:59 AM · Plans, Symbols

Jan 24 2018

epriestley added a project to T7960: Jumping to symbols from Differential doesn't work well on mobile: Symbols.
Jan 24 2018, 5:39 PM · Symbols, Mobile, Differential
epriestley moved T3130: Improve recognition of symbols in Java from Backlog to Language Support on the Symbols board.
Jan 24 2018, 5:38 PM · Symbols, libphutil
epriestley triaged T13047: Plans: Symbol Indexes as Normal priority.
Jan 24 2018, 5:18 PM · Plans, Symbols
epriestley updated the task description for T13047: Plans: Symbol Indexes.
Jan 24 2018, 5:16 PM · Plans, Symbols
epriestley closed T9424: Commit hash links to symbol lookup as Resolved.

See PHI185. This was fixed by D18753 but didn't get linked up.

Jan 24 2018, 4:46 PM · Symbols, Differential
epriestley closed T8302: Maybe allow ctrl-click to search for any symbol? as Resolved.

Maybe this works now?

Jan 24 2018, 4:44 PM · Symbols
epriestley closed T8536: Merge symbols and Diviner as Wontfix.

Per above, I think the pathway forward here is probably "tighter integration", not "merge/replace", i.e. tools for Diviner to automatically update Symbols, too. I'm just going to conceptually roll this up into T13047.

Jan 24 2018, 4:41 PM · Symbols, Diviner
epriestley closed T8536: Merge symbols and Diviner, a subtask of T8533: Allow Diviner to fall back to (or link directly to) the Symbol index, as Wontfix.
Jan 24 2018, 4:41 PM · Restricted Project, Symbols, Diviner
epriestley closed T8349: PHP external symbols uses php from server as Wontfix.

I think this probably isn't worth fixing in the upstream: different versions of PHP are mostly the same; there's usually a good argument for deploying the same version of PHP everywhere; and Phabricator supports both very old and very modern versions of PHP so it should usually be easy to run Phabricator on whatever version of PHP you're developing against.

Jan 24 2018, 4:40 PM · Symbols
epriestley closed T1602: Support scoped symbols as Resolved.

I believe this is supported now (and for some time) in the general case in terms of Phabricator infrastructure. Actually getting it to work requires a very smart highlighter, and the upstream XHPAST highlighter is the only one in existence. But other tasks, like T3130, are better homes for parser/AST improvements to particular languages.

Jan 24 2018, 4:36 PM · Restricted Project, Symbols, Differential, Diffusion
epriestley triaged T10771: Symbols search page shows repo's Monogram, should show name as Normal priority.

To reproduce:

Jan 24 2018, 4:30 PM · Symbols
epriestley added a parent task for T10771: Symbols search page shows repo's Monogram, should show name: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:26 PM · Symbols
epriestley added a parent task for T1602: Support scoped symbols: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:26 PM · Restricted Project, Symbols, Differential, Diffusion
epriestley added a parent task for T12318: Loading Symbols in Phacility (Conduit): T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:25 PM · Customer Impact, Symbols, Feature Request
epriestley added a parent task for T8536: Merge symbols and Diviner: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:25 PM · Symbols, Diviner
epriestley added a parent task for T8349: PHP external symbols uses php from server: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:25 PM · Symbols
epriestley added a parent task for T11135: Ctrl-click symbol lookup language in Diffusion ignores `syntax.filemap`: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:24 PM · Symbols, Bug Report
epriestley added a parent task for T8302: Maybe allow ctrl-click to search for any symbol?: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:23 PM · Symbols
epriestley added a parent task for T9424: Commit hash links to symbol lookup: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:23 PM · Symbols, Differential

Apr 12 2017

epriestley moved T12318: Loading Symbols in Phacility (Conduit) from Backlog to "Customers" on the Customer Impact board.
Apr 12 2017, 3:10 PM · Customer Impact, Symbols, Feature Request
epriestley edited projects for T12318: Loading Symbols in Phacility (Conduit), added: Customer Impact; removed Phacility.
Apr 12 2017, 3:10 PM · Customer Impact, Symbols, Feature Request

Feb 26 2017

epriestley added a comment to T12318: Loading Symbols in Phacility (Conduit).

I think this (and lint/coverage) should move to Conduit, yeah.

Feb 26 2017, 3:26 PM · Customer Impact, Symbols, Feature Request
avivey created T12318: Loading Symbols in Phacility (Conduit).
Feb 26 2017, 3:13 PM · Customer Impact, Symbols, Feature Request

Aug 5 2016

eadler added a project to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Symbols, Diviner
eadler added a project to T1602: Support scoped symbols: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Symbols, Differential, Diffusion

Jun 12 2016

avivey renamed T11135: Ctrl-click symbol lookup language in Diffusion ignores `syntax.filemap` from Ctrl-click symbol lookup language is inconsistent between Diffusion and Differential to Ctrl-click symbol lookup language in Diffusion ignores `syntax.filemap`.
Jun 12 2016, 6:33 PM · Symbols, Bug Report
avivey added a project to T11135: Ctrl-click symbol lookup language in Diffusion ignores `syntax.filemap`: Symbols.
Jun 12 2016, 6:33 PM · Symbols, Bug Report

May 21 2016

shan199105 closed Q395: [HELP] Symbol Index Setups For Swift as resolved.
May 21 2016, 3:35 AM · Symbols, Diffusion
shan199105 added a comment to Q395: [HELP] Symbol Index Setups For Swift.

Thank you so much for giving me help here. Have a nice weekend. @avivey

May 21 2016, 3:35 AM · Symbols, Diffusion
avivey added a comment to Q395: [HELP] Symbol Index Setups For Swift.

It's based on git-grep. You can't give it any arguments.

May 21 2016, 3:32 AM · Symbols, Diffusion
shan199105 added a comment to Q395: [HELP] Symbol Index Setups For Swift.

Wow, that's great.

May 21 2016, 3:30 AM · Symbols, Diffusion
avivey added a comment to Q395: [HELP] Symbol Index Setups For Swift.

https://secure.phabricator.com/diffusion/P/browse/master/ - there's a Show Search button, that will let you search by filename or file contents.

May 21 2016, 3:22 AM · Symbols, Diffusion
shan199105 added a comment to Q395: [HELP] Symbol Index Setups For Swift.

Thank you so much for the help. Now it works.

May 21 2016, 2:54 AM · Symbols, Diffusion
avivey added a comment to Q395: [HELP] Symbol Index Setups For Swift.

Looking at the first image, it looks like the symbols are defined to be cpp symbols; That would fit your description of the behavior:
When searching from the search-field, the system ignores language of the symbols; When looking from a source file, it narrows down the search to files of the same language - in this case I think it should be swift.

May 21 2016, 2:34 AM · Symbols, Diffusion
shan199105 updated the question details for Q395: [HELP] Symbol Index Setups For Swift.
May 21 2016, 2:18 AM · Symbols, Diffusion
shan199105 updated Q395: [HELP] Symbol Index Setups For Swift from to [HELP] Symbol Index Setups For Swift.
May 21 2016, 2:18 AM · Symbols, Diffusion

Apr 10 2016

avivey created T10771: Symbols search page shows repo's Monogram, should show name.
Apr 10 2016, 11:36 PM · Symbols