Page MenuHomePhabricator

When available, pass path, line and repository hints to external symbol queries
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:22 AM.
Tags
None
Referenced Files
F18997863: D18937.diff
Thu, Nov 20, 3:59 PM
F18814691: D18937.diff
Oct 20 2025, 11:46 PM
F18754495: D18937.diff
Oct 4 2025, 11:17 PM
F18673878: D18937.diff
Sep 25 2025, 12:25 PM
F18657183: D18937.id.diff
Sep 23 2025, 12:49 AM
F18656021: D18937.id45431.diff
Sep 22 2025, 9:16 PM
F18646353: D18937.id45431.diff
Sep 19 2025, 9:50 AM
F18588432: D18937.diff
Sep 12 2025, 12:17 AM
Subscribers
None

Details

Summary

Depends on D18936. Ref T13047. Third parties can define external symbol sources that let users jump to PHP or Python documentation or query some server.

Give these queries more information so they can try to get better results: the path and line where the symbol appeared, and any known repository scope.

Test Plan

Wrote a fake external source that used this data, command-clicked a symbol in Differential, saw a fake external symbol result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable