Page MenuHomePhabricator

Fix an issue where the repository symbol index would incorrectly activate inside inline comments
ClosedPublic

Authored by epriestley on Oct 31 2017, 8:54 PM.
Tags
None
Referenced Files
F14056023: D18753.diff
Sat, Nov 16, 5:37 PM
F14037948: D18753.diff
Sun, Nov 10, 8:22 PM
F14032569: D18753.diff
Sat, Nov 9, 2:48 PM
F14029089: D18753.diff
Fri, Nov 8, 7:22 PM
F14029088: D18753.diff
Fri, Nov 8, 7:21 PM
F14009971: D18753.diff
Thu, Oct 31, 2:31 AM
F14003446: D18753.id.diff
Sat, Oct 26, 6:15 AM
F13997024: D18753.diff
Thu, Oct 24, 1:43 AM
Subscribers
None

Details

Summary

See PHI185. When looking at a revision, you can Command-Click (Mac) symbols to jump to their definitions (provided the symbol index has been built).

Currently, the code works on any node inside the changeset list, so it activates when clicking links inside inline comments and opening them in a new window.

To avoid this, don't activate if we're inside an inline comment. This technically prevents you from doing a symbol lookup on a symbol inside a codeblock inside an inline, but that seems fine/reasonable.

Test Plan

Wrote Dxxx in an inline, command-clicked it. Before: got a symbol lookup. After: just a new tab with the revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable