Page MenuHomePhabricator
Differential D19307

Make repository symbol references work with DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Apr 8 2018, 4:34 PM.
Tags
None
Referenced Files
F21334623: D19307.diff
Fri, Jul 10, 2:34 PM
F21313331: D19307.diff
Thu, Jul 9, 1:33 PM
Unknown Object (File)
Tue, Jun 30, 9:12 AM
Unknown Object (File)
Sat, Jun 27, 7:24 AM
Unknown Object (File)
Mon, Jun 15, 9:28 AM
Unknown Object (File)
Apr 18 2026, 7:40 AM
Unknown Object (File)
Apr 14 2026, 6:33 PM
Unknown Object (File)
Apr 14 2026, 2:25 AM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13047: Plans: Symbol Indexes
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP90a614778c07: Make repository symbol references work with DocumentEngine
Summary

Ref T13105. Ref T13047. This makes symbol indexes work with DocumentEngine in Files, and restores support in Diffusion.

Test Plan

Command-clicked stuff, got taken to the symbol index with reasonable metadata in Diffusion, Differential and Files.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
src/
applications/
diffusion/
document/
20 lines
files/
document/
12 lines
2 lines
2 lines
7 lines
render/
7 lines
view/
layout/
21 lines
webroot/
rsrc/
css/
core/
13 lines
layout/
1 line
js/
application/
repository/
150 lines

Diff 46206

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentRef.php

Loading...
View Options

src/applications/files/document/PhabricatorJSONDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...
View Options

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
View Options

webroot/rsrc/css/core/syntax.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...
Phabricator · Built by Phacility