Page MenuHomePhabricator
Differential D18939

Provide character position information to symbol queries
ClosedPublic
Actions

Authored by epriestley on Jan 26 2018, 2:34 PM.
Tags
None
Referenced Files
F19036266: D18939.diff
Tue, Nov 25, 7:19 PM
F18814696: D18939.diff
Oct 20 2025, 11:46 PM
F18757484: D18939.id45414.diff
Oct 5 2025, 5:39 PM
F18735149: D18939.diff
Sep 30 2025, 11:50 PM
F18581467: D18939.id45433.diff
Sep 11 2025, 6:16 AM
F18581411: D18939.id.diff
Sep 11 2025, 6:06 AM
F18509253: D18939.id.diff
Sep 5 2025, 3:19 AM
F18502014: D18939.diff
Sep 4 2025, 10:07 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13047: Plans: Symbol Indexes
Commits
rPfdc36677ba4f: Provide character position information to symbol queries
Summary

Depends on D18937. Ref T13047. When available, provide character positions so external indexers can return more accurate results.

Test Plan

Clicked symbols in Safari, Firefox and Chrome, got sensible-looking character positions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
diffusion/
controller/
7 lines
symbol/
10 lines
webroot/
rsrc/
js/
application/
repository/
44 lines

Diff 45433

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionSymbolController.php

Loading...
View Options

src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php

Loading...
View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...
Phabricator · Built by Phacility