Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
F15478705: D18940.id.diff
Tue, Apr 8, 2:21 AM
F15462878: D18940.id.diff
Tue, Apr 1, 6:26 PM
F15460711: D18940.diff
Tue, Apr 1, 1:27 AM
F15433261: D18940.diff
Mon, Mar 24, 10:18 PM
F15393900: D18940.diff
Sat, Mar 15, 11:14 PM
F15379537: D18940.id45434.diff
Thu, Mar 13, 9:44 PM
F15378933: D18940.diff
Thu, Mar 13, 5:42 PM
F15367621: D18940.diff
Tue, Mar 11, 8:06 PM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable