Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 8:54 AM
Unknown Object (File)
Fri, Jan 24, 11:20 PM
Unknown Object (File)
Fri, Jan 24, 11:19 PM
Unknown Object (File)
Fri, Jan 24, 11:19 PM
Unknown Object (File)
Tue, Jan 21, 11:15 AM
Unknown Object (File)
Jan 6 2025, 4:45 AM
Unknown Object (File)
Jan 2 2025, 1:13 AM
Unknown Object (File)
Dec 21 2024, 11:08 PM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable