Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
F15550801: D18940.id45415.diff
Sun, Apr 27, 1:46 PM
F15523640: D18940.diff
Mon, Apr 21, 2:42 AM
F15499927: D18940.id45415.diff
Sun, Apr 13, 3:30 PM
F15490300: D18940.id45434.diff
Fri, Apr 11, 4:05 PM
F15488498: D18940.id45415.diff
Thu, Apr 10, 11:00 PM
F15478705: D18940.id.diff
Tue, Apr 8, 2:21 AM
F15462878: D18940.id.diff
Apr 1 2025, 6:26 PM
F15460711: D18940.diff
Apr 1 2025, 1:27 AM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable