Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
F18084570: D18940.id.diff
Tue, Aug 5, 4:08 PM
F18081471: D18940.diff
Tue, Aug 5, 12:31 AM
F17801238: D18940.id.diff
Jul 25 2025, 7:30 AM
F17770292: D18940.diff
Jul 23 2025, 9:27 AM
Unknown Object (File)
Jun 30 2025, 2:58 PM
Unknown Object (File)
Jun 30 2025, 2:35 PM
Unknown Object (File)
Jun 30 2025, 10:19 AM
Unknown Object (File)
Jun 29 2025, 7:49 AM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable