Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 10:18 AM
Unknown Object (File)
Tue, Apr 2, 8:42 AM
Unknown Object (File)
Feb 26 2024, 9:52 PM
Unknown Object (File)
Feb 26 2024, 7:40 PM
Unknown Object (File)
Feb 26 2024, 2:43 PM
Unknown Object (File)
Feb 16 2024, 2:34 PM
Unknown Object (File)
Jan 22 2024, 1:52 AM
Unknown Object (File)
Jan 20 2024, 11:43 PM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable