Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
F18757228: D18940.id.diff
Sun, Oct 5, 4:16 PM
F18754550: D18940.diff
Sat, Oct 4, 11:28 PM
F18588433: D18940.diff
Fri, Sep 12, 12:17 AM
F18566509: D18940.id.diff
Tue, Sep 9, 2:41 PM
F18502015: D18940.diff
Sep 4 2025, 10:07 PM
F18488384: D18940.id45434.diff
Sep 3 2025, 8:40 PM
F18477910: D18940.diff
Sep 3 2025, 4:34 AM
F18084570: D18940.id.diff
Aug 5 2025, 4:08 PM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable