Page MenuHomePhabricator

When users click a symbol in Differential to jump to the definition, include path/line context
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 5:39 PM
Unknown Object (File)
Fri, Jan 24, 11:18 PM
Unknown Object (File)
Fri, Jan 24, 11:17 PM
Unknown Object (File)
Fri, Jan 24, 11:17 PM
Unknown Object (File)
Sat, Jan 11, 11:32 PM
Unknown Object (File)
Dec 31 2024, 7:16 PM
Unknown Object (File)
Dec 28 2024, 4:57 PM
Unknown Object (File)
Dec 26 2024, 10:03 AM
Subscribers
None

Details

Summary

Ref T13047. In some reasonable cases, knowing the path and line number where a symbol appears is useful in ranking or filtering the set of matching symbols.

Giving symbol sources more information can't hurt, and it's generally free for us to include this context since we just need to grab it out of the document and pass it along.

We can't always get this data (for example, if a user types s idx into global search, we have no clue) but this is similar to other types of context which are only available sometimes (like which repository a symbol appears in).

Test Plan

Command-clicked some symbols in 1-up (unified) and 2-up (side-by-side) diff views with symbol indexes configured. Got accurate path and line information in the URI I was redirected to.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable