Page MenuHomePhabricator

When users click a symbol in Differential to jump to the definition, include path/line context
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:59 AM.
Tags
None
Referenced Files
F17700307: D18936.diff
Tue, Jul 15, 8:43 PM
Unknown Object (File)
Tue, Jul 1, 6:42 PM
Unknown Object (File)
Sun, Jun 29, 5:37 AM
Unknown Object (File)
Jun 20 2025, 4:30 PM
Unknown Object (File)
May 31 2025, 8:38 PM
Unknown Object (File)
May 26 2025, 2:26 PM
Unknown Object (File)
May 21 2025, 7:36 PM
Unknown Object (File)
May 8 2025, 10:27 AM
Subscribers
None

Details

Summary

Ref T13047. In some reasonable cases, knowing the path and line number where a symbol appears is useful in ranking or filtering the set of matching symbols.

Giving symbol sources more information can't hurt, and it's generally free for us to include this context since we just need to grab it out of the document and pass it along.

We can't always get this data (for example, if a user types s idx into global search, we have no clue) but this is similar to other types of context which are only available sometimes (like which repository a symbol appears in).

Test Plan

Command-clicked some symbols in 1-up (unified) and 2-up (side-by-side) diff views with symbol indexes configured. Got accurate path and line information in the URI I was redirected to.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable