Page MenuHomePhabricator

LintProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

May 21 2019

joshuaspence added a revision to T6854: Modify the `lint-test` file format to allow for assertions against linter codes: D20532: Fix handling of empty line/column in linter tests.
May 21 2019, 8:02 AM · Lint
joshuaspence closed T6854: Modify the `lint-test` file format to allow for assertions against linter codes as Resolved by committing rARCdd514e268b2c: Modify the `lint-test` file format to allow for more powerful assertions.
May 21 2019, 3:48 AM · Lint

Oct 2 2018

epriestley moved T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint, Arcanist
epriestley moved T5730: `arc lint --everything` reporting all symbols missing in libphutil/ on Windows? from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Lint, Windows, Arcanist
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint` as Resolved.

Changes in T13209 make this the only mode.

Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a parent task for T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`: T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report

Sep 27 2018

epriestley closed T11517: arc lint missed some error reported from the golint as Wontfix.

This doesn't seem actionable and is likely mooted by T13098.

Sep 27 2018, 2:26 PM · Bug Report (Needs Information), Arcanist, Lint

Sep 24 2018

epriestley closed T6850: PHP Notices, when Linter Cache enabled as Wontfix.

This feature has been removed in experimental and wilds, and I don't currently expect to restore it.

Sep 24 2018, 4:38 PM · Lint, Arcanist
epriestley moved T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used from Backlog to Upstream on the Arcanist board.
Sep 24 2018, 4:04 PM · Lint, Arcanist

Sep 14 2018

epriestley added a parent task for T10038: Plan the mid-term pathway for unit-test/linter bindings: T13098: Plans: Arcanist toolsets and extensions.
Sep 14 2018, 6:09 PM · Lint, Arcanist

May 15 2018

epriestley renamed T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets from Arcanist linters do not handle UTF8 well to Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint, Arcanist
epriestley merged task T13139: Custom linters have no easy way to get line+char from char-offset in file into T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint
epriestley merged T13139: Custom linters have no easy way to get line+char from char-offset in file into T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint, Arcanist
avivey created T13139: Custom linters have no easy way to get line+char from char-offset in file.
May 15 2018, 6:08 PM · Lint

Mar 5 2018

epriestley moved T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:17 PM · Lint, Arcanist, Bug Report
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Unit/Lint Bindings to Upstream on the Arcanist board.
Mar 5 2018, 2:15 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T13059: Write a lint rule for detecting unreachable blocks from Backlog to Upstream on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Lint

Feb 3 2018

epriestley added a comment to T10817: Allow more characters for built-in `filename` linter.

(Future me, see also PHI343.)

Feb 3 2018, 8:09 PM · Lint, Feature Request
swisspol added a comment to T10817: Allow more characters for built-in `filename` linter.

The above workaround is not reliable since it skips the files entirely vs checking the remaining characters.

Feb 3 2018, 7:58 PM · Lint, Feature Request

Feb 2 2018

epriestley updated the task description for T13059: Write a lint rule for detecting unreachable blocks.
Feb 2 2018, 5:12 PM · Arcanist, Lint
epriestley triaged T13059: Write a lint rule for detecting unreachable blocks as Normal priority.
Feb 2 2018, 5:07 PM · Arcanist, Lint

Oct 10 2017

csilvers added a comment to T13007: Integrating `arc lint` and auto-fixers.

Oops, I filed it in the wrong place, my apologies!

Oct 10 2017, 6:39 PM · Lint, Arcanist
epriestley closed T13007: Integrating `arc lint` and auto-fixers as Invalid.

Please file feature requests through the community forum (https://discourse.phabricator-community.org) or a support pact (https://admin.phacility.com/book/phacility/article/support_pacts/).

Oct 10 2017, 6:23 PM · Lint, Arcanist
csilvers added a comment to T13007: Integrating `arc lint` and auto-fixers.

Doh!, I was looking at the jshint engine before, not the eslint engine. It looks like phab doesn't have built-in support for eslint yet. But this looks promising: maybe the autofixing eslint reports *is* on an error-by-error basis.

Oct 10 2017, 6:04 PM · Lint, Arcanist
sophiebits added a comment to T13007: Integrating `arc lint` and auto-fixers.

At Facebook we have a custom arcanist lint engine that wraps eslint with a custom (JS) runner that extracts more info about each fix:

Oct 10 2017, 5:44 PM · Lint, Arcanist
csilvers created T13007: Integrating `arc lint` and auto-fixers.
Oct 10 2017, 5:11 PM · Lint, Arcanist

Sep 27 2017

epriestley closed T9749: `arc lint --only-new` doesn't work as expected as Resolved by committing rARC074dd8f3a6ec: Remove "arc lint --only-new".
Sep 27 2017, 3:21 PM · Restricted Project, Lint, Arcanist

Sep 25 2017

epriestley added a revision to T9749: `arc lint --only-new` doesn't work as expected: D18642: Remove "arc lint --only-new".
Sep 25 2017, 6:17 PM · Restricted Project, Lint, Arcanist

Sep 5 2017

epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18541: Fix a similar lint rendering issue when trimming identical lines out of patches.
Sep 5 2017, 11:53 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18538: Fix a prefix/suffix counting issue in Arcanist lint rendering.
Sep 5 2017, 6:50 PM · Restricted Project, Arcanist, Lint

Aug 31 2017

epriestley closed T9846: Diff on `arc lint` misleading when the replacement has newlines as Resolved by committing rARCad8214456add: Restore ANSI highlighting of lint sections to lint output.
Aug 31 2017, 8:29 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18512: Restore ANSI highlighting of lint sections to lint output.
Aug 31 2017, 8:06 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18511: Restore the caret pointer ("^") for lint lines which only have a character offset.
Aug 31 2017, 7:38 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18510: Render lint patches which have newlines in a less misleading way.
Aug 31 2017, 7:25 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18509: Extract and cover the logic for "trimming" a lint message.
Aug 31 2017, 4:18 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18508: Add basic test coverage for lint console rendering.
Aug 31 2017, 3:40 PM · Restricted Project, Arcanist, Lint

Aug 30 2017

epriestley added a comment to T9846: Diff on `arc lint` misleading when the replacement has newlines.

See also PHI48.

Aug 30 2017, 8:27 PM · Restricted Project, Arcanist, Lint

Aug 15 2017

epriestley removed a project from T9518: In diff summary linting error code shown instead of message, when PHP_CodeSniffer linter was used: Differential.
Aug 15 2017, 5:59 PM · Lint

Aug 10 2017

epriestley closed T6653: Script and regex linter could use some examples as Wontfix.

The community forum is a better place for this discussion. You may or may not receive help there, but we're no longer providing general Phabricator support here in the upstream (nor have we for a long time).

Aug 10 2017, 10:13 AM · Lint, Documentation, Arcanist
cmmata added a comment to T6653: Script and regex linter could use some examples.

I'm having problems with script-and-regex too. I have asked in the community forum but without luck. I’m trying to add phpstan to the arc lint workflow, as explained in the documentation, but I’m unable to capture the error message. Here are my files:

Aug 10 2017, 9:26 AM · Lint, Documentation, Arcanist
cmmata added a comment to T7091: Grep Linter.

ScriptAndRegexLinter needs to be modernized, but is strictly more powerful than the proposed linter. Something like this will implement your desired lint rule after the linter modernizes:

"todo": {
  "type": "script-and-regex",
  "script-and-regex.script": "grep -n TODO --",
  "script-and-regex.regex": "/^(?P<file>[^:]+):(?P<line>\\d+):/"
},
Aug 10 2017, 8:43 AM · Lint, Arcanist

Aug 6 2017

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Aug 6 2017, 6:51 PM · Lint, Arcanist

Jul 9 2017

chad removed the image for Lint.
Jul 9 2017, 7:37 PM

Jun 18 2017

waxmigs2902 added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

done! cheers

Jun 18 2017, 11:38 AM · Lint, Feature Request

Jun 12 2017

epriestley added a comment to T11150: ArcanistTextLinter: Support UTF8.

On a purely personal/aesthetic level, the box-drawing character block is total garbage and master ASCII artisans would never use it in serious work. A true connoisseur of the craft should accept nothing more than single-byte ASCII range in their collection.

Jun 12 2017, 2:13 PM · Restricted Project, Lint, Feature Request
epriestley added a comment to T11150: ArcanistTextLinter: Support UTF8.

See some related discussion in T12822. In particular:

Jun 12 2017, 2:06 PM · Restricted Project, Lint, Feature Request

Jun 1 2017

avivey renamed T10038: Plan the mid-term pathway for unit-test/linter bindings from Plan the mid-term pathway for linter bindings to Plan the mid-term pathway for unit-test/linter bindings.
Jun 1 2017, 7:48 PM · Lint, Arcanist

May 27 2017

epriestley merged T12765: Autofixes removing lines render incorrectly in `arc lint` into T9846: Diff on `arc lint` misleading when the replacement has newlines.
May 27 2017, 8:08 PM · Restricted Project, Arcanist, Lint
epriestley merged task T12765: Autofixes removing lines render incorrectly in `arc lint` into T9846: Diff on `arc lint` misleading when the replacement has newlines.
May 27 2017, 8:08 PM · Lint, Arcanist, Bug Report