Page MenuHomePhabricator

LintProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Feb 3 2021

epriestley closed T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors as Resolved.

I believe that covers all cases of this.

Feb 3 2021, 9:31 PM · Infrastructure, Lint
epriestley added a revision to T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors: D21538: Allow lint to correct the spelling of builtin symbols.
Feb 3 2021, 9:22 PM · Infrastructure, Lint
epriestley added a revision to T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors: D21537: When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized.
Feb 3 2021, 4:54 PM · Infrastructure, Lint

Jan 27 2021

epriestley triaged T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors as Low priority.
Jan 27 2021, 11:22 PM · Infrastructure, Lint

Jan 26 2021

epriestley closed T13595: Browsing directories with submodules fails with bad call to "setExternalURI()" as Resolved.

However, the existence of the original code might point at a bug in the "Variable Reused as Iterator" lint check: I would expect it to have prevented the original code in the first place.

Jan 26 2021, 11:03 PM · Diffusion, Lint
epriestley updated the task description for T13595: Browsing directories with submodules fails with bad call to "setExternalURI()".
Jan 26 2021, 5:38 PM · Diffusion, Lint
epriestley added a revision to T13595: Browsing directories with submodules fails with bad call to "setExternalURI()": D21520: Fix a "setExternalURI()" fatal while browsing directories with submodules.
Jan 26 2021, 4:42 PM · Diffusion, Lint
epriestley triaged T13595: Browsing directories with submodules fails with bad call to "setExternalURI()" as Normal priority.
Jan 26 2021, 4:37 PM · Diffusion, Lint

Apr 30 2020

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 30 2020, 8:16 AM · Lint, Arcanist

Apr 7 2020

epriestley moved T10971: php lint: catch `"${var}"` vs `"{$var}"` from Backlog to String Variables on the XHPAST board.
Apr 7 2020, 1:32 PM · XHPAST, Lint, Feature Request
epriestley renamed T8325: XHPASTLinter does not scope parameters to closures correctly from Treat functions with parameters defined in other functions in XHPASTLinter correctly to XHPASTLinter does not scope parameters to closures correctly.
Apr 7 2020, 1:31 PM · XHPAST, Lint
epriestley moved T8325: XHPASTLinter does not scope parameters to closures correctly from Backlog to Future on the XHPAST board.
Apr 7 2020, 1:30 PM · XHPAST, Lint

Apr 1 2020

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 1 2020, 1:50 PM · Lint, Arcanist

Feb 13 2020

epriestley closed T13489: Fix implicit "XMLWriter" requirement when loading lint sinks as Resolved by committing rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree.
Feb 13 2020, 9:38 PM · Lint, libphutil
epriestley added a revision to T13489: Fix implicit "XMLWriter" requirement when loading lint sinks: D20989: Don't depend on "XMLWriter" to load the lint renderer class tree.
Feb 13 2020, 9:37 PM · Lint, libphutil
epriestley triaged T13489: Fix implicit "XMLWriter" requirement when loading lint sinks as Low priority.
Feb 13 2020, 9:32 PM · Lint, libphutil

May 21 2019

joshuaspence added a revision to T6854: Modify the `lint-test` file format to allow for assertions against linter codes: D20532: Fix handling of empty line/column in linter tests.
May 21 2019, 8:02 AM · Lint
joshuaspence closed T6854: Modify the `lint-test` file format to allow for assertions against linter codes as Resolved by committing rARCdd514e268b2c: Modify the `lint-test` file format to allow for more powerful assertions.
May 21 2019, 3:48 AM · Lint

Oct 2 2018

epriestley moved T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint, Arcanist
epriestley moved T5730: `arc lint --everything` reporting all symbols missing in libphutil/ on Windows? from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Lint, Windows, Arcanist
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint` as Resolved.

Changes in T13209 make this the only mode.

Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a parent task for T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`: T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report

Sep 27 2018

epriestley closed T11517: arc lint missed some error reported from the golint as Wontfix.

This doesn't seem actionable and is likely mooted by T13098.

Sep 27 2018, 2:26 PM · Bug Report (Needs Information), Arcanist, Lint

Sep 24 2018

epriestley closed T6850: PHP Notices, when Linter Cache enabled as Wontfix.

This feature has been removed in experimental and wilds, and I don't currently expect to restore it.

Sep 24 2018, 4:38 PM · Lint, Arcanist
epriestley moved T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used from Backlog to Upstream on the Arcanist board.
Sep 24 2018, 4:04 PM · Lint, Arcanist

Sep 14 2018

epriestley added a parent task for T10038: Plan the mid-term pathway for unit-test/linter bindings: T13098: Plans: Arcanist toolsets and extensions.
Sep 14 2018, 6:09 PM · Lint, Arcanist

May 15 2018

epriestley renamed T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets from Arcanist linters do not handle UTF8 well to Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint, Arcanist
epriestley merged task T13139: Custom linters have no easy way to get line+char from char-offset in file into T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint
epriestley merged T13139: Custom linters have no easy way to get line+char from char-offset in file into T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint, Arcanist
avivey created T13139: Custom linters have no easy way to get line+char from char-offset in file.
May 15 2018, 6:08 PM · Lint

Mar 5 2018

epriestley moved T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:17 PM · Lint, Arcanist, Bug Report
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Unit/Lint Bindings to Upstream on the Arcanist board.
Mar 5 2018, 2:15 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T13059: Write a lint rule for detecting unreachable blocks from Backlog to Upstream on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Lint

Feb 3 2018

epriestley added a comment to T10817: Allow more characters for built-in `filename` linter.

(Future me, see also PHI343.)

Feb 3 2018, 8:09 PM · Lint, Feature Request
swisspol added a comment to T10817: Allow more characters for built-in `filename` linter.

The above workaround is not reliable since it skips the files entirely vs checking the remaining characters.

Feb 3 2018, 7:58 PM · Lint, Feature Request

Feb 2 2018

epriestley updated the task description for T13059: Write a lint rule for detecting unreachable blocks.
Feb 2 2018, 5:12 PM · Arcanist, Lint
epriestley triaged T13059: Write a lint rule for detecting unreachable blocks as Normal priority.
Feb 2 2018, 5:07 PM · Arcanist, Lint

Oct 10 2017

csilvers added a comment to T13007: Integrating `arc lint` and auto-fixers.

Oops, I filed it in the wrong place, my apologies!

Oct 10 2017, 6:39 PM · Lint, Arcanist
epriestley closed T13007: Integrating `arc lint` and auto-fixers as Invalid.

Please file feature requests through the community forum (https://discourse.phabricator-community.org) or a support pact (https://admin.phacility.com/book/phacility/article/support_pacts/).

Oct 10 2017, 6:23 PM · Lint, Arcanist
csilvers added a comment to T13007: Integrating `arc lint` and auto-fixers.

Doh!, I was looking at the jshint engine before, not the eslint engine. It looks like phab doesn't have built-in support for eslint yet. But this looks promising: maybe the autofixing eslint reports *is* on an error-by-error basis.

Oct 10 2017, 6:04 PM · Lint, Arcanist
sophiebits added a comment to T13007: Integrating `arc lint` and auto-fixers.

At Facebook we have a custom arcanist lint engine that wraps eslint with a custom (JS) runner that extracts more info about each fix:

Oct 10 2017, 5:44 PM · Lint, Arcanist
csilvers created T13007: Integrating `arc lint` and auto-fixers.
Oct 10 2017, 5:11 PM · Lint, Arcanist

Sep 27 2017

epriestley closed T9749: `arc lint --only-new` doesn't work as expected as Resolved by committing rARC074dd8f3a6ec: Remove "arc lint --only-new".
Sep 27 2017, 3:21 PM · Restricted Project, Lint, Arcanist

Sep 25 2017

epriestley added a revision to T9749: `arc lint --only-new` doesn't work as expected: D18642: Remove "arc lint --only-new".
Sep 25 2017, 6:17 PM · Restricted Project, Lint, Arcanist

Sep 5 2017

epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18541: Fix a similar lint rendering issue when trimming identical lines out of patches.
Sep 5 2017, 11:53 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18538: Fix a prefix/suffix counting issue in Arcanist lint rendering.
Sep 5 2017, 6:50 PM · Restricted Project, Arcanist, Lint

Aug 31 2017

epriestley closed T9846: Diff on `arc lint` misleading when the replacement has newlines as Resolved by committing rARCad8214456add: Restore ANSI highlighting of lint sections to lint output.
Aug 31 2017, 8:29 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18512: Restore ANSI highlighting of lint sections to lint output.
Aug 31 2017, 8:06 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: D18511: Restore the caret pointer ("^") for lint lines which only have a character offset.
Aug 31 2017, 7:38 PM · Restricted Project, Arcanist, Lint