Fix a "setExternalURI()" fatal while browsing directories with submodules
ClosedPublic
Actions

Authored by epriestley on Jan 26 2021, 4:42 PM.

Details

Reviewers: None
Maniphest Tasks: T13595: Browsing directories with submodules fails with bad call to "setExternalURI()"
Commits: rP510bdc74dbc3: (stable) Fix a "setExternalURI()" fatal while browsing directories with…
rP888604c9dd01: Fix a "setExternalURI()" fatal while browsing directories with submodules

Summary

Ref T13595. See that task for discussion.

D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it.

Test Plan

In Diffusion, browsed a directory with a submodule.
- Before: "setExternalURI()" fatal in conduit call.
- After: directory listing including submodule.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.Jan 26 2021, 4:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2021, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

diffusion/

conduit/

2 lines