Page MenuHomePhabricator

Fix a "setExternalURI()" fatal while browsing directories with submodules
ClosedPublic

Authored by epriestley on Jan 26 2021, 4:42 PM.

Details

Summary

Ref T13595. See that task for discussion.

D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it.

Test Plan
  • In Diffusion, browsed a directory with a submodule.
    • Before: "setExternalURI()" fatal in conduit call.
    • After: directory listing including submodule.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.