Differential D20989

Don't depend on "XMLWriter" to load the lint renderer class tree
ClosedPublic
Actions

Authored by epriestley on Thu, Feb 13, 9:37 PM.

Details

Reviewers: None
Maniphest Tasks: T13489: Fix implicit "XMLWriter" requirement when loading lint sinks
Commits: rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree

Summary

Fixes T13489. See that task for discussion.

Test Plan

Ran arc lint and arc lint --output xml. Faked a missing extension, ran arc lint (no problems) and arc lint --output xml (sensible error message).

Diff Detail

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Feb 13, 9:37 PM

Harbormaster completed remote builds in B23836: Diff 50010.Thu, Feb 13, 9:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Feb 13, 9:38 PM

epriestley requested review of this revision.

Closed by commit rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree.

Revision Contents
Changeset List

			Path	Packages
M			src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php (70 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50010	8c4f6ce		Thu, Feb 13, 9:37 PM	★	★
Diff 2	50011	8c4f6ce	rARC0d62a10eda68ea337988bcb6e28dc17c1abb9367	Thu, Feb 13, 9:38 PM	★	★

Diff 50011

View Options

src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php

Don't depend on "XMLWriter" to load the lint renderer class treeClosedPublicActions