Don't depend on "XMLWriter" to load the lint renderer class tree
ClosedPublic
Actions

Authored by epriestley on Feb 13 2020, 9:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 1:27 AM

	Unknown Object (File)
	Sun, Feb 9, 8:41 AM

	Unknown Object (File)
	Sun, Feb 9, 8:41 AM

	Unknown Object (File)
	Sun, Feb 9, 8:41 AM

	Unknown Object (File)
	Sat, Jan 25, 6:35 AM

	Unknown Object (File)
	Sat, Jan 25, 6:35 AM

	Unknown Object (File)
	Sat, Jan 25, 6:35 AM

	Unknown Object (File)
	Fri, Jan 24, 10:22 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13489: Fix implicit "XMLWriter" requirement when loading lint sinks
Commits: rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree

Summary

Fixes T13489. See that task for discussion.

Test Plan

Ran arc lint and arc lint --output xml. Faked a missing extension, ran arc lint (no problems) and arc lint --output xml (sensible error message).

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 13 2020, 9:37 PM

Harbormaster completed remote builds in B23836: Diff 50010.Feb 13 2020, 9:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 9:38 PM

epriestley requested review of this revision.

Closed by commit rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree.

Revision Contents
Changeset List

Path

Size

src/

lint/

renderer/

ArcanistCheckstyleXMLLintRenderer.php

70 lines

Diff 50011

View Options

src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php

Don't depend on "XMLWriter" to load the lint renderer class treeClosedPublicActions