Page MenuHomePhabricator

Fix implicit "XMLWriter" requirement when loading lint sinks
Closed, ResolvedPublic

Description

See PHI1634.

  • In D20986, the "LintRenderer" classes swapped to a modern modular pattern.
  • This invokes all of their constructors as a side effect.
  • The ArcanistCheckstyleXMLLintRenderer linter is written in an un-modern way and causes significant side effects during construction, notably failing if the XML extension which provides XMLWriter is not installed.

Instead:

  • ArcanistCheckstyleXMLLintRenderer should not instantiate XMLWriter on construction.
  • If the xml extension is not available, ArcanistCheckstyleXMLLintRenderer should fail more clearly/gracefully.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley created this task.
epriestley added a revision: Restricted Differential Revision.Feb 13 2020, 9:37 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Feb 13 2020, 9:38 PM
epriestley added a commit: Restricted Diffusion Commit.