Page MenuHomePhabricator

When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized
ClosedPublic

Authored by epriestley on Feb 3 2021, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:03 PM
Unknown Object (File)
Sun, Dec 15, 9:38 PM
Unknown Object (File)
Fri, Dec 13, 10:18 PM
Unknown Object (File)
Fri, Dec 13, 4:28 PM
Unknown Object (File)
Fri, Dec 6, 2:01 AM
Unknown Object (File)
Thu, Dec 5, 10:21 AM
Unknown Object (File)
Fri, Nov 29, 8:07 AM
Unknown Object (File)
Thu, Nov 28, 5:29 PM
Subscribers
None

Details

Summary

Ref T13598. If you spell a symbol like "Polygon" as "PoLyGoN", you currently get an "unknown symbol" lint message. However, provided "Polygon" is a valid symbol, we can unambiguously correct the spelling of the symbol.

Note that this patch can only correct the spelling of application symbols, not builtin symbols (since none of the library maps contain builtin symbols).

Test Plan

Screen Shot 2021-02-03 at 8.50.07 AM.png (931×1 px, 388 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable