Page MenuHomePhabricator
Differential D21538

Allow lint to correct the spelling of builtin symbols
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 9:21 PM.
Tags
None
Referenced Files
F15585343: D21538.diff
Thu, May 8, 8:10 AM
F15577834: D21538.id.diff
Tue, May 6, 4:24 PM
F15569738: D21538.id51268.diff
Sun, May 4, 4:00 AM
F15560263: D21538.id51267.diff
Tue, Apr 29, 1:44 PM
F15558578: D21538.id51268.diff
Tue, Apr 29, 3:57 AM
F15553421: D21538.id51270.diff
Mon, Apr 28, 2:00 AM
F15548489: D21538.id51267.diff
Sun, Apr 27, 12:06 AM
F15544769: D21538.id.diff
Sat, Apr 26, 6:56 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors
Commits
rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols
Summary

Ref T13598. This builds on D21537 and adds support for correcting the capitalization of builtin systems.

Test Plan
  • Linted a file that uses "ExCePtIoN", got a lint correction.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 3 2021, 9:21 PM
Harbormaster completed remote builds in B25081: Diff 51267.Feb 3 2021, 9:22 PM
epriestley requested review of this revision.Feb 3 2021, 9:22 PM
epriestley updated this revision to Diff 51268.Feb 3 2021, 9:22 PM
  • Slight formatting improvement.
Harbormaster completed remote builds in B25082: Diff 51268.Feb 3 2021, 9:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 9:26 PM
Closed by commit rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
67 lines
moduleutils/
22 lines
support/
lib/
54 lines

Diff 51270

View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

Loading...
View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
View Options

support/lib/extract-symbols.php

Loading...
Phabricator · Built by Phacility