Dec 16 2021
See also T13588.
Mar 17 2021
Mar 15 2021
This is relatively ripe for implementation now that inline comments support suggested edits.
Mar 12 2021
I think lint could reasonably emit two warnings about this:
Feb 3 2021
I believe that covers all cases of this.
Jan 27 2021
Jan 26 2021
However, the existence of the original code might point at a bug in the "Variable Reused as Iterator" lint check: I would expect it to have prevented the original code in the first place.
Apr 30 2020
Apr 7 2020
Apr 1 2020
Feb 13 2020
May 21 2019
Oct 2 2018
Changes in T13209 make this the only mode.
Sep 27 2018
This doesn't seem actionable and is likely mooted by T13098.
Sep 24 2018
This feature has been removed in experimental and wilds, and I don't currently expect to restore it.
Sep 14 2018
May 15 2018
Mar 5 2018
Feb 3 2018
(Future me, see also PHI343.)
The above workaround is not reliable since it skips the files entirely vs checking the remaining characters.
Feb 2 2018
Oct 10 2017
Oops, I filed it in the wrong place, my apologies!
Please file feature requests through the community forum (https://discourse.phabricator-community.org) or a support pact (https://admin.phacility.com/book/phacility/article/support_pacts/).
Doh!, I was looking at the jshint engine before, not the eslint engine. It looks like phab doesn't have built-in support for eslint yet. But this looks promising: maybe the autofixing eslint reports *is* on an error-by-error basis.
At Facebook we have a custom arcanist lint engine that wraps eslint with a custom (JS) runner that extracts more info about each fix: