Make legacy revision statuses from "differential.query" have type "string" again
ClosedPublic
Actions

Authored by epriestley on Aug 29 2017, 7:44 PM.

Details

Reviewers

chad
jmeador
lvital

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP70ebdd269455: (stable) Make legacy revision statuses from "differential.query" have type…
rPb4cbea901845: Make legacy revision statuses from "differential.query" have type "string" again

Summary

Ref T2543. The type on these got changed by accident, it should be "string" (crazy nonsense, compatible) not "int" (sensible, not compatible).

(New API uses sensible strings like "accepted" only.)

Test Plan

Called differential.query from web UI, saw "2" and similar statuses.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 29 2017, 7:44 PM

Harbormaster completed remote builds in B18207: Diff 44420.Aug 29 2017, 7:45 PM

jmeador accepted this revision.Aug 29 2017, 8:04 PM

This revision is now accepted and ready to land.Aug 29 2017, 8:04 PM

lvital accepted this revision.Aug 29 2017, 8:04 PM

Closed by commit rPb4cbea901845: Make legacy revision statuses from "differential.query" have type "string" again (authored by epriestley). · Explain WhyAug 29 2017, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialQueryConduitAPIMethod.php

6 lines

Diff 44421

View Options

src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php

Make legacy revision statuses from "differential.query" have type "string" againClosedPublicActions