Page MenuHomePhabricator

Make Differential inline events actually trigger comment preview refreshes
ClosedPublic

Authored by epriestley on Jan 19 2017, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:40 AM
Unknown Object (File)
Sun, Nov 17, 6:49 AM
Unknown Object (File)
Oct 23 2024, 10:11 AM
Unknown Object (File)
Oct 17 2024, 3:07 PM
Unknown Object (File)
Oct 14 2024, 12:10 PM
Unknown Object (File)
Sep 19 2024, 3:10 AM
Unknown Object (File)
Sep 5 2024, 10:40 PM
Unknown Object (File)
Sep 5 2024, 10:39 PM
Subscribers
None
Tokens
"100" token, awarded by jmeador.

Details

Summary

Earlier, I made some changes so that when you create or edit an inline, the comment at the bottom of the page updates (even though you didn't fiddle with the stacked actions inputs).

At the last second I broke them by spelling this wrong while cleaning things up, so they didn't actually work. Spell the property correctly ("showPreview", not "shouldPreview").

Also, we have some JS which rewrites "Not Visible" into "View", but it fires in an inconvenient way now and is flickery for me. Ideally this should get cleaned up slightly better eventualy, but at least make is stop doing so much flickery layout for now.

Test Plan
  • Wrote no comment on a revision.
  • Added an inline.
  • Saw comment preview properly update immediately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

webroot/rsrc/js/application/transactions/behavior-comment-actions.js
217

Here's the property being used elsewhere. My incorrect spelling, shouldPreview, appears nowhere in the codebase.

This revision is now accepted and ready to land.Jan 19 2017, 8:28 PM
This revision was automatically updated to reflect the committed changes.