Page MenuHomePhabricator

Reduce the cost of generating default user profile images
ClosedPublic

Authored by epriestley on Mar 2 2018, 12:51 AM.
Tags
None
Referenced Files
F19018465: D19168.diff
Sun, Nov 23, 11:13 AM
F18996943: D19168.id.diff
Thu, Nov 20, 9:07 AM
F18893572: D19168.id.diff
Fri, Nov 7, 1:01 PM
F18881028: D19168.diff
Thu, Nov 6, 8:56 PM
F18850323: D19168.id45914.diff
Thu, Oct 30, 3:50 PM
F18819536: D19168.id.diff
Oct 22 2025, 6:59 AM
F18783979: D19168.diff
Oct 13 2025, 11:19 AM
F18780766: D19168.id45914.diff
Oct 12 2025, 7:42 PM
Subscribers
None
Tokens
"Burninate" token, awarded by jmeador.

Details

Summary

See PHI413. You can pre-generate these with bin/people profileimage --all, but they're needlessly expensive to generate.

Streamline the workflow and cache some of the cacheable parts to reduce the generation cost.

Test Plan
  • Ran bin/people profileimage --all and saw cost drop from 15.801s4.839s.
  • Set defaultProfileImagePHID to NULL in phabricator_user.user and purged caches with bin/cache purge --all.
  • Loaded user directory.
  • Saw default images regenerate relatively quickly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 12:52 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.