Page MenuHomePhabricator

Reduce the cost of generating default user profile images
ClosedPublic

Authored by epriestley on Mar 2 2018, 12:51 AM.
Tags
None
Referenced Files
F15396868: D19168.diff
Sun, Mar 16, 4:42 PM
F15395616: D19168.id45914.diff
Sun, Mar 16, 8:28 AM
F15338977: D19168.diff
Sun, Mar 9, 1:50 PM
Unknown Object (File)
Feb 26 2025, 9:56 PM
Unknown Object (File)
Feb 8 2025, 9:04 PM
Unknown Object (File)
Feb 4 2025, 6:05 PM
Unknown Object (File)
Feb 2 2025, 12:48 PM
Unknown Object (File)
Feb 2 2025, 12:43 PM
Subscribers
None
Tokens
"Burninate" token, awarded by jmeador.

Details

Summary

See PHI413. You can pre-generate these with bin/people profileimage --all, but they're needlessly expensive to generate.

Streamline the workflow and cache some of the cacheable parts to reduce the generation cost.

Test Plan
  • Ran bin/people profileimage --all and saw cost drop from 15.801s4.839s.
  • Set defaultProfileImagePHID to NULL in phabricator_user.user and purged caches with bin/cache purge --all.
  • Loaded user directory.
  • Saw default images regenerate relatively quickly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 12:52 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.