Page MenuHomePhabricator

Reduce the cost of generating default user profile images
ClosedPublic

Authored by epriestley on Mar 2 2018, 12:51 AM.
Tags
None
Referenced Files
F19908172: D19168.diff
Wed, Apr 1, 4:47 PM
F19908168: D19168.diff
Wed, Apr 1, 4:47 PM
F19893921: D19168.id45915.diff
Sat, Mar 28, 10:24 AM
F19862969: D19168.id45914.diff
Mar 14 2026, 10:59 AM
F19822758: D19168.id45915.diff
Mar 7 2026, 8:12 AM
F19821395: D19168.id.diff
Mar 6 2026, 9:40 PM
F19677593: D19168.id45915.diff
Feb 8 2026, 2:33 PM
F19561746: D19168.id45915.diff
Jan 31 2026, 11:23 AM
Subscribers
None
Tokens
"Burninate" token, awarded by jmeador.

Details

Summary

See PHI413. You can pre-generate these with bin/people profileimage --all, but they're needlessly expensive to generate.

Streamline the workflow and cache some of the cacheable parts to reduce the generation cost.

Test Plan
  • Ran bin/people profileimage --all and saw cost drop from 15.801s4.839s.
  • Set defaultProfileImagePHID to NULL in phabricator_user.user and purged caches with bin/cache purge --all.
  • Loaded user directory.
  • Saw default images regenerate relatively quickly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 12:52 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.