Ref T12600. Basically all the property (not path) information on a hovercard for owner packages.
Details
Details
- Reviewers
epriestley jmeador - Maniphest Tasks
- T12600: Update Hovercards
- Commits
- rP782471052265: Add an Owners Package hovercard
Create a package with LOTS OF RULES. Test it as open and archived states.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Really a very very beautiful hovercard. It's going to be great. Fantastic job. Really really proud of this hovercard.
Comment Actions
Couple inlines just to prove that I looked.
We could probably drop "Auto Review" and "Dominion", I think they're probably only of much use when editing/configuring the package.
| src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php | ||
|---|---|---|
| 49 | Could use getMonogram(). | |
| src/view/phui/PHUIHovercardView.php | ||
| 123 | What about common and useful title "0"?! | |
| src/view/phui/PHUIHovercardView.php | ||
|---|---|---|
| 123 | dammit | |