Page MenuHomePhabricator

Add an Owners Package hovercard
ClosedPublic

Authored by chad on Apr 26 2017, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 26, 9:43 AM
Unknown Object (File)
Tue, Jun 17, 12:46 PM
Unknown Object (File)
May 29 2025, 9:18 AM
Unknown Object (File)
May 10 2025, 1:44 PM
Unknown Object (File)
Apr 28 2025, 11:50 AM
Unknown Object (File)
Apr 28 2025, 5:03 AM
Unknown Object (File)
Apr 26 2025, 8:57 PM
Unknown Object (File)
Apr 26 2025, 11:00 AM
Subscribers

Details

Summary

Ref T12600. Basically all the property (not path) information on a hovercard for owner packages.

Test Plan

Create a package with LOTS OF RULES. Test it as open and archived states.

pasted_file (494×976 px, 62 KB)

pasted_file (496×1 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jmeador added a subscriber: jmeador.

Really a very very beautiful hovercard. It's going to be great. Fantastic job. Really really proud of this hovercard.

This revision is now accepted and ready to land.Apr 26 2017, 6:58 AM
This revision was automatically updated to reflect the committed changes.

Couple inlines just to prove that I looked.

We could probably drop "Auto Review" and "Dominion", I think they're probably only of much use when editing/configuring the package.

src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
49

Could use getMonogram().

src/view/phui/PHUIHovercardView.php
123

What about common and useful title "0"?!

src/view/phui/PHUIHovercardView.php
123

dammit