Page MenuHomePhabricator
Differential D17793

Add an Owners Package hovercard
ClosedPublic
Actions

Authored by chad on Apr 26 2017, 12:31 AM.
Tags
None
Referenced Files
F15459779: D17793.id42785.diff
Mon, Mar 31, 4:12 PM
F15423666: D17793.id42787.diff
Sat, Mar 22, 4:35 PM
F15396917: D17793.diff
Sun, Mar 16, 4:57 PM
F15334986: D17793.id.diff
Mar 8 2025, 1:33 PM
F15334873: D17793.id42785.diff
Mar 8 2025, 12:52 PM
F15330865: D17793.id42787.diff
Mar 7 2025, 8:06 AM
F15312119: D17793.id42787.diff
Mar 6 2025, 2:06 PM
Unknown Object (File)
Mar 3 2025, 3:41 PM
View All Files
Subscribers
jmeador
Korvin

Details

Reviewers
epriestley
jmeador
Maniphest Tasks
T12600: Update Hovercards
Commits
rP782471052265: Add an Owners Package hovercard
Summary

Ref T12600. Basically all the property (not path) information on a hovercard for owner packages.

Test Plan

Create a package with LOTS OF RULES. Test it as open and archived states.

pasted_file (494×976 px, 62 KB)

pasted_file (496×1 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Apr 26 2017, 12:31 AM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 26 2017, 12:31 AM
chad edited the test plan for this revision. (Show Details)Apr 26 2017, 12:32 AM
Harbormaster completed remote builds in B16712: Diff 42785.Apr 26 2017, 12:32 AM
chad edited the test plan for this revision. (Show Details)Apr 26 2017, 12:34 AM
jmeador accepted this revision.Apr 26 2017, 6:58 AM
jmeador added a subscriber: jmeador.

Really a very very beautiful hovercard. It's going to be great. Fantastic job. Really really proud of this hovercard.

This revision is now accepted and ready to land.Apr 26 2017, 6:58 AM
Closed by commit rP782471052265: Add an Owners Package hovercard (authored by chad, committed by chad). · Explain WhyApr 26 2017, 3:45 PM
This revision was automatically updated to reflect the committed changes.
epriestley edited edge metadata.Apr 26 2017, 5:04 PM

Couple inlines just to prove that I looked.

We could probably drop "Auto Review" and "Dominion", I think they're probably only of much use when editing/configuring the package.

src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
49

Could use getMonogram().

src/view/phui/PHUIHovercardView.php
123

What about common and useful title "0"?!

chad added inline comments.Apr 26 2017, 5:06 PM
src/view/phui/PHUIHovercardView.php
123

dammit

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
owners/
engineextension/
89 lines
view/
phui/
7 lines

Diff 42787

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php

Loading...
View Options

src/view/phui/PHUIHovercardView.php

Loading...
Phabricator · Built by Phacility