Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

May 1 2020

epriestley edited the content of Changelog.
May 1 2020, 8:01 PM
epriestley created an object: 2020 Week 17 (Very Early May).
May 1 2020, 7:59 PM
epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: Unknown Object (Differential Revision).
May 1 2020, 7:22 PM · Differential
epriestley renamed T13529: Phacility domain rename errata and SSH user identity from Phacility domain errata to Phacility domain rename errata and SSH user identity.
May 1 2020, 5:25 PM · Phacility
epriestley closed T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available as Resolved.

I think that covers things here.

May 1 2020, 4:48 PM · Paste
epriestley updated the task description for T13529: Phacility domain rename errata and SSH user identity.
May 1 2020, 4:39 PM · Phacility
epriestley triaged T13529: Phacility domain rename errata and SSH user identity as Wishlist priority.
May 1 2020, 4:34 PM · Phacility
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Restricted Differential Revision.
May 1 2020, 4:09 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 4:07 PM · Paste
epriestley created P2142 Command-Line Input.
May 1 2020, 3:50 PM
epriestley created P2141 Command-Line Input.
May 1 2020, 3:49 PM
epriestley created P2140 Command-Line Input.
May 1 2020, 3:49 PM
epriestley created P2139 Command-Line Input.
May 1 2020, 3:49 PM
epriestley created P2138 Command-Line Input.
May 1 2020, 3:48 PM
epriestley created P2137 Command-Line Input.
May 1 2020, 3:47 PM
epriestley created P2136 Command-Line Input.
May 1 2020, 3:43 PM
epriestley created P2135 Command-Line Input.
May 1 2020, 3:43 PM
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 3:07 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 2:39 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 2:26 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Restricted Differential Revision.
May 1 2020, 2:10 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 2:05 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 1:57 PM · Paste
epriestley added a revision to T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available: Unknown Object (Differential Revision).
May 1 2020, 1:53 PM · Paste
epriestley triaged T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available as Low priority.
May 1 2020, 1:48 PM · Paste
claassen added a comment to T13488: Upgrading: Early 2020 Changes to Arcanist.

Thanks for the quick response! I'll give your suggestions a try, and else will continue on Discourse. Was not aware of its existence.

May 1 2020, 11:32 AM · Arcanist, Installing & Upgrading
epriestley added a comment to T13488: Upgrading: Early 2020 Changes to Arcanist.

(This kind of question is best asked on Discourse.)

May 1 2020, 10:55 AM · Arcanist, Installing & Upgrading
claassen added a comment to T13488: Upgrading: Early 2020 Changes to Arcanist.

We were using the --skip-arcconfig option like this in our CI environment (jenkins).

May 1 2020, 8:28 AM · Arcanist, Installing & Upgrading
dwilches added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Thanks! I didn't know it could be done from the web UI.

May 1 2020, 3:32 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Apr 30 2020

epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

You can open the revision in the web UI and "Request Review". You can use arc diff --browse ... to open the web UI automatically.

Apr 30 2020, 9:00 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
adrelanos added a watcher for Security: adrelanos.
Apr 30 2020, 7:59 PM
dwilches added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

We just found a real issue with this, different from what I mentioned above: We had an issue with our CI machine, and to fix it we needed to make a diff. But as the CI machine is not working, the diff won't build, which means we can't accept the diff that will solve the issue.

Apr 30 2020, 7:25 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
dwilches added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Is there a way to disable this option via a config in the server or a CLI parameter?

Apr 30 2020, 5:21 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan.

See https://discourse.phabricator-community.org/t/typeerror-w-arc-diff-when-build-plan-view-policy-does-not-contain-user/3820/. The reproduction case is "policy makes the build plan invisible".

Apr 30 2020, 3:46 PM · Harbormaster
epriestley added a revision to T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan: Unknown Object (Differential Revision).
Apr 30 2020, 2:47 PM · Harbormaster
epriestley closed T13527: "mb_check_encoding()" may rase a warning if passed an object which implements "__toString()" as Resolved by committing Restricted Diffusion Commit.
Apr 30 2020, 2:19 PM · Infrastructure
epriestley added a revision to T13527: "mb_check_encoding()" may rase a warning if passed an object which implements "__toString()": Unknown Object (Differential Revision).
Apr 30 2020, 2:14 PM · Infrastructure
epriestley triaged T13527: "mb_check_encoding()" may rase a warning if passed an object which implements "__toString()" as Low priority.
Apr 30 2020, 2:11 PM · Infrastructure
avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 30 2020, 8:16 AM · Lint, Arcanist
epriestley edited the content of 2020 Week 16 (Late April).
Apr 30 2020, 3:49 AM
Krinkle added a comment to 2020 Week 16 (Late April).

Spotted a typo, arcainst :)

Apr 30 2020, 1:22 AM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
Apr 30 2020, 12:15 AM · Inline Comments, Diffusion, Differential

Apr 29 2020

epriestley added a revision to T13519: Support collapsing folders in the diff paths panel: Unknown Object (Differential Revision).
Apr 29 2020, 9:45 PM · Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

As of D21188, inlines have these remaining weird behaviors:

Apr 29 2020, 7:16 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
Apr 29 2020, 7:00 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
Apr 29 2020, 6:34 PM · Inline Comments, Diffusion, Differential
seporaitis added a comment to T12220: New custom type field: Project Tags.

Just a question - are there any technical reasons why providing custom field for "projects" may not be a good idea?

Apr 29 2020, 3:36 PM · Custom Fields, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
Apr 29 2020, 2:56 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

In the DOM, inline comments are currently structured as a "comment row", followed by zero or more related rows (which may contain the editor UI or the undo UI).

Apr 29 2020, 2:12 PM · Inline Comments, Diffusion, Differential

Apr 28 2020

epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

OKAY SO

Apr 28 2020, 9:29 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
Apr 28 2020, 8:48 PM · Inline Comments, Diffusion, Differential
20after4 updated 20after4.
Apr 28 2020, 7:32 PM
epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: Unknown Object (Differential Revision).
Apr 28 2020, 7:23 PM · Differential
epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: Unknown Object (Differential Revision).
Apr 28 2020, 7:06 PM · Differential
epriestley moved T12982: In Differential, diff-of-diffs where both diffs added an identical file is misleading from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:27 PM · Differential
epriestley moved T10500: When diffing B against A in Differential, files touched in A but not B should be finessed better from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:26 PM · Restricted Project, Differential
epriestley moved T9792: Download raw diff from Differential weirdness regarding diff including binary files additions/deletions from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:26 PM · Differential
epriestley moved T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:23 PM · Differential
epriestley renamed T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes from Update logic around interdiff changesets to better handle binary files, header information, and attributes to Update logic around intradiff changesets to better handle binary files, header information, and attributes.
Apr 28 2020, 1:22 PM · Differential
epriestley moved T1101: Allow Show Raw File for updated added files from v2 (UI/Mobile) to Intradiffs on the Differential board.
Apr 28 2020, 1:22 PM · Differential
epriestley added a revision to T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes: Unknown Object (Differential Revision).
Apr 28 2020, 12:00 PM · Differential
epriestley closed T13525: "apcu_store()" may raise "GC cache entry ..." errors as Resolved by committing Restricted Diffusion Commit.
Apr 28 2020, 11:13 AM · Infrastructure
epriestley added a comment to T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan.

I'm having trouble reproducing figuring out how to reproduce this locally.

Apr 28 2020, 11:05 AM · Harbormaster
epriestley triaged T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan as Low priority.
Apr 28 2020, 10:57 AM · Harbormaster
epriestley added a revision to T13525: "apcu_store()" may raise "GC cache entry ..." errors: Unknown Object (Differential Revision).
Apr 28 2020, 10:56 AM · Infrastructure
epriestley triaged T13525: "apcu_store()" may raise "GC cache entry ..." errors as Normal priority.
Apr 28 2020, 10:52 AM · Infrastructure

Apr 27 2020

epriestley added a comment to T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes.

These issues are somewhat complicated because changesets currently have a single changeType attribute and a single fileType attribute, and a lot of rendering logic depends on these attributes. This model isn't correct in the general case.

Apr 27 2020, 10:42 PM · Differential
epriestley closed T13524: "Undefined index" exception in ChangesetParser while viewing diffs as Resolved.

This seems to be fixed and has deployed to the cluster.

Apr 27 2020, 9:56 PM · Differential
epriestley added a revision to T13524: "Undefined index" exception in ChangesetParser while viewing diffs: Unknown Object (Differential Revision).
Apr 27 2020, 9:18 PM · Differential
epriestley added a comment to T13524: "Undefined index" exception in ChangesetParser while viewing diffs.

This appears to be an issue with synthetic lint messages from Harbormaster that do not specify a line number. We reach this section of the code:

Apr 27 2020, 9:09 PM · Differential
epriestley triaged T13524: "Undefined index" exception in ChangesetParser while viewing diffs as Normal priority.
Apr 27 2020, 8:51 PM · Differential
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 27 2020, 7:41 PM · Arcanist, Installing & Upgrading
epriestley edited the content of 2020 Week 16 (Late April).
Apr 27 2020, 7:15 PM
epriestley triaged T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes as Normal priority.
Apr 27 2020, 3:45 PM · Differential
epriestley added a revision to T13522: Compute an internal content hash of large files using hash-of-hashes: Unknown Object (Differential Revision).
Apr 27 2020, 3:29 PM · Differential, Files
epriestley triaged T13522: Compute an internal content hash of large files using hash-of-hashes as Wishlist priority.
Apr 27 2020, 2:48 PM · Differential, Files
epriestley updated the task description for T13455: Make "View Options" in Differential sticky across reloads.
Apr 27 2020, 2:32 PM · Differential
epriestley closed T13455: Make "View Options" in Differential sticky across reloads as Resolved.
  • Followups on "Hidden" logic have moved to T13519.
Apr 27 2020, 2:32 PM · Differential
epriestley closed T13455: Make "View Options" in Differential sticky across reloads, a subtask of T13515: Differential: Inlines and View Options, as Resolved.
Apr 27 2020, 2:32 PM · Differential
epriestley closed T13516: Remove the "filetree" setting (so it's always enabled for everyone), a subtask of T13515: Differential: Inlines and View Options, as Resolved.
Apr 27 2020, 2:31 PM · Differential
epriestley closed T13516: Remove the "filetree" setting (so it's always enabled for everyone) as Resolved.
  • Collapsing paths has moved forward to T13519.
  • Table of Contents updates have moved forward to T13520.
  • FormationView issues have moved forward to T13521.
Apr 27 2020, 2:31 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 27 2020, 2:30 PM · Diffusion, Differential
epriestley triaged T13521: FormationView could do more Javascript magic around device layouts and header elements as Low priority.
Apr 27 2020, 2:30 PM · Differential
epriestley triaged T13520: Update the diff table of contents for moved files, long paths, etc as Normal priority.
Apr 27 2020, 2:24 PM · Differential
epriestley triaged T13519: Support collapsing folders in the diff paths panel as Low priority.
Apr 27 2020, 2:15 PM · Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 27 2020, 2:10 PM · Diffusion, Differential
hoeflingd added a watcher for Phrequent: hoeflingd.
Apr 27 2020, 8:23 AM

Apr 26 2020

epriestley added a revision to T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed: Unknown Object (Differential Revision).
Apr 26 2020, 3:32 PM · Infrastructure
epriestley added a revision to T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed: Unknown Object (Differential Revision).
Apr 26 2020, 3:30 PM · Infrastructure
epriestley updated the task description for T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed.
Apr 26 2020, 3:27 PM · Infrastructure
epriestley triaged T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed as Low priority.
Apr 26 2020, 3:27 PM · Infrastructure
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

With PHP 7.4, it seems OpenSSL (and various other libraries) have moved to pkg-config, which is a tool that uses the PKG_CONFIG_PATH environmental variable to locate packages. This impacts OpenSSL and libxml2.

Apr 26 2020, 3:02 PM · Infrastructure

Apr 25 2020

epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

At time of writing, calls to rest/api/3/myself now return this:

Apr 25 2020, 9:04 PM · Auth
epriestley added a revision to T13493: JIRA API has changed identifiers from "key" to "accountId": Unknown Object (Differential Revision).
Apr 25 2020, 9:01 PM · Auth
epriestley added a comment to T13493: JIRA API has changed identifiers from "key" to "accountId".

At time of writing, calls to rest/auth/1/session return a result like this:

Apr 25 2020, 8:59 PM · Auth
epriestley closed T13517: Cloning repositories over HTTPS may fail after compression changes as Resolved.

I believe D21167 fixed this.

Apr 25 2020, 4:24 PM · Diffusion
epriestley added a revision to T13517: Cloning repositories over HTTPS may fail after compression changes: Unknown Object (Differential Revision).
Apr 25 2020, 2:40 PM · Diffusion
epriestley added a comment to T13517: Cloning repositories over HTTPS may fail after compression changes.

The request sequence here is:

Apr 25 2020, 2:37 PM · Diffusion
epriestley triaged T13517: Cloning repositories over HTTPS may fail after compression changes as Normal priority.
Apr 25 2020, 2:29 PM · Diffusion

Apr 24 2020

epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): Unknown Object (Differential Revision).
Apr 24 2020, 6:21 PM · Diffusion, Differential
First
Prev
Next
Phabricator · Built by Phacility