Page MenuHomePhabricator
Feed All Stories

May 19 2016

epriestley moved T10917: Build Glorious High-Security Notification/Audit Infrastructure from The Queue to Paused on the Prioritized board.

In HEAD of master, keys now have a detail screen which shows a transaction record. Clicking the key name will take you there:

May 19 2016, 10:20 PM · Auth, Prioritized, Security, Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 10:13 PM · Auth, Prioritized, Security, Feature Request
epriestley closed T10991: Clustering Introduction links to non-existent Drydock Security documentation as Resolved by committing Restricted Diffusion Commit.
May 19 2016, 9:59 PM · Documentation, Bug Report
epriestley added a revision to T10939: Support for OWNERS files: Restricted Differential Revision.
May 19 2016, 8:46 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 19 2016, 8:32 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10991: Clustering Introduction links to non-existent Drydock Security documentation: Unknown Object (Differential Revision).
May 19 2016, 7:35 PM · Documentation, Bug Report
epriestley claimed T10991: Clustering Introduction links to non-existent Drydock Security documentation.
May 19 2016, 7:34 PM · Documentation, Bug Report
kebe added a comment to T10378: Custom text field does not show up in Advanced Search.

Same here. I've created customfield "Requirement" to identify external Requirement ID. Searching using Contains Words is inadequate cause it search all fields containing similar string.

May 19 2016, 6:11 PM · Restricted Project, Custom Fields, Bug Report
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 6:04 PM · Auth, Prioritized, Security, Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 5:20 PM · Auth, Prioritized, Security, Feature Request
chad added a project to T10991: Clustering Introduction links to non-existent Drydock Security documentation: Documentation.
May 19 2016, 5:08 PM · Documentation, Bug Report
chad added projects to T10931: Changing mysql.implementation setting doesn't work: Database, Setup.
May 19 2016, 5:08 PM · Setup, Database, Bug Report
urzds created T10991: Clustering Introduction links to non-existent Drydock Security documentation.
May 19 2016, 5:07 PM · Documentation, Bug Report
chad added a project to T10920: Allow assigning a diff to a commit post-facto: Diffusion.
May 19 2016, 5:07 PM · Diffusion, Feature Request
chad added a project to T10811: `phd-daemon` crash after automatic restart following config change: Daemons.
May 19 2016, 5:07 PM · Daemons, Bug Report
chad added a project to T10956: Multiple active edit forms: EditEngine.
May 19 2016, 4:52 PM · EditEngine, Feature Request
chad created EditEngine.
May 19 2016, 4:52 PM
chad added a comment to T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter.".

Can you list out a complete set of reproducible steps to follow? Is this a Dashboard you're building and installing on other people homepages, for example?

May 19 2016, 4:51 PM · Audit, Bug Report
chad added a project to T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter.": Audit.
May 19 2016, 4:50 PM · Audit, Bug Report
chad added a project to T10982: Harbormaster builds fail to allocate resource: Harbormaster.
May 19 2016, 4:49 PM · Harbormaster, Bug Report
chad added a subtask for T10987: /config/issue/ causes coredump in PHP-FPM: T9640: Make Phabricator compatible with PHP7.
May 19 2016, 4:49 PM · Bug Report
chad added a parent task for T9640: Make Phabricator compatible with PHP7: T10987: /config/issue/ causes coredump in PHP-FPM.
May 19 2016, 4:49 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 4:06 PM · Auth, Prioritized, Security, Feature Request
ilendir added a comment to T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation.

That is actually a great idea and way more elegant. Keep up the great work and thanks for your effort!

May 19 2016, 3:47 PM · Feature Request
faulconbridge added a comment to Q391: Meaning of each databases and tables used by Phabricator.

Source code isn't (AFAIK) stored in Phabricator's databases; it only lives at /var/repo/ and whatever other URIs you're mirroring/observing in Diffusion. But again, if you're just looking for commit-level metadata, using Conduit will probably be easier.

May 19 2016, 2:57 PM · Restricted Project, Database
• tukamon added a comment to Q391: Meaning of each databases and tables used by Phabricator.

The use case is take all of that info as ETL input, but I what to be sure that I am not retrieveing source code from the tables as a matter of performance in addition to I am not interested in it.
What do you think is the best way to do that?

May 19 2016, 2:52 PM · Restricted Project, Database
epriestley added a comment to T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation.

See some discussion of SELinux in T4947. We'd prefer to find a way to detect that SELinux or AppArmor are running, and warn the user only if they are affected. We've generally had much greater success with raising specific setup warnings during setup than with putting notes in documentation (which users often do not read). We do not currently have a test for SELinux / AppArmor, although it is possible that these tests are straightforward.

May 19 2016, 2:25 PM · Feature Request
ilendir added a comment to T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation.

Agreed with the systemd part, that would have been just for convenience of new users.

May 19 2016, 2:21 PM · Feature Request
sisicaivrai added a comment to T10460: Commit Still Parsing.

I am solving this problem. Reason was in empty Callsign in setting repository. After I added callsing, revisions became openable for audits.

P.S. Sorry for my english.

May 19 2016, 2:13 PM · Diffusion, Bug Report (Needs Information)
sisicaivrai added Q393: PhabricatorTaskmasterDaemon has recurrent failing tasks with fatal errors (Answer 380).
May 19 2016, 2:09 PM
epriestley added a comment to T10989: Moving task in the same column of the workboard causes its update.

Third-party applications which assume dateModified means "last 'meaningful' update" are written incorrectly. It does not mean that, it is not documented to mean that anywhere, and it is clear from the code that it doesn't have this behavior. It is unreasonable to assume that the only possible purpose of this field is metric extraction. This field is a low-level field which serves a different set of goals. It explicitly does not serve metric extraction goals.

May 19 2016, 1:46 PM · Workboards, Bug Report
Danny_B awarded T5267: Localize Phabricator a Mountain of Wealth token.
May 19 2016, 1:42 PM · Prioritized, Localization
eadler added a comment to T10989: Moving task in the same column of the workboard causes its update.

It's logical - you can not build reasonably working application on wrong dataset. One would assume, that maybe in future, Phabricator (either directly or via an extension) will have support for such stats too (as it currently already has some stats such as burnout charts or so...)

May 19 2016, 1:30 PM · Workboards, Bug Report
Danny_B added a comment to T10989: Moving task in the same column of the workboard causes its update.

These are third-party extensions, not other upstream applications, right?

Yes.

Why do you consider this to be a bug in Phabricator rather than in those extensions? Does the documentation say "this field is updated only when a 'meaningful' update is made to an object, and you can and should rely on it to have this behavior when extracting data from Phabricator" somewhere?

It's logical - you can not build reasonably working application on wrong dataset. One would assume, that maybe in future, Phabricator (either directly or via an extension) will have support for such stats too (as it currently already has some stats such as burnout charts or so...)
Inability to do such stats due to unreasonable dataset below makes Phabricator (otherwise good application) useless for teams which are trying to improve (read: shorten in this particular case) the task life-cycle - and that's pretty much every team since noone wants to have long time untouched tasks without any action taken... ;-)

May 19 2016, 1:28 PM · Workboards, Bug Report
eadler added a comment to T10939: Support for OWNERS files.

I'm referring to the home page dashboard.

By this I mean: as installed on the FreeBSD install.

May 19 2016, 1:23 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Ah! Okay, cool. Not really PEBCAK, I need to fix that dashboard too and it's super confusing that it does something weird/different with no clues about it. I just wanted to see if anyone caught major issues with the new one before swapping it.

May 19 2016, 1:21 PM · Prioritized, Restricted Project, Owners
eadler added a comment to T10939: Support for OWNERS files.

I'm referring to the home page dashboard. I just made some config changes (particularly, changing the limit of the number of revisions to show) and it seems to have 'fixed it' so the problem above would be PEBKAC :/

May 19 2016, 1:17 PM · Prioritized, Restricted Project, Owners
urzds added a comment to T10349: Projects v3 Errata.

Selecting Exact Projects: Searching for a superproject currently searches for objects tagged with that project or any subproject. We may introduce a function like exact(#superproject) in the future to search only for a superproject, exactly. However, it's not clear if this is really necessary or has any use cases.

May 19 2016, 1:01 PM · Restricted Project, Projects (v3)
epriestley added a comment to T10989: Moving task in the same column of the workboard causes its update.

In fact it breaks various monitoring/statistics depending on last update

May 19 2016, 12:55 PM · Workboards, Bug Report
Danny_B added a comment to T10989: Moving task in the same column of the workboard causes its update.

But moving on the workboard is no update at all... It is null action.

May 19 2016, 12:48 PM · Workboards, Bug Report
epriestley closed T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation as Wontfix.

System-specific configuration like SELinux and systemd is outside the scope of Phabricator. See T4200 for discussion.

May 19 2016, 12:27 PM · Feature Request
epriestley closed T10988: Unable to Import an Existing External Repository as Invalid.

https://secure.phabricator.com/book/phabricator/article/diffusion_uris/#observe-a-repository

May 19 2016, 12:24 PM · Bug Report
sisicaivrai updated Q393: PhabricatorTaskmasterDaemon has recurrent failing tasks with fatal errors from to PhabricatorTaskmasterDaemon has recurrent failing tasks with fatal errors.
May 19 2016, 12:23 PM · Daemons
epriestley closed T10989: Moving task in the same column of the workboard causes its update as Invalid.

"Last Update" is low level, and includes some actions which do not appear in the task history. This is expected.

May 19 2016, 12:22 PM · Workboards, Bug Report
ilendir updated subscribers of T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation.
May 19 2016, 12:18 PM · Feature Request
ilendir created T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation.
May 19 2016, 12:16 PM · Feature Request
Danny_B created T10989: Moving task in the same column of the workboard causes its update.
May 19 2016, 9:23 AM · Workboards, Bug Report
ilendir added a comment to T7090: Permission Denied when following User-guide to setup access to repo via SSH.

SELinux is currently disabled (until everything else works, then it's that project).

The Permission Denied is the result from when the SSHd tries to execute the 'phabricator-ssh-hook.sh'.

The log output is the following:

Jan 29 00:16:44 sshd[19506]: error: AuthorizedKeysCommand /path/to/phabricator-ssh-hook.sh returned status 126
Jan 29 00:16:44 sshd[19506]: error: AuthorizedKeysCommand /path/to/phabricator-ssh-hook.sh returned status 126
Jan 29 00:16:44 sshd[19506]: error: AuthorizedKeysCommand /path/to/phabricator-ssh-hook.sh returned status 126
Jan 29 00:16:44 sshd[19506]: error: AuthorizedKeysCommand /path/to/phabricator-ssh-hook.sh returned status 126
Jan 29 00:16:44 sshd[19506]: error: AuthorizedKeysCommand /path/to/phabricator-ssh-hook.sh returned status 126
Jan 29 00:21:36 sshd[20143]: Disconnecting: Too many authentication failures for vcs-user [preauth]

Some trial and error showed that it occurred when the script attempted to run ./bin/ssh-auth

May 19 2016, 8:58 AM · Diffusion
adelabreteche updated the task description for T10988: Unable to Import an Existing External Repository .
May 19 2016, 8:00 AM · Bug Report
adelabreteche created T10988: Unable to Import an Existing External Repository .
May 19 2016, 7:58 AM · Bug Report
• qwazarok added a comment to F1648524: 88px-Example.bmp.

[[ URL | name ]]F1648524

May 19 2016, 7:07 AM
chad added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

D14566 might fix this? See also T9640.

May 19 2016, 2:48 AM · Bug Report
chad added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

PHP7 is currently unsupported, I would start there and move to 5.6 or whatever you prefer.

May 19 2016, 2:46 AM · Bug Report
davidism added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

Yes, I tried it on my work computer (same versions and configuration), and then on my home computer.

May 19 2016, 2:41 AM · Bug Report
chad added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

Can you reproduce this on another machine?

May 19 2016, 2:39 AM · Bug Report
davidism renamed T10987: /config/issue/ causes coredump in PHP-FPM from /config/issue/ causes core in PHP-FPM to /config/issue/ causes coredump in PHP-FPM.
May 19 2016, 2:27 AM · Bug Report
davidism created T10987: /config/issue/ causes coredump in PHP-FPM.
May 19 2016, 2:27 AM · Bug Report

May 18 2016

Luke081515.2 added a project to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard: Wikimedia.
May 18 2016, 11:54 PM · Wikimedia, Pholio, Bug Report
volker_e created T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.
May 18 2016, 10:51 PM · Wikimedia, Pholio, Bug Report
epriestley closed T10985: Color change as Spite.
May 18 2016, 10:20 PM · Feature Request
• awebbdesigner created T10985: Color change.
May 18 2016, 10:19 PM · Feature Request
epriestley moved T10694: Improve behavior of context for inline comments in mail from The Queue to Paused on the Prioritized board.

Inlined patches are now highlighted more nicely in HTML mail.

May 18 2016, 10:19 PM · Prioritized, Restricted Project, Differential, Mail
faulconbridge added a comment to Q391: Meaning of each databases and tables used by Phabricator.

If you really want to muck around in Phabricator's databases, you could probably get at the information you mentioned with something similar to

May 18 2016, 8:41 PM · Restricted Project, Database
chad changed the image for Image Macro "parrot".
May 18 2016, 7:59 PM
epriestley added a comment to T10939: Support for OWNERS files.

The default is still

May 18 2016, 7:45 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

That's not expected, but I can't immediately reproduce it. Here's my local install, note that D4 appears in "Ready to Review" even though I (admin) am only a reviewer via project membership in Stonework (a project):

May 18 2016, 7:43 PM · Prioritized, Restricted Project, Owners
epriestley closed T10980: Code coverage details on Phab as Invalid.
May 18 2016, 7:38 PM · Bug Report
eadler added a comment to T10939: Support for OWNERS files.

#twitter hat off. FreeBSD hat on.

May 18 2016, 7:15 PM · Prioritized, Restricted Project, Owners
abeer added a comment to T10980: Code coverage details on Phab.

I have been unable to repro on a clean install. Its probably appropriate to close the bug. I apologize for being unclear.

May 18 2016, 7:11 PM · Bug Report
chad added a comment to T10984: arc diff to put Revision URI into clipboard.

Or maybe a better way to think about this, we'd prefer looking at absolute, programmatic solutions, not solutions that rely on users discovering and consistently applying them (they won't).

May 18 2016, 6:58 PM · Feature Request
epriestley closed T10984: arc diff to put Revision URI into clipboard as Wontfix.

I also agree with @chad in the general sense -- this use case seems pretty weird to me and is entirely unlike anything we're aware of in other installs. If email notifications are deficient in some way, we'd prefer to address that.

May 18 2016, 6:58 PM · Feature Request
chad added a comment to T10984: arc diff to put Revision URI into clipboard.

I think it's better to understand the deficiency of Phabricator's notification system than to build out something like this. It's not something I recall anyone previously needing or asking for, and seems completely undiscoverable.

May 18 2016, 6:55 PM · Feature Request
epriestley added a comment to T10984: arc diff to put Revision URI into clipboard.

I suppose you can arc set-config browser <something>, where <something> is a script which copies argv[1] to the clipboard and then exits, then run arc diff --browse.

May 18 2016, 6:55 PM · Feature Request
allixsenos created T10984: arc diff to put Revision URI into clipboard.
May 18 2016, 5:15 PM · Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 18 2016, 4:46 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T10983: Make the !accept email command configurable such that it only works if the diff was inlined.

Roughly, you should be able to:

May 18 2016, 4:12 PM · Feature Request
yelirekim closed T10983: Make the !accept email command configurable such that it only works if the diff was inlined as Resolved.

Thanks!

May 18 2016, 4:08 PM · Feature Request
epriestley added a comment to T10983: Make the !accept email command configurable such that it only works if the diff was inlined.

You can subclass MetaMTAEmailTransactionCommand, following DifferentialActionEmailCommand (which does Differential stuff) and ManiphestPriorityEmailCommand (which is a better example of implementing an individual command), to implement !hahaha-yes-i-definitely-reviewed-this-hahaha which applies !accept only for small diffs.

May 18 2016, 4:06 PM · Feature Request
yelirekim created T10983: Make the !accept email command configurable such that it only works if the diff was inlined.
May 18 2016, 3:29 PM · Feature Request
epriestley added a comment to T10917: Build Glorious High-Security Notification/Audit Infrastructure.

Here's my technical plan on this:

May 18 2016, 3:26 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

We can't easily link to an #anchor from email because the transactions that render in email are different from the transactions that render on the web. For example, T10493 is a case that specifically shows a transaction in email but not on the web. Since it doesn't exist on the web, we can't easily generate an anchor to the corresponding transaction because no web version of that transaction exists. This behavior is not unique to that transaction type. Anchor generation is also more complex than this for other reasons (for example, transaction are grouped, aggregated and reordered at display time, and these changes affect which anchors are available).

May 18 2016, 2:30 PM · Prioritized, Transactions
urzds added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

I think the "Details" links would add too much clutter in plain text email

May 18 2016, 2:24 PM · Prioritized, Transactions
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

D15942 restores the project tag transaction to the first mail about an object:

May 18 2016, 2:12 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley closed T10493: Task creation no longer lists projects added (neither the UI nor mail notifications) as Resolved by committing Restricted Diffusion Commit.
May 18 2016, 2:09 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

I guess this originally had several different parts. My thinking on the parts are:

May 18 2016, 2:07 PM · Wikimedia, Notifications, Projects (v3), Bug Report
chad added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

or that

May 18 2016, 2:05 PM · Wikimedia, Notifications, Projects (v3), Bug Report
chad added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

Better to do the header tags in the body text thing?

May 18 2016, 1:59 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a revision to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications): Unknown Object (Differential Revision).
May 18 2016, 1:59 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

I think we're mostly unsure what we want to do here.

May 18 2016, 1:51 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Yes. I think this has two general components:

May 18 2016, 1:43 PM · Prioritized, Transactions
qgil added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

Is this task open to be Prioritized? Wikimedia is discussing the possibility to fund it at https://phabricator.wikimedia.org/T135327

May 18 2016, 1:18 PM · Wikimedia, Notifications, Projects (v3), Bug Report
qgil added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Is this task open to be Prioritized? Wikimedia is discussing the possibility to fund it at https://phabricator.wikimedia.org/T135327

May 18 2016, 1:15 PM · Prioritized, Transactions
fanis created T10982: Harbormaster builds fail to allocate resource.
May 18 2016, 1:06 PM · Harbormaster, Bug Report
epriestley closed T10977: Unknown Object (User) in Conpherence as Invalid.

These tattered edges are an expected consquence of destroying objects, and the Phabricator upstream will not help you fix them. We strongly recomend disabling or archiving objects instead.

May 18 2016, 12:26 PM · Conpherence, Bug Report
maxie added a comment to T10966: Let Herald move objects between Spaces.
May 18 2016, 11:59 AM · Herald, Feature Request
kebe added a comment to T10977: Unknown Object (User) in Conpherence.

Ok. I assume you know about such issue so you prefer not to report it in future?

May 18 2016, 10:07 AM · Conpherence, Bug Report
hiddeco edited the content of Community Resources.
May 18 2016, 10:07 AM
OCram updated Q392: Did anyone tried to implement powershell / pester unit tests? from to Did anyone tried to implement powershell / pester unit tests?.
May 18 2016, 9:21 AM · Arcanist, Unit
bcooksley added a comment to T10975: Unable to edit applications in OAuth Server - edge table missing.

Thanks for the quick fix.
I realise now I was always trying to change the access policies....

May 18 2016, 6:51 AM · OAuthServer, Bug Report
• tukamon added a comment to Q391: Meaning of each databases and tables used by Phabricator.

The reason why I want that data is not relevant. The question in brief is the following the source code versioned by the repositories hosted in Phabricator are held in the data base?

May 18 2016, 6:33 AM · Restricted Project, Database