Page MenuHomePhabricator
Feed All Stories

Mar 11 2016

epriestley added a comment to T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.

D15459 is a partial fix here. Here's an "after":

Mar 11 2016, 12:40 AM · Inline Comments, Differential, Restricted Project
epriestley added a revision to T10563: Inline comments displayed on the same line are shown in creation order without regard for threading: Restricted Differential Revision.
Mar 11 2016, 12:36 AM · Inline Comments, Differential, Restricted Project
eadler moved T10562: Inline comments can become separated if replies cross update boundaries from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 11 2016, 12:29 AM · Differential, Restricted Project
eadler moved T10563: Inline comments displayed on the same line are shown in creation order without regard for threading from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 11 2016, 12:29 AM · Inline Comments, Differential, Restricted Project
20after4 added a comment to T5000: Using Differential with plain Git, without requiring Arc.

I am really attached to git workflow as well, so I wrote my own tool to integrate git and phabricator together:
https://phabricator.freedesktop.org/diffusion/GITPHAB/

With simple commands like "git phab attach" you can submit a git branch to review, creating one differential per commit. It is still "just" a wrapper tool on top of "arc diff", though.

I hope it can help others.

Mar 11 2016, 12:20 AM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T10562: Inline comments can become separated if replies cross update boundaries.

D15458 is not a retroactive fix, but new comments made after that change should no longer be separable.

Mar 11 2016, 12:09 AM · Differential, Restricted Project
epriestley added a revision to T10562: Inline comments can become separated if replies cross update boundaries: Unknown Object (Differential Revision).
Mar 11 2016, 12:08 AM · Differential, Restricted Project
avivey renamed T10564: Mail "Delivery" tab is confusing. from Mail void reasons declare wrongly marked "Self Mail" to Mail void reasons always(?) declare "Self Mail" .
Mar 11 2016, 12:05 AM · Restricted Project, Mail, Bug Report
avivey created T10564: Mail "Delivery" tab is confusing..
Mar 11 2016, 12:05 AM · Restricted Project, Mail, Bug Report
epriestley created T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.
Mar 11 2016, 12:00 AM · Inline Comments, Differential, Restricted Project

Mar 10 2016

epriestley claimed T10562: Inline comments can become separated if replies cross update boundaries.
Mar 10 2016, 11:55 PM · Differential, Restricted Project
epriestley created T10562: Inline comments can become separated if replies cross update boundaries.
Mar 10 2016, 11:52 PM · Differential, Restricted Project
greggrossmeier awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Mountain of Wealth token.
Mar 10 2016, 11:33 PM
michaeljs1990 updated the task description for T10559: Lease Working Copy Hangs on lease failure, but should fail.
Mar 10 2016, 11:14 PM · Drydock, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

That key seems like it's probably not great for the OR changeType part of the query. If you still have the table handy and playing with it doesn't take an unreasonably huge amount of time, is this better?

Mar 10 2016, 11:09 PM · Infrastructure
epriestley added a comment to T10561: Make code coverage optional by default.

getEnableCoverage() returns three values:

Mar 10 2016, 11:03 PM · Unit, Bug Report, Arcanist
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

to clarify

KEY `commitID` (`commitID`,`isDirect`,`changeType`)
Mar 10 2016, 10:35 PM · Infrastructure
joshuaspence created T10561: Make code coverage optional by default.
Mar 10 2016, 10:24 PM · Unit, Bug Report, Arcanist
eadler moved T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 10 2016, 10:13 PM · Infrastructure
eadler added a project to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Restricted Project.
Mar 10 2016, 10:13 PM · Infrastructure
eadler created T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Mar 10 2016, 10:13 PM · Infrastructure
michaeljs1990 updated the task description for T10559: Lease Working Copy Hangs on lease failure, but should fail.
Mar 10 2016, 9:44 PM · Drydock, Bug Report
michaeljs1990 updated the task description for T10559: Lease Working Copy Hangs on lease failure, but should fail.
Mar 10 2016, 9:35 PM · Drydock, Bug Report
michaeljs1990 created T10559: Lease Working Copy Hangs on lease failure, but should fail.
Mar 10 2016, 9:34 PM · Drydock, Bug Report
jcowgar added a comment to Blog Post: Development Notes (2016 Week 10).

Chad, I just updated, thats very nice! Thank you for doing that!

Mar 10 2016, 7:20 PM
Izno added a comment to T10333: Add groups to workboard columns.

The strict answer to this is "click the Edit button to go to the full edit UI". We can't make all possible reassign operations accomplishable by dragging, so this has to be the safety net for the cases where we can't guess who your likely assignees are. But I suspect we can do pretty well most of the time with some set of those rules, and make the cost of guessing wrong low.

Mar 10 2016, 7:07 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T7789: Support Git Large File Storage.
Mar 10 2016, 6:24 PM · Customer Impact, Restricted Project, Files, Diffusion
eadler moved T5953: Build a modular user account batch importer from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 10 2016, 6:20 PM · Restricted Project, Auth, Projects
eadler moved T4369: Phabricator HTTP repository hosting has fairly severe scalability limits from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 10 2016, 6:20 PM · Diffusion (v3), Restricted Project
eadler added a project to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: Restricted Project.
Mar 10 2016, 6:20 PM · Diffusion (v3), Restricted Project
chad added a comment to Blog Post: Development Notes (2016 Week 10).

The create date is now added to the "Authored By" field. I'll maybe give it a better treatment after we land Differential.

Mar 10 2016, 6:13 PM
epriestley added a comment to T7789: Support Git Large File Storage.

I'm going to figure out what the state of large PUTs

Mar 10 2016, 6:08 PM · Customer Impact, Restricted Project, Files, Diffusion
cburroughs added a comment to T9897: Unbeta Feedback on Phame.

The ordering of blogs on the right /phame is (I think after looking at it) creation date. I'm not sure that is the more useful than just lexographical(?) and feels bit implementation detail-y.

Mar 10 2016, 5:59 PM · Phame
20after4 added a comment to Blog Post: Development Notes (2016 Week 10).

@chad wrote:
There are 3 choices.

  1. Put in the subheader like on Ponder, Paste.
  2. Put the date in the sidebar with Author somehow.
  3. Make the first transaction in Timeline never hide.
Mar 10 2016, 5:06 PM
cteffetalor added a comment to T10550: Long project and milestone names in new 2-column Maniphest view render poorly.

Awesome, thanks! Updated to latest and confirmed.

Mar 10 2016, 4:51 PM · Design, PHUI, Bug Report
chad added a comment to T10556: edit policy message.

Currently I don't believe we have any client-side form validation, at least none that I can think of.

Mar 10 2016, 4:42 PM · Bug Report
chad added a comment to T10556: edit policy message.

This sounds consistent and expected to me. Either we have JavaScript validation of fields, and therefore notify you of errors immediately so they can be resolved before submission or we don't.

Mar 10 2016, 4:38 PM · Bug Report
cspeckmim added a comment to Blog Post: Development Notes (2016 Week 10).

Knowing created date helps to understand how stale a task is which is good to know in some cases

  • Certain tasks with a given status/tag need addressed in a timely manner (like customer complaints)
  • Tasks which have made it to a version but are ancient are likely no longer relevant/important
  • Possibly other case that aren't coming to mind

We have means/views/communications for determining & handling these situations already so it's purely convenience, not trying to base decisions around a single date field.

Mar 10 2016, 4:18 PM
jcowgar added a comment to Blog Post: Development Notes (2016 Week 10).

We cross posted... My initial feature request was not due to this change. It has always been difficult to come by the create date in Phabricator for us. With this change and prior to. With this change, however, it may open an opportunity to put create date on the right column.

Mar 10 2016, 3:48 PM
jcowgar added a comment to Blog Post: Development Notes (2016 Week 10).

Oh! And I'm not saying that this change caused this issue. It has existed for quite some time, we just now are getting around to posting here for discussion.

Mar 10 2016, 3:46 PM
epriestley added a comment to Blog Post: Development Notes (2016 Week 10).

Sorry, I'm still not understanding what specific change you're concerned about. Isn't the information in the same place -- with the same behavior -- as it was before?

Mar 10 2016, 3:46 PM
jcowgar added a comment to Blog Post: Development Notes (2016 Week 10).

Here are two screen shots

Mar 10 2016, 3:43 PM
epriestley added a comment to Blog Post: Development Notes (2016 Week 10).

I miss the create date being easily visible.

Mar 10 2016, 3:38 PM
jcowgar added a comment to Blog Post: Development Notes (2016 Week 10).

I miss the create date being easily visible. I opened a feature request for this, but was directed here for commenting. The question posted there was "What do I do differently knowing the create date?"

Mar 10 2016, 3:33 PM
chad added a comment to Blog Post: Development Notes (2016 Week 10).

We've talked internally about several other solutions, but we haven't settled on anything specific yet. It's helpful to know in general how often and what people get from this information. I can find it if I need it, but I only look for it maybe 1-2 times a month here, and only ever for curiosity. I don't tend to treat tasks differently because of the date.

Mar 10 2016, 3:28 PM
chad closed T10558: It's not easy to find the create date of a task on the task detail screen. as Resolved.

Actually, just going to close this out in favor of the discussion on https://secure.phabricator.com/phame/post/view/770/development_notes_2016_week_10/. Please add your thoughts there.

Mar 10 2016, 3:26 PM · Maniphest, Feature Request
chad added a comment to T10558: It's not easy to find the create date of a task on the task detail screen..

What do you do differently knowing the date a task was opened? That is, what problem does it expressly solve?

Mar 10 2016, 3:17 PM · Maniphest, Feature Request
jcowgar added a comment to T10558: It's not easy to find the create date of a task on the task detail screen..

I wonder if the create date of the task should be on the right column along with items such as Subscribers, Authored By, etc...

Mar 10 2016, 3:04 PM · Maniphest, Feature Request
jcowgar created T10558: It's not easy to find the create date of a task on the task detail screen..
Mar 10 2016, 3:04 PM · Maniphest, Feature Request
• clark.woo.12 added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

How can i use DiffusionBrowseController.php to brow my files with non-latin character names correctly?

Mar 10 2016, 3:01 PM · Restricted Project, Auth, Conduit
epriestley updated subscribers of T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Mar 10 2016, 2:54 PM · Restricted Project, Auth, Conduit
epriestley merged task T10557: callConduitWithDiffusionRequest failed with non-latin characters parameters into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Mar 10 2016, 2:54 PM · Bug Report
• clark.woo.12 updated the task description for T10557: callConduitWithDiffusionRequest failed with non-latin characters parameters.
Mar 10 2016, 2:54 PM · Bug Report
• clark.woo.12 created T10557: callConduitWithDiffusionRequest failed with non-latin characters parameters.
Mar 10 2016, 2:50 PM · Bug Report
featherless closed T10555: Support for private build systems and public phabricators as Wontfix.

Marking wontfix in the sense that I'll take on this work rather than upstream.

Mar 10 2016, 2:25 PM · Harbormaster, Feature Request
epriestley added a comment to T10555: Support for private build systems and public phabricators.

I added you to Community so you should have access now.

Mar 10 2016, 2:20 PM · Harbormaster, Feature Request
kornrunner removed a member for Space Test Users: kornrunner.
Mar 10 2016, 2:20 PM
epriestley added a member for Community: featherless.
Mar 10 2016, 2:20 PM
featherless added a comment to T10555: Support for private build systems and public phabricators.

Ah yes I forgot to mention that I have set up a Herald rule that kicks off the build plan.

Mar 10 2016, 2:19 PM · Harbormaster, Feature Request
epriestley added a comment to T10556: edit policy message.

To clarify, you're expecting the error message to disappear immediately, before you submit the form?

Mar 10 2016, 2:09 PM · Bug Report
epriestley added a comment to T10555: Support for private build systems and public phabricators.

You can sort of do this like this:

Mar 10 2016, 2:08 PM · Harbormaster, Feature Request
• montegava created T10556: edit policy message.
Mar 10 2016, 2:03 PM · Bug Report
• claudiomelis closed Q293: How to reorder Revision Update History in Differential as resolved.
Mar 10 2016, 2:03 PM · Differential
featherless created T10555: Support for private build systems and public phabricators.
Mar 10 2016, 1:48 PM · Harbormaster, Feature Request
epriestley closed T10554: 把demo稿快画出来 as Spite.
Mar 10 2016, 1:37 PM · Feature Request
epriestley added a comment to T7789: Support Git Large File Storage.

This may make sense to at least lightly entangle with T4752, which overlaps in some ways.

Mar 10 2016, 1:37 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

To do an integrity check, it looks like we have to compute the Git hash ourselves.

Mar 10 2016, 1:31 PM · Customer Impact, Restricted Project, Files, Diffusion
• claudiomelis added a project to Q336: Configuring lint when called as workflow procedure of arc diff: Lint.
Mar 10 2016, 1:31 PM · Arcanist, Lint
• claudiomelis updated Q336: Configuring lint when called as workflow procedure of arc diff from to Configuring lint when called as workflow procedure of arc diff.
Mar 10 2016, 1:31 PM · Arcanist, Lint
epriestley added a comment to T7789: Support Git Large File Storage.

As a general preface, this stuff makes me a little uneasy about LFS in its current state:

Mar 10 2016, 1:09 PM · Customer Impact, Restricted Project, Files, Diffusion
• fcontrer moved T9642: Unable to download images on Android from Icebox to Backlog on the Android board.
Mar 10 2016, 12:47 PM · Android, Files
• fcontrer moved T9642: Unable to download images on Android from Backlog to Icebox on the Android board.
Mar 10 2016, 12:47 PM · Android, Files
• yangqi added a comment to T10554: 把demo稿快画出来.

初稿

Mar 10 2016, 12:06 PM · Feature Request
• yangqi created T10554: 把demo稿快画出来.
Mar 10 2016, 12:06 PM · Feature Request
Info-Screen added a watcher for Community: Info-Screen.
Mar 10 2016, 10:54 AM
Slumber86 added a comment to Q334: Git hosting error on CentOS: sudo: git-upload-pack: command not found (Answer 342).

Resolved, I should edit my /etc/sudoers and add: path to ´Defaults env_keep´ and /usr/local/git/bin/ to secure_path

Mar 10 2016, 10:49 AM
Slumber86 added a comment to Q334: Git hosting error on CentOS: sudo: git-upload-pack: command not found (Answer 342).
Mar 10 2016, 10:49 AM
eadler closed T10553: Test as Invalid.

IMPORTANT: This is not a demo or test install. Please don't make a mess. You can launch a demo install on Phacility if you want to poke around and try things out.

Mar 10 2016, 10:40 AM · Feature Request
Slumber86 added a comment to Q334: Git hosting error on CentOS: sudo: git-upload-pack: command not found (Answer 342).

i'm sure that is in the path.

Mar 10 2016, 10:18 AM
RajJha created T10553: Test.
Mar 10 2016, 7:12 AM · Feature Request
chad closed T10552: UI design as Invalid.
Mar 10 2016, 5:47 AM · Feature Request
• Tung created T10552: UI design.
Mar 10 2016, 5:43 AM · Feature Request
chad added a comment to T10550: Long project and milestone names in new 2-column Maniphest view render poorly.

Thanks for the report! Resolved at HEAD.

Mar 10 2016, 3:42 AM · Design, PHUI, Bug Report
chad closed T10550: Long project and milestone names in new 2-column Maniphest view render poorly as Resolved by committing Restricted Diffusion Commit.
Mar 10 2016, 2:51 AM · Design, PHUI, Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

D15454 changes the wording to:

Mar 10 2016, 2:49 AM · Wikimedia, Notifications, Projects (v3), Bug Report
chad added a revision to T10550: Long project and milestone names in new 2-column Maniphest view render poorly: Unknown Object (Differential Revision).
Mar 10 2016, 2:49 AM · Design, PHUI, Bug Report
epriestley added a revision to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications): Unknown Object (Differential Revision).
Mar 10 2016, 2:48 AM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

We should probably change the text on "placed up for grabs" to "unassigned from X". I don't think we use that term anywhere else nowadays, either.

Mar 10 2016, 2:44 AM · Wikimedia, Notifications, Projects (v3), Bug Report
chad claimed T10550: Long project and milestone names in new 2-column Maniphest view render poorly.
Mar 10 2016, 2:22 AM · Design, PHUI, Bug Report
robertkraig added a comment to P1959 More problems..

nothing added to commit but untracked files present (use "git add" to track)
root@phabricator:/home/phabricator/phabricator# git log -1
commit 929b4ccb5cd29ea932a081ab5d69bf5e06a3ffd3
Author: Chad Little <chad@chadsdomain.com>
Date: Fri Feb 19 14:45:05 2016 -0800

Mar 10 2016, 2:08 AM
robertkraig created P1959 More problems..
Mar 10 2016, 2:07 AM
robertkraig created P1958 Problems.
Mar 10 2016, 2:03 AM
epriestley created P1957 AddANoteDifferentialField.php.
Mar 10 2016, 1:48 AM
chad closed T10551: Limit who can/cannot see phrequent notes/audit info to specific tag/project of people on a per-task/ticket basis. as Invalid.

See Prototype, we don't provide bug or feature request for prototypes unfortunately.

Mar 10 2016, 1:24 AM · Phrequent, Feature Request
robertkraig awarded T8666: When a task is resolved with "Resolves T123", Phrequent should stop tracking time a Like token.
Mar 10 2016, 1:19 AM · Maniphest, Phrequent
robertkraig created T10551: Limit who can/cannot see phrequent notes/audit info to specific tag/project of people on a per-task/ticket basis..
Mar 10 2016, 1:17 AM · Phrequent, Feature Request
cteffetalor added a comment to T10550: Long project and milestone names in new 2-column Maniphest view render poorly.

Yeah, cut-off would also be acceptable (although I like wrapping slightly better). It might motivate users to pick shorter names but there's not even a lot of space for reasonable names when combined with milestones/subprojects like:

Mar 10 2016, 12:41 AM · Design, PHUI, Bug Report
chad added a comment to T10550: Long project and milestone names in new 2-column Maniphest view render poorly.

Tags over 320px are likely cut off in all mobile devices anywhere you use them, as well. There aren't too many options if you use really really long names. GitHub cuts it off in like, 20 characters.

Mar 10 2016, 12:25 AM · Design, PHUI, Bug Report
chad added a comment to T10550: Long project and milestone names in new 2-column Maniphest view render poorly.

We might not use tags over there, not clear yet.

Mar 10 2016, 12:21 AM · Design, PHUI, Bug Report
cteffetalor created T10550: Long project and milestone names in new 2-column Maniphest view render poorly.
Mar 10 2016, 12:09 AM · Design, PHUI, Bug Report