- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 21 2020
May 21 2020
May 20 2020
May 20 2020
Drop old "differential_commit" table
epriestley committed rP6d0dbeb77f77: Use the changeset parse cache to cache suggestion changesets (authored by epriestley).
Use the changeset parse cache to cache suggestion changesets
epriestley committed rP5d0ae283a9ab: Put a readthrough cache in front of inline context construction (authored by epriestley).
Put a readthrough cache in front of inline context construction
epriestley committed rPd2d7e7f5ff1b: Clean up Diffusion behaviors for inline edit suggestions (authored by epriestley).
Clean up Diffusion behaviors for inline edit suggestions
epriestley committed rP10f241352dce: Render inline comment suggestions as real diffs (authored by epriestley).
Render inline comment suggestions as real diffs
epriestley committed rP846562158aae: Roughly support inline comment suggestions (authored by epriestley).
Roughly support inline comment suggestions
epriestley committed rP00430fdbe117: Make server components of inline comment content handling state-oriented (authored by epriestley).
Make server components of inline comment content handling state-oriented
epriestley committed rP4b2a447003be: Allow "has draft inlines?" queries to overheat (authored by epriestley).
Allow "has draft inlines?" queries to overheat
epriestley committed rP87bc30526b7a: Make inline content "state-oriented", not "string-oriented" (authored by epriestley).
Make inline content "state-oriented", not "string-oriented"
epriestley requested review of D21280: Use the changeset parse cache to cache suggestion changesets.
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
I made a change to drop unchanged context from suggestion views, but I don't particularly like it. It changed this:
epriestley requested review of D21279: Put a readthrough cache in front of inline context construction.
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
- Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.
- Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
The inline comment context menu does not apply the correct cursor ("pointer").
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
I still have a lot of inline style attributes to clean up and then I'm sure there will be a long tail of weird edge cases, but this is getting pretty close:
May 19 2020
May 19 2020
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
- This isn't necessarily terribly useful in practice, but a UI hint about whether or not we've actually saved a draft would make debugging slightly easier.
epriestley committed rP9d5b8bd14a97: Remove PHPMailer code which generates bogus "Message-ID" email headers (authored by epriestley).
Remove PHPMailer code which generates bogus "Message-ID" email headers
epriestley requested review of D21272: Remove PHPMailer code which generates bogus "Message-ID" email headers.
epriestley committed rP1aa0569b6086: (stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception"… (authored by epriestley).
(stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception"…
epriestley committed rP4257b26abc61: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the… (authored by epriestley).
Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the…
epriestley committed rP400c555666c5: (stable) Update out-of-date API calls when rendering diffs inline in email (authored by epriestley).
(stable) Update out-of-date API calls when rendering diffs inline in email
epriestley committed rP43a8d8763df3: Update out-of-date API calls when rendering diffs inline in email (authored by epriestley).
Update out-of-date API calls when rendering diffs inline in email
epriestley requested review of D21270: Update out-of-date API calls when rendering diffs inline in email.
Remaining work here is:
epriestley committed rP4fd7c0f7b3ca: (stable) Fix an issue where builds with no initiator failed to render in build… (authored by epriestley).
(stable) Fix an issue where builds with no initiator failed to render in build…
epriestley committed rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans (authored by epriestley).
Fix an issue where builds with no initiator failed to render in build plans
epriestley committed rP8dec499bcf0a: (stable) Fix "r" and "R" both replying with quote on inline comments (authored by epriestley).
(stable) Fix "r" and "R" both replying with quote on inline comments
epriestley committed rP770a5c8412d1: Fix "r" and "R" both replying with quote on inline comments (authored by epriestley).
Fix "r" and "R" both replying with quote on inline comments
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
- The inline comment context menu does not apply the correct cursor ("pointer").
epriestley updated the task description for T13539: Obscure end-of-file changes may choke the changeset highlighter.
epriestley committed rP1157f2782277: (stable) Fix an unusual issue with intradiff highlighting of files with… (authored by epriestley).
(stable) Fix an unusual issue with intradiff highlighting of files with…
epriestley committed rP6cf017d68003: Fix an unusual issue with intradiff highlighting of files with uncommon end-of… (authored by epriestley).
Fix an unusual issue with intradiff highlighting of files with uncommon end-of…
epriestley triaged T13539: Obscure end-of-file changes may choke the changeset highlighter as Low priority.
These particular issues blame to D21027, which began extracting null in all cases where a field has no value for a given commit. This is not entirely faithful, as it can not distinguish between "field absent" and "field present, but with an empty value". At least for author, these are distinct states that can be independently constructed using git hash-object:
From PHI1739, --allow-empty-message supports constructing these commits more easily (via a normal git commit rather than git hash-object).
epriestley committed rP40aab725e825: (stable) Survive importing Git commits with no commit message and/or no author (authored by epriestley).
(stable) Survive importing Git commits with no commit message and/or no author
epriestley committed rP0c51885cf7b2: Survive importing Git commits with no commit message and/or no author (authored by epriestley).
Survive importing Git commits with no commit message and/or no author
epriestley requested review of D21266: Survive importing Git commits with no commit message and/or no author.
Second issue:
First issue:
Alas, you can't actually push the perfect commit:
epriestley triaged T13538: Git commits with no commit message fail to import/parse as Normal priority.
May 18 2020
May 18 2020
epriestley committed rPf86d822a37ea: Update MySQL schema inspection code for deprecation of integer display widths (authored by epriestley).
Update MySQL schema inspection code for deprecation of integer display widths
epriestley updated the task description for T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".
epriestley added a comment to T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".
The actual query we use to inspect table information is:
See T13537 for a subtle issue where digestWithNamedKey() keys were cached in APCu on the web tier. Importing instance data may require restarting the web tier until the import process can either dump these caches or version them (versioning may be easier).
epriestley added a comment to T13537: Support local port forwarding through Phacility cluster bastion hosts.
So I'm going to turn web off and on again and see if that fixes things; my expectation is that it will.
epriestley added a comment to T13537: Support local port forwarding through Phacility cluster bastion hosts.
The specific issue I'm trying to debug is fairly bizarre.
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
epriestley triaged T13537: Support local port forwarding through Phacility cluster bastion hosts as Low priority.