Page MenuHomePhabricator
Feed All Stories

Aug 30 2019

epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Aug 30 2019, 8:21 PM · Phacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Provisioning was once close-ish to automated. Is this close enough to automate?

Aug 30 2019, 5:34 PM · Phacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

I think this leaves us with:

Aug 30 2019, 5:19 PM · Phacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Adjacent is the older instances.queryinstances API method. This is still used by service synchronization.

Aug 30 2019, 5:09 PM · Phacility, Infrastructure
epriestley triaged T13399: Remove "instances.queryinstances" Conduit API method as Wishlist priority.
Aug 30 2019, 5:08 PM · Phacility
epriestley committed rP533a5535b6f0: Remove the "grant authority" mechanism from users (authored by epriestley).
Remove the "grant authority" mechanism from users
Aug 30 2019, 4:26 PM
epriestley closed D20754: Remove the "grant authority" mechanism from users.
Aug 30 2019, 4:26 PM
epriestley requested review of D20754: Remove the "grant authority" mechanism from users.
Aug 30 2019, 4:17 PM
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: D20754: Remove the "grant authority" mechanism from users.
Aug 30 2019, 4:15 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Aug 30 2019, 4:12 PM · Phacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

It is also used to cache InstancesManageCapability::CAPABILITY but this can easily just be cached in the request cache instead.

Aug 30 2019, 3:50 PM · Phacility, Infrastructure
epriestley added a comment to T13396: Support downloads of 2GB+ files with HTTPSFuture.

The operation in PHI1329 (against a ~8GB export) went through cleanly. Remaining work here is:

Aug 30 2019, 3:42 PM · Infrastructure, libphutil
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: Unknown Object (Differential Revision).
Aug 30 2019, 2:12 AM · Infrastructure, libphutil
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

The "Instance" almanac service type can be destroyed.

Aug 30 2019, 1:51 AM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Aug 30 2019, 1:50 AM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Aug 30 2019, 12:29 AM · Phacility, Infrastructure

Aug 29 2019

epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Can we get rid of the instance-specific services completely now, after changes connected to T11413?

Aug 29 2019, 10:50 PM · Phacility, Infrastructure
epriestley committed rP3c26e384872a: Provide a simple read-only maintenance mode for repositories (authored by epriestley).
Provide a simple read-only maintenance mode for repositories
Aug 29 2019, 10:23 PM
epriestley closed D20748: Provide a simple read-only maintenance mode for repositories.
Aug 29 2019, 10:23 PM
epriestley triaged T13398: Merge "ExecFuture" and "PhutilExecPassthru" and support selective passthru of individual pipes as Low priority.
Aug 29 2019, 10:07 PM · Infrastructure, libphutil
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Mostly-promising answers on much of the rest of this:

Aug 29 2019, 10:05 PM · Phacility, Infrastructure
epriestley added a revision to T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes: Unknown Object (Differential Revision).
Aug 29 2019, 9:14 PM · Infrastructure, Arcanist
epriestley added a comment to T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes.

For posterity, bleugh:

Aug 29 2019, 8:41 PM · Infrastructure, Arcanist
epriestley added a comment to T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes.

I have a patch for this, but I'm not thrilled about the retry model. Maybe better would be for the caller retry the actual upload operation (which will automatically resume) and bail out while retaining the temporary file. Even if we retry on 504, we lose a lot of progress if there's a service interruption for longer than we're willing to sit in a retry loop.

Aug 29 2019, 8:33 PM · Infrastructure, Arcanist
epriestley requested review of D20748: Provide a simple read-only maintenance mode for repositories.
Aug 29 2019, 8:07 PM
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: D20748: Provide a simple read-only maintenance mode for repositories.
Aug 29 2019, 8:05 PM · Phacility, Infrastructure
epriestley triaged T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes as Low priority.
Aug 29 2019, 8:02 PM · Infrastructure, Arcanist
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

I'm hoping this is a reasonable excuse to find a way forward [on >2GB downloads] here.

Aug 29 2019, 7:16 PM · Phacility, Infrastructure
epriestley committed rPHU379fd58429ff: (stable) Add a rough "ProgressSink" for improved progress reporting flexibility (authored by epriestley).
(stable) Add a rough "ProgressSink" for improved progress reporting flexibility
Aug 29 2019, 7:08 PM
epriestley committed rPHUdb94ec322abf: (stable) Allow HTTPSFuture to stream very large files directly to disk (authored by epriestley).
(stable) Allow HTTPSFuture to stream very large files directly to disk
Aug 29 2019, 7:08 PM
epriestley committed rPHU71e8d7a4cf8e: Add a rough "ProgressSink" for improved progress reporting flexibility (authored by epriestley).
Add a rough "ProgressSink" for improved progress reporting flexibility
Aug 29 2019, 7:07 PM
epriestley closed D20746: Add a rough "ProgressSink" for improved progress reporting flexibility.
Aug 29 2019, 7:07 PM
epriestley committed rPHU45c553b5c1d5: Allow HTTPSFuture to stream very large files directly to disk (authored by epriestley).
Allow HTTPSFuture to stream very large files directly to disk
Aug 29 2019, 7:06 PM
epriestley closed D20745: Allow HTTPSFuture to stream very large files directly to disk.
Aug 29 2019, 7:06 PM
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: Unknown Object (Differential Revision).
Aug 29 2019, 7:03 PM · Infrastructure, libphutil
epriestley requested review of D20746: Add a rough "ProgressSink" for improved progress reporting flexibility.
Aug 29 2019, 7:01 PM
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: D20746: Add a rough "ProgressSink" for improved progress reporting flexibility.
Aug 29 2019, 7:00 PM · Infrastructure, libphutil
pasik added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

Also an example how "per-push notification" is implemented in Github events/webhooks:

Aug 29 2019, 6:18 PM · Restricted Project, Harbormaster
pasik added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

I actually found my way here from discourse where the need for this was discussed:

Aug 29 2019, 6:04 PM · Restricted Project, Harbormaster
epriestley requested review of D20745: Allow HTTPSFuture to stream very large files directly to disk.
Aug 29 2019, 5:38 PM
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: D20745: Allow HTTPSFuture to stream very large files directly to disk.
Aug 29 2019, 5:38 PM · Infrastructure, libphutil
epriestley added a comment to T13396: Support downloads of 2GB+ files with HTTPSFuture.

This is something of an aside, but it would be nice to formalize PhutilConsoleProgressBar into a generic progress sink. A lot of bin/storage dump-related stuff could use this and bin/host download could obviously use it, and we likely have some use cases for reporting progress to the web via the API, but PhutilConsoleProgressBar lacks an indirection layer to really make this work cleanly.

Aug 29 2019, 5:19 PM · Infrastructure, libphutil
epriestley added a comment to T13396: Support downloads of 2GB+ files with HTTPSFuture.

My tentative plan is to add methods for sending the output to disk to HTTPSFuture, then go down the new parser pathway only if we're writing to disk. This should limit the amount of surface area exposed on the new parser.

Aug 29 2019, 4:33 PM · Infrastructure, libphutil
epriestley closed T12907: Unable to download large files through alternative file domain as Resolved.

This task covers a lot of ground and many of the issues have been resolved. There are two remaining issues which are more narrowly covered by these followups:

Aug 29 2019, 3:54 PM · Bug Report
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Is the 2GB HTTP stuff in T12907 realistic to fix?

Aug 29 2019, 3:52 PM · Phacility, Infrastructure
epriestley claimed T13396: Support downloads of 2GB+ files with HTTPSFuture.
Aug 29 2019, 3:51 PM · Infrastructure, libphutil
epriestley created T13396: Support downloads of 2GB+ files with HTTPSFuture.
Aug 29 2019, 3:51 PM · Infrastructure, libphutil
epriestley triaged T13395: Strip libphutil for parts as Low priority.
Aug 29 2019, 3:41 PM · libphutil
epriestley updated the task description for T13394: Evaluate Okta OAuth.
Aug 29 2019, 3:27 PM · Auth
epriestley updated the task description for T13394: Evaluate Okta OAuth.
Aug 29 2019, 3:27 PM · Auth
epriestley triaged T13394: Evaluate Okta OAuth as Low priority.
Aug 29 2019, 3:26 PM · Auth
epriestley added a comment to T10127: Migrating repository between storage hosts in a cluster.

Not necessarily applicable in the general case, but see also T13393.

Aug 29 2019, 3:09 PM · Clusters, Feature Request
epriestley triaged T13393: Improve repository shard migration pathway in the shared cluster as Normal priority.
Aug 29 2019, 3:04 PM · Phacility, Infrastructure
epriestley triaged T13392: Current implementations of "X-Forwarded-For" may take the wrong element as Normal priority.
Aug 29 2019, 2:42 PM · Infrastructure
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 29 2019, 3:19 AM · Phortune, Phacility

Aug 28 2019

epriestley committed rPHU5060bdf9726b: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes (authored by epriestley).
Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes
Aug 28 2019, 6:56 PM
epriestley closed D20744: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.
Aug 28 2019, 6:56 PM
epriestley closed T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock as Resolved by committing rPHU5060bdf9726b: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.
Aug 28 2019, 6:56 PM · Infrastructure, libphutil
epriestley requested review of D20744: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.
Aug 28 2019, 6:55 PM
epriestley added a revision to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock: D20744: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.
Aug 28 2019, 6:55 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this?

Aug 28 2019, 6:51 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

According to curl/symbols-in-versions (this is a text file in the repository):

Aug 28 2019, 6:46 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this? Only by hard-coding known-broken hostnames, I think?), and forcing it to use HTTP/1.1 could break those cases, so maybe I'll go spelunking here. I also can't immediately find a date of introduction for CURL_HTTP_VERSION_1_1 from the documentation.

Aug 28 2019, 6:44 PM · Infrastructure, libphutil
epriestley triaged T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock as Normal priority.
Aug 28 2019, 6:39 PM · Infrastructure, libphutil
epriestley added a comment to T13376: Write about "add more logging / monitoring / tests".

Another variation of this is "add more documentation", although I think the pattern around this one is more rarely a sort of "problem domain / solution domain mismatch" sort of issue and more often a "human communication" issue, usually with one of these two templates:

Aug 28 2019, 3:39 PM · Guides
epriestley committed rPc6642213d57f: Straighten out replication/cache behavior in "bin/storage dump" (authored by epriestley).
Straighten out replication/cache behavior in "bin/storage dump"
Aug 28 2019, 3:25 PM
epriestley closed D20743: Straighten out replication/cache behavior in "bin/storage dump".
Aug 28 2019, 3:25 PM
epriestley closed T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE as Resolved by committing rPc6642213d57f: Straighten out replication/cache behavior in "bin/storage dump".
Aug 28 2019, 3:25 PM · Infrastructure
epriestley requested review of D20743: Straighten out replication/cache behavior in "bin/storage dump".
Aug 28 2019, 3:21 PM
epriestley added a revision to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE: D20743: Straighten out replication/cache behavior in "bin/storage dump".
Aug 28 2019, 3:19 PM · Infrastructure
epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

An adjacent issue is that PhabricatorMarkupCache is not currently marked as having cache persistence

Aug 28 2019, 2:06 PM · Infrastructure
epriestley committed rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"… (authored by epriestley).
Fix incorrect construction of subtype map when validating "subtype"…
Aug 28 2019, 1:57 PM
epriestley closed D20741: Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects.
Aug 28 2019, 1:57 PM
epriestley closed T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation as Resolved by committing rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"….
Aug 28 2019, 1:57 PM · EditEngine

Aug 27 2019

epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

loading a dump with missing data into a replica and then starting replication really causes issues

Aug 27 2019, 11:42 PM · Infrastructure
epriestley committed rP7198bd7db784: When "utf8mb4" is available, use it as the default client charset when invoking… (authored by epriestley).
When "utf8mb4" is available, use it as the default client charset when invoking…
Aug 27 2019, 11:37 PM
epriestley closed T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4 as Resolved by committing rP7198bd7db784: When "utf8mb4" is available, use it as the default client charset when invoking….
Aug 27 2019, 11:36 PM · Restricted Project, Infrastructure
epriestley closed D20742: When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands.
Aug 27 2019, 11:36 PM
epriestley edited the content of Changelog.
Aug 27 2019, 11:34 PM
epriestley created an object: 2019 Week 34 (Late August).
Aug 27 2019, 11:33 PM
epriestley committed rP3e02f3c89c41: (stable) Promote 2019 Week 34 (authored by epriestley).
(stable) Promote 2019 Week 34
Aug 27 2019, 11:32 PM
epriestley requested review of D20742: When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands.
Aug 27 2019, 10:35 PM
epriestley added a revision to T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4: D20742: When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands.
Aug 27 2019, 10:33 PM · Restricted Project, Infrastructure
epriestley triaged T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4 as Normal priority.
Aug 27 2019, 10:25 PM · Restricted Project, Infrastructure
epriestley set the color for 🐳 to Red.
Aug 27 2019, 9:41 PM
epriestley requested review of D20741: Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects.
Aug 27 2019, 2:58 PM
epriestley added a revision to T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation: D20741: Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects.
Aug 27 2019, 2:57 PM · EditEngine
epriestley claimed T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation.
Aug 27 2019, 2:54 PM · EditEngine
epriestley triaged T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation as Normal priority.
Aug 27 2019, 2:54 PM · EditEngine
epriestley closed T13388: Non-ideal view in mobile when using browser's "desktop" mode as Wontfix.

Use case from the thread is far off the beaten path ("The ideal version of the site on devices is a tiny version of the site on desktop"), so I'm not planning to put the time into investigating this unless substantially more interest emerges. I doubt the root issue is strictly a bug in Phabricator.

Aug 27 2019, 2:50 PM
epriestley updated the task description for T13134: Give Conduit API tokens PHIDs, transactions, and other modern capabilities.
Aug 27 2019, 3:41 AM · Conduit
epriestley added a comment to T13388: Non-ideal view in mobile when using browser's "desktop" mode.

I'd like to understand why this option is useful before making any changes here (that is, why wasn't the user happy with the site as it appeared by default on their device)?

Aug 27 2019, 3:36 AM
avivey added a comment to T13388: Non-ideal view in mobile when using browser's "desktop" mode.

I'm guessing it's a media-query being calculated on some metric that isn't being scaled by the browser - "inches" maybe?

Aug 27 2019, 1:34 AM
avivey created T13388: Non-ideal view in mobile when using browser's "desktop" mode.
Aug 27 2019, 1:31 AM

Aug 26 2019

epriestley committed rP97a4a59cf2c7: Give the Phortune external portal an order view (authored by epriestley).
Give the Phortune external portal an order view
Aug 26 2019, 2:49 PM
epriestley closed D20740: Give the Phortune external portal an order view.
Aug 26 2019, 2:49 PM
epriestley committed rPa0a38797127f: In Phortune, send order email to account external addresses (authored by epriestley).
In Phortune, send order email to account external addresses
Aug 26 2019, 2:48 PM
epriestley closed D20739: In Phortune, send order email to account external addresses.
Aug 26 2019, 2:48 PM
epriestley closed T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Aug 26 2019, 2:48 PM · Phacility
epriestley closed T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, a subtask of T13366: Update Phortune to work better with "enterprise" billing/accounts departments, as Resolved.
Aug 26 2019, 2:48 PM · Phortune, Phacility