Page MenuHomePhabricator

Straighten out replication/cache behavior in "bin/storage dump"
ClosedPublic

Authored by epriestley on Aug 28 2019, 3:19 PM.

Details

Summary

Fixes T13336.

  • Prevent --no-indexes from being combined with --for-replica, since combining these options can only lead to heartbreak.
  • In --for-replica mode, dump caches too. See discussion in T13336. It is probably "safe" to not dump these today, but fragile and not correct.
  • Mark the "MarkupCache" table as having "Cache" persistence, not "Data" persistence (no need to back it up, since it can be fully regenerated from other datasources).
Test Plan

Ran bin/storage dump with various combinations of flags.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 28 2019, 3:19 PM
epriestley requested review of this revision.Aug 28 2019, 3:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 3:25 PM
This revision was automatically updated to reflect the committed changes.