Page MenuHomePhabricator

Allow HTTPSFuture to stream very large files directly to disk

Authored by epriestley on Aug 29 2019, 5:38 PM.



Ref T13396. Support a mode which directs "HTTPSFuture" to stream response bodies to disk. In this mode, use the new streaming parser to break past the 2GB limit.

Test Plan
  • Ran various HTTP commands to attempt to establish that this does not change any existing behavior.
  • In the next change (internal), modified bin/host download to use this pathway and downloaded large files.

Diff Detail

rPHU libphutil
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 29 2019, 5:38 PM
epriestley requested review of this revision.Aug 29 2019, 5:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 7:06 PM
This revision was automatically updated to reflect the committed changes.