Page MenuHomePhabricator
Differential D20742

When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands
ClosedPublic
Actions

Authored by epriestley on Aug 27 2019, 10:33 PM.

Details

Reviewers
None
Maniphest Tasks
T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4
Commits
rP7198bd7db784: When "utf8mb4" is available, use it as the default client charset when invoking…
Summary

Fixes T13390. We have some old code which doesn't dynamically select between "utf8mb4" and "utf8". This can lead to dumping utf8mb4 data over a utf8 connection in bin/storage dump, which possibly corrupts some emoji/whales.

Instead, prefer "utf8mb4" if it's available.

Test Plan

Ran bin/storage dump and bin/storage shell, saw sub-commands select utf8mb4 as the client charset.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 27 2019, 10:33 PM
epriestley requested review of this revision.Aug 27 2019, 10:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2019, 11:36 PM
Closed by commit rP7198bd7db784: When "utf8mb4" is available, use it as the default client charset when invoking… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7198bd7db784: When "utf8mb4" is available, use it as the default client charset when invoking….

Revision Contents
Changeset List

Diff 49456

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php

Loading...
Phabricator · Built by Phacility