Page MenuHomePhabricator
Differential D20748

Provide a simple read-only maintenance mode for repositories
ClosedPublic
Actions

Authored by epriestley on Aug 29 2019, 8:05 PM.
Tags
None
Referenced Files
F15430430: D20748.id49474.diff
Mon, Mar 24, 7:38 AM
F15418142: D20748.diff
Thu, Mar 20, 9:07 PM
F15417448: D20748.id49474.diff
Thu, Mar 20, 5:01 PM
F15387133: D20748.id.diff
Sat, Mar 15, 1:53 AM
F15386152: D20748.diff
Sat, Mar 15, 12:07 AM
Unknown Object (File)
Mon, Mar 3, 9:38 AM
Unknown Object (File)
Feb 20 2025, 4:52 AM
Unknown Object (File)
Feb 16 2025, 10:06 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13393: Improve repository shard migration pathway in the shared cluster
Commits
rP3c26e384872a: Provide a simple read-only maintenance mode for repositories
Summary

Ref T13393. While doing a shard migration in the Phacility cluster, we'd like to stop writes to the migrating repository. It's safe to continue serving reads.

Add a simple maintenance mode for making repositories completely read-only during maintenance.

Test Plan

Put a repository into read-only mode, tried to write via HTTP + SSH. Viewed web UI. Took it back out of maintenance mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 29 2019, 8:05 PM
Harbormaster completed remote builds in B23328: Diff 49470.Aug 29 2019, 8:07 PM
epriestley requested review of this revision.Aug 29 2019, 8:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 10:23 PM
Closed by commit rP3c26e384872a: Provide a simple read-only maintenance mode for repositories (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP3c26e384872a: Provide a simple read-only maintenance mode for repositories.

Revision Contents
Changeset List

Diff 49474

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/xaction/PhabricatorRepositoryMaintenanceTransaction.php

Loading...
Phabricator · Built by Phacility