Page MenuHomePhabricator

Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes
ClosedPublic

Authored by epriestley on Aug 28 2019, 6:55 PM.

Details

Summary

Fixes T13391. See that task for more detailed discussion.

Recent versions of cURL default to HTTP/2 on some connections but do not support HTTP/2 proxies, so connecting to certain correctly configured servers can leave you dead in the water.

Force connections down to HTTP/1.1 for now.

Test Plan
  • Created this revision to establish I didn't break anything catastrophically.
  • See task for evidence this actually works.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 28 2019, 6:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 6:55 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.