Differential D20744

2 support stabilizes
ClosedPublic
Actions

Authored by epriestley on Aug 28 2019, 6:55 PM.

Details

Reviewers: None
Maniphest Tasks: T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock
Commits: rPHU5060bdf9726b: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes

Summary

Fixes T13391. See that task for more detailed discussion.

Recent versions of cURL default to HTTP/2 on some connections but do not support HTTP/2 proxies, so connecting to certain correctly configured servers can leave you dead in the water.

Force connections down to HTTP/1.1 for now.

Test Plan

Created this revision to establish I didn't break anything catastrophically.
See task for evidence this actually works.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 28 2019, 6:55 PM

Harbormaster completed remote builds in B23319: Diff 49460.Aug 28 2019, 6:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 6:55 PM

epriestley requested review of this revision.

Closed by commit rPHU5060bdf9726b: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU5060bdf9726b: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.

Revision Contents
Changeset List

Path

Size

src/

future/

http/

HTTPSFuture.php

5 lines

Diff 49461

View Options

src/future/http/HTTPSFuture.php

Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizesClosedPublicActions