Page MenuHomePhabricator

Remove the "grant authority" mechanism from users
ClosedPublic

Authored by epriestley on Aug 30 2019, 4:15 PM.
Tags
None
Referenced Files
F15579858: D20754.id.diff
Wed, May 7, 2:01 AM
F15551018: D20754.id.diff
Sun, Apr 27, 3:07 PM
F15546060: D20754.id49485.diff
Sat, Apr 26, 1:36 PM
F15524722: D20754.id49485.diff
Mon, Apr 21, 9:57 AM
F15524319: D20754.id49485.diff
Mon, Apr 21, 7:25 AM
F15519205: D20754.id49483.diff
Sat, Apr 19, 8:49 PM
F15513530: D20754.id.diff
Thu, Apr 17, 7:35 PM
F15510033: D20754.diff
Wed, Apr 16, 6:14 PM
Subscribers
None

Details

Summary

Ref T13393. See some previous discussion in T13366.

Caching is hard and all approaches here have downsides, but the request cache likely has fewer practical downsides for this kind of policy check than other approaches. In particular, the grant approach (at least, as previously used in Phortune) has a major downside that "Query" classes can no longer fully enforce policies.

Since Phortune no longer depends on grants and they've now been removed from instances, drop the mechanism completely.

Test Plan

Grepped for callsites, found none.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.