Page MenuHomePhabricator

Remove the "grant authority" mechanism from users
ClosedPublic

Authored by epriestley on Fri, Aug 30, 4:15 PM.

Details

Summary

Ref T13393. See some previous discussion in T13366.

Caching is hard and all approaches here have downsides, but the request cache likely has fewer practical downsides for this kind of policy check than other approaches. In particular, the grant approach (at least, as previously used in Phortune) has a major downside that "Query" classes can no longer fully enforce policies.

Since Phortune no longer depends on grants and they've now been removed from instances, drop the mechanism completely.

Test Plan

Grepped for callsites, found none.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Aug 30, 4:15 PM
epriestley requested review of this revision.Fri, Aug 30, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Aug 30, 4:26 PM
This revision was automatically updated to reflect the committed changes.