Page MenuHomePhabricator

Remove the "grant authority" mechanism from users
ClosedPublic

Authored by epriestley on Aug 30 2019, 4:15 PM.
Tags
None
Referenced Files
F18724534: D20754.id49485.diff
Tue, Sep 30, 3:51 AM
F18704748: D20754.id49483.diff
Sun, Sep 28, 8:39 AM
F18672697: D20754.diff
Thu, Sep 25, 8:05 AM
F18570565: D20754.id49485.diff
Sep 10 2025, 3:56 AM
F18570564: D20754.id49483.diff
Sep 10 2025, 3:55 AM
F18567337: D20754.id.diff
Sep 9 2025, 3:41 PM
F18379357: D20754.id49483.diff
Aug 28 2025, 3:50 PM
F18379314: D20754.id49485.diff
Aug 28 2025, 3:46 PM
Subscribers
None

Details

Summary

Ref T13393. See some previous discussion in T13366.

Caching is hard and all approaches here have downsides, but the request cache likely has fewer practical downsides for this kind of policy check than other approaches. In particular, the grant approach (at least, as previously used in Phortune) has a major downside that "Query" classes can no longer fully enforce policies.

Since Phortune no longer depends on grants and they've now been removed from instances, drop the mechanism completely.

Test Plan

Grepped for callsites, found none.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.