Unsure how to reproduce this.

I think this is reasonably well-covered between arc anoid and arc weld. Once T5055 comes online, third-parties can presumably fill in more titles for the arc game library.

These have existed for a while and recently got support for customizing sub-object behaviors in 2018 Week 50 (Mid December) and are being extended to Projects in 2019 Week 5, so it looks like they're here to stay.

Here's a script which can hit these behaviors without cloning 9000 working copies in a loop:

uhoh

State of the world on the instance changes:

See PHI1015 for a slightly meatier explanation of this issue.

~o.o~

PHP 7.3.1 is exiting abruptly for me (no error message, return code 0) on preg_match('(\\G\s+)sS', '');. This occurs in the daemons. I can't reproduce this in a separate test script. I have no idea what's going on.

Let's compile Gentoo nine times (Gentoo flavor is macOS Mojave 10.14.2):

PHI1010 could use more detailed triage around whether we can squeeze anything from transaction.search without hitting a bunch of other messes. This is adjacent to a lot of other work.

Success! D20046 worked to fix the "profiler not sticking across form posts" issue on secure. 🐈

@epriestley Sorry bringing up this ancient task. I am also interested in this Azure OAuth feature. Would you kindly point me to some third-party extension coding guideline/documents? I've dug around for the docs, but not found any.

Some guidance about "configure captchas if you're a public-facing, password-login install" would be good here too

In https://discourse.phabricator-community.org/t/2334, thopre suggests checking for git config --get-regexp svn-remote to see if the repository is configured as git-svn repo, as an alternative to check if .git/svn/.metadata exists.

D20049 introduces a piece of code which could be simplified if the minimum version was 5.4.0 or newer, so PHP_QUERY_RFC3986 is available for http_build_query().

In T13224#243817, @epriestley wrote:

@nochum, if you want to try replacing 'pygmentize ... with 'exec pygmentize ... near line 25 of PhutilPygmentsSyntaxHighlighter.php and that fixes it, I'll upstream it. exec will stop dash from leaving an sh -c process running.

Worked perfectly!

(Also: the time limit should be 15 seconds, not 15 minutes! If you're seeing the sh processes die after 15 minutes, something else is likely afoot.)

Yes, it's 15 seconds, I misspoke.

@nochum, if you want to try replacing 'pygmentize ... with 'exec pygmentize ... near line 25 of PhutilPygmentsSyntaxHighlighter.php and that fixes it, I'll upstream it. exec will stop dash from leaving an sh -c process running.

D212: Fix daemon issues caused by Ubuntu's surprising intermediary shell?

It seems the commit didn't fully fix the issue. When pygmentize runs for phabricator, there are processed that are forked from the initial process that are still never killed and they cause the cpu to spike. For example, when running into this issue on our install, we see something like:
#ps aux | grep pygm
user 13190 0.0 0.0 4456 680 ? S 16:46 0:00 sh -c pygmentize -O encoding=utf-8 -O stripnl=False -f html -l 'bash'
user 13191 0.0 0.0 4456 784 ? S 16:46 0:00 sh -c pygmentize -O encoding=utf-8 -O stripnl=False -f html -l 'bash'
user 13192 74.7 0.0 23996 9336 ? R 16:46 0:05 /usr/bin/python /usr/local/bin/pygmentize -O encoding=utf-8 -O stripnl=False -f html -l bash
user 13193 76.7 0.0 23636 9028 ? R 16:46 0:06 /usr/bin/python /usr/local/bin/pygmentize -O encoding=utf-8 -O stripnl=False -f html -l bash

PHI979 is a specific issue where we could use better instance controls (around worker count) in the short term. An alternative approach is to hard-coded if ($instance === 'X') { ... } for now. admin could also probably use more workers, I think we get saturated by backups occasionally.

Yeah, I think the issue is:

The "keep the profiler on across form submissions" code isn't working on secure.phabricator.com, even though it works locally and __profile__=page appears on the "Request" tab.

• PHI979 describes a case where we'd like to automatically increase the worker task limit based on instance size. admin should also get an increased limit.
• Now that MFA can be disabled completely, I want to disable MFA on admin (pretty much everyone adding it is adding it by accident) by deprecating the provider.
• T13178 is adjacent to a lot of this.

Continued in T13242.

After T13222, this is more relevant:

From T13222, MFA on related flows should generally be updated.

From T13222, this should also revisit MFA around Conduit tokens. In particular:

"Kick everyone down to partial session" docs / tooling.

For now, I'm continuing to allow users to "Remove" the last active factor on their account when security.require-multi-factor-auth is enabled. This will kick them to the MFA enrollment screen.