T1279 is talking about the reviewer list on the detail page (/Dxxx), not the list page (/differential/). This was implemented years ago, so I suspect it isn't a duplicate, unless you're years out of date.

@epriestley @eadler : T1279 is exactly what I was looking for. Thanks guys. Feel free to close this task as duplicate.

T731, T1279, and T10574 are all likely related.

Thanks for the request!

D15545 should fix the infrastructure part of this, and make this error more clear by returning an explicit diagnostic error rather than a mostly-working string and a log.

Oh, I believe the actual issue is that the translations are variant on the wrong parameter. I think this is the correct fix (adding an extra array()):

D15544 (changing %s to %d) shouldn't be the fix for this -- %s is correct, because we want to render "1,234,567" if the number is large:

For reference and the benefit of people Googling how to configure a script and regex linter, here is a full example (using sass-lint):

Are you always seeing this render in a bad location or is it only sometimes? I regularly see the first rendered hovercard located way off to the left but it's only the first hovercard that tries to render -- and it's usually only the first hovercard after starting up Firefox. I haven't found reproducible steps so I haven't bothered to report it yet, but I wonder if it's related to this. I primarily use (the most recent) Firefox so it may be just browser. Using Cmd/Ctrl+Refresh doesn't cause it to affect again - manually restarting Firefox is also not a surefire way to reproduce.

No to beat on a dead horse, but I just finished creating a new wiki page with ~20 screenshots of mobile UI (in a series of tables to easily compare UIs on different OSes), and the fact images don't cache is a massive pain:

• whenever editing the markup, even to add a single character, the preview area needs to reload 2+ MBs of screenshots
• not only is this slow, but the layout of the preview jumps all around while the images are (re)loading, so you can't navigate easily
• same thing when saving the changes: everything needs to reload again from scratch and layout jumps again all over the place

Closing this, because it seems to be done, the way the title is written. All other related plans have their own tasks.

Pretty sure I covered all the badge transactions.

D15535 should completely fix this in all cases

In T10621#165969, @epriestley wrote:

How do you imagine Phabricator learning about the existence of new external groups? Just polling a list of every group in LDAP every hour or whatever?

Evidence for the trial (when the fix goes live the description will render correctly)

It was another cspeckmim

u wot m8? havin' a go? havin' a little laff?

Specifically, the issue here is that we fetch and import branch heads, but not other refs, including tags. We also aren't totally consistent about which refs we import across hosted/imported repositories.

@camilorojas You're welcome! PS: I like your avatar ... ^^

In T5391#167263, @witrin wrote:

@camilorojas That's because you haven't defined the custom field std:maniphest:vendor:field. Checkout the docs to see how to do that!

@camilorojas That's because you haven't defined the custom field std:maniphest:vendor:field. Checkout the docs to see how to do that!

In T5391#167083, @witrin wrote:

@camilorojas I think I just added the following file

src/applications/maniphest/export/ManiphestExcelCustomFormat.php

<?php

final class ManiphestExcelCustomFormat extends ManiphestExcelFormat {

  public function getName() {
    return pht('Custom');
  }

  public function getFileName() {
    return 'maniphest_tasks_'.date('Ymd');
  }

  /**
   * @phutil-external-symbol class PHPExcel
   * @phutil-external-symbol class PHPExcel_IOFactory
   * @phutil-external-symbol class PHPExcel_Style_NumberFormat
   * @phutil-external-symbol class PHPExcel_Cell_DataType
   */
  public function buildWorkbook(
    PHPExcel $workbook,
    array $tasks,
    array $handles,
    PhabricatorUser $user) {

    $sheet = $workbook->setActiveSheetIndex(0);
    $sheet->setTitle(pht('Tasks'));

    $widths = array(
      null,
      15,
      null,
      10,
      15,
      15,
      60,
      30,
      20,
      100,
    );

    foreach ($widths as $col => $width) {
      if ($width !== null) {
        $sheet->getColumnDimension($this->col($col))->setWidth($width);
      }
    }

    $status_map = ManiphestTaskStatus::getTaskStatusMap();
    $pri_map = ManiphestTaskPriority::getTaskPriorityMap();

    $date_format = null;

    $rows = array();
    $rows[] = array(
      pht('ID'),
      pht('Owner'),
      pht('Status'),
      pht('Priority'),
      pht('Date Created'),
      pht('Date Updated'),
      pht('Title'),
      pht('Projects'),
      pht('URI'),
      pht('Description'),
      pht('Custom Field'),
    );

    $is_date = array(
      false,
      false,
      false,
      false,
      true,
      true,
      false,
      false,
      false,
      false,
      false,
    );

    $header_format = array(
      'font'  => array(
        'bold' => true,
      ),
    );

    foreach ($tasks as $task) {
      $task_owner = null;
      if ($task->getOwnerPHID()) {
        $task_owner = $handles[$task->getOwnerPHID()]->getName();
      }

      $custom_fields = PhabricatorCustomField::getObjectFields(
        $task,
        PhabricatorCustomField::ROLE_VIEW);
      $custom_fields
        ->setViewer($user)
        ->readFieldsFromStorage($task);
      $custom_fields = $custom_fields->getFields();

      $projects = array();
      foreach ($task->getProjectPHIDs() as $phid) {
        $projects[] = $handles[$phid]->getName();
      }
      $projects = implode(', ', $projects);

      $rows[] = array(
        'T'.$task->getID(),
        $task_owner,
        idx($status_map, $task->getStatus(), '?'),
        idx($pri_map, $task->getPriority(), '?'),
        $this->computeExcelDate($task->getDateCreated()),
        $this->computeExcelDate($task->getDateModified()),
        $task->getTitle(),
        $projects,
        PhabricatorEnv::getProductionURI('/T'.$task->getID()),
        phutil_utf8_shorten($task->getDescription(), 512),
        $custom_fields['std:maniphest:vendor:field']->getValueForStorage(),
      );
    }

    foreach ($rows as $row => $cols) {
      foreach ($cols as $col => $spec) {
        $cell_name = $this->col($col).($row + 1);
        $cell = $sheet
          ->setCellValue($cell_name, $spec, $return_cell = true);

        if ($row == 0) {
          $sheet->getStyle($cell_name)->applyFromArray($header_format);
        }

        if ($is_date[$col]) {
          $code = PHPExcel_Style_NumberFormat::FORMAT_DATE_YYYYMMDD2;
          $sheet
            ->getStyle($cell_name)
            ->getNumberFormat()
            ->setFormatCode($code);
        } else {
          $cell->setDataType(PHPExcel_Cell_DataType::TYPE_STRING);
        }
      }
    }
  }

  private function col($n) {
    return chr(ord('A') + $n);
  }

}

Don't forget to update your class map:

$ cd webroot/phabricator
$ ../arcanist/bin/arc liberate src

One of the fundamental features I really like about Phab is how everything is linked nicely: from diffs to tasks to commits to wiki etc... Seems like Audits are surprisingly silo'ed from the rest.

Modifying clang-format to expose individual messages with distinct patches is the best way forward here.

A generic Phab icon would be fine for a first pass at improving this IMO.

At a minimum, Herald, Harbormaster, Nuance, Phortune and Differential can author stories today, although not all of these stories currently render with photos. We should probably assume any application may author stories.