Page MenuHomePhabricator
Feed All Stories

Mar 16 2016

epriestley renamed T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates from missing index on repository_pathchange table to Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Mar 16 2016, 10:46 PM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

We'll try that in our next upgrade. Thanks for the help!

Mar 16 2016, 10:05 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Here's a diff to make bin/storage adjust always run ANALYZE on every table after it makes other adjustments, but I'm not really sure if that's actually helpful or not (e.g., from the documentation, it sounds like the good analysis can be immediately overwritten by a bad one in some cases?):

Mar 16 2016, 10:01 PM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Unknown Object (Differential Revision).
Mar 16 2016, 9:50 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I think so. Sorry for the originally misleading claim.Sorry for the originally misleading claim.

Mar 16 2016, 9:48 PM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Should we get rid of the <commitID, isDirect, changeType> key, then?

Mar 16 2016, 9:43 PM · Infrastructure
epriestley added a comment to T10260: Harbormaster Herald Rules.

Oh, I might not have made subscribers actually do anything, I don't remember. They definitely should, though, even if they don't yet.

Mar 16 2016, 9:39 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Well, the docs suggest not doing that:

Mar 16 2016, 9:29 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Should we get rid of the <commitID, isDirect, changeType> key, then?

Mar 16 2016, 9:24 PM · Infrastructure
michaeljs1990 added a comment to T10260: Harbormaster Herald Rules.

The ability to add subscribers which is now on master should solve most of these issue for people.

Mar 16 2016, 9:18 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

The discrepancy between staging + production is almost certainly caused by the size of the data.

You do not need to create a secondary index on changeId as that is the leftmost part of the primary key. The secondary index just points to the primary index where the data is stored.

The underlying cause of the slowness is because the stats were completely off in the production table (was showing cardnality of 18 for changeId).

Mar 16 2016, 9:13 PM · Infrastructure
getaaron added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

I don't know RuboCop well enough to definitively answer the question about whether that mode exists, or to volunteer to maintain the driver. But I opened a parallel issue in the RuboCop repo, so hopefully we'll find out whether RuboCop has this mode soon enough.

Mar 16 2016, 8:23 PM · Lint, Feature Request
waxmigs2902 awarded T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver a Like token.
Mar 16 2016, 7:54 PM · Lint, Feature Request
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 16 2016, 7:49 PM · Customer Impact, Restricted Project, Files, Diffusion
urzds added a comment to T10427: Errors when adding person to subproject.

I can confirm that, too.

Mar 16 2016, 7:09 PM · Projects
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

We could also maybe do something ridiculous like assume it's @2x if both dimensions are even, but M1461 has a 2X image with an odd height (1717px!) so that probably won't get us very far ignoring all the false positives for 400x300px images and such.

Mar 16 2016, 6:45 PM · Pholio, Feature Request
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

I think this is reasonable to build as:

Mar 16 2016, 6:44 PM · Pholio, Feature Request
chad added a comment to T10601: Scale retina images when they are used in a mock.

It looks like Invision makes you append @2x to the filename to indicate that the files should be displayed at 50% to low dpi displays. So, file_name@2x.png would trigger appropriate CSS to handle layout.

Mar 16 2016, 6:38 PM · Pholio, Feature Request
awfy added a comment to T10601: Scale retina images when they are used in a mock.

The benefit is merely the lack of requirement for people to zoom out from an image in order to see it at the correct scale. I upload entire UIs to Pholio to explain flows and changes. If the UI is displayed at twice the size it will eventually be, it's rather difficult to get a true feel for how it looks. Would be great for people to be able to see my work in the intended zoom.

Mar 16 2016, 6:28 PM · Pholio, Feature Request
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 16 2016, 6:06 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Assuming this mode does not exist, the clearest pathway forward is for you or someone else to:

Mar 16 2016, 6:03 PM · Lint, Feature Request
eadler moved T4706: Maybe make `arc land D123` go look up the branch? from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 16 2016, 6:02 PM · Prioritized, Restricted Project, Arcanist
eadler added a project to T4706: Maybe make `arc land D123` go look up the branch?: Restricted Project.
Mar 16 2016, 6:02 PM · Prioritized, Restricted Project, Arcanist
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Does RuboCop actually have a mode where it emits errors and replacement text?

Mar 16 2016, 5:59 PM · Lint, Feature Request
avivey added a project to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver: Lint.
Mar 16 2016, 5:58 PM · Lint, Feature Request
avivey closed Q339: How can I make arc lint with rubocop output patches? as resolved.
Mar 16 2016, 5:57 PM
eadler added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

See also T10038

Mar 16 2016, 5:55 PM · Lint, Feature Request
getaaron created T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.
Mar 16 2016, 5:52 PM · Lint, Feature Request
epriestley added a revision to T10264: git clone using http hangs after update: Unknown Object (Differential Revision).
Mar 16 2016, 5:51 PM · Bug Report, Diffusion
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 16 2016, 5:51 PM · Diffusion (v3), Restricted Project
epriestley created T10604: Allow application code to stream request data.
Mar 16 2016, 5:46 PM · Diffusion (v3), Restricted Project
avivey added Q339: How can I make arc lint with rubocop output patches? (Answer 345).
Mar 16 2016, 5:16 PM
epriestley closed T10603: Make AuthTemporaryTokens suitable for use as LFS tokens, a subtask of T7789: Support Git Large File Storage, as Resolved.
Mar 16 2016, 4:35 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T10603: Make AuthTemporaryTokens suitable for use as LFS tokens as Resolved by committing Restricted Diffusion Commit.
Mar 16 2016, 4:34 PM · Auth
getaaron updated Q339: How can I make arc lint with rubocop output patches? from to How can I make arc lint with rubocop output patches?.
Mar 16 2016, 4:13 PM
r0bbie awarded T7789: Support Git Large File Storage a Like token.
Mar 16 2016, 4:12 PM · Customer Impact, Restricted Project, Files, Diffusion
Luke081515.2 awarded T8887: Allow owners packages to add blocking reviewers a Love token.
Mar 16 2016, 4:10 PM · Haskell.org, Restricted Project, Owners
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 16 2016, 2:51 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs as Resolved.
Mar 16 2016, 2:49 PM · Installing & Upgrading, Bug Report
• jlvillapalos added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

@epriestley, first time I tried I just wasn't lucky enough to navigate to Config->Versions.
By the way I updated my Phabricator version and it works fine.

Mar 16 2016, 2:48 PM · Installing & Upgrading, Bug Report
chad added a comment to T10601: Scale retina images when they are used in a mock.

Oops, sorry, I mis-remembered that other task.

Mar 16 2016, 2:21 PM · Pholio, Feature Request
epriestley added a comment to T10254: Assign projects to spaces.

There is not, and never will be. Associated projects never affect policies, so there is no possibility to make them start affecting policies. I'm not sure what's unclear about this.

Mar 16 2016, 2:21 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

That one might be better to merge here, since it's probably impossible (at least, in the general case) but this talks about some things we can do in the general case.

Mar 16 2016, 2:20 PM · Pholio, Feature Request
maxie added a comment to T10254: Assign projects to spaces.

Yes, I understood the general behavior. I also read this documentation. What I could not find, however, was if there is any possibility to set tasks visibility by standard based on their associated project.

Mar 16 2016, 2:19 PM · Restricted Project, Spaces, Projects, Feature Request
chad reopened T10601: Scale retina images when they are used in a mock as "Open".
Mar 16 2016, 2:17 PM · Pholio, Feature Request
chad updated subscribers of T7910: Pasted Retina images scale automatically even with "full".
Mar 16 2016, 2:15 PM · PHUI
chad merged task T10601: Scale retina images when they are used in a mock into T7910: Pasted Retina images scale automatically even with "full".
Mar 16 2016, 2:15 PM · Pholio, Feature Request
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 2:11 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:56 PM · Auth
epriestley added a comment to T10254: Assign projects to spaces.

By design, changing projects never affects policies. See the documentation here:

Mar 16 2016, 1:52 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

@jlvillapalos, can you shed some light on why you didn't include that information in the first place or how we could improve the process?

Mar 16 2016, 1:49 PM · Installing & Upgrading, Bug Report
maxie added a comment to T10254: Assign projects to spaces.

I am also unsure about how to use spaces if they cannot be applied projects.

Mar 16 2016, 1:45 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley closed T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery". as Resolved.

bin/remove destroy gives you a huge scary red skull-and-crossbones ASCII art for good reason, and you're accepting that issues like this may occur when you confirm the prompt.

Mar 16 2016, 1:40 PM · Audit, Diffusion, Bug Report
• tinytiongson added a project to T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery".: Audit.

The problem was encountered when we have deleted the existing repository with audits because we wanted to include not just the trunk but all its branches. The thing was that the deleted repository in Diffusion was not the first one to be imported again.

Mar 16 2016, 1:30 PM · Audit, Diffusion, Bug Report
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:26 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:14 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 12:37 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 12:24 PM · Auth
epriestley changed the edit policy for T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Mar 16 2016, 12:18 PM · Auth
epriestley changed the edit policy for T7789: Support Git Large File Storage.
Mar 16 2016, 12:18 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley created T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Mar 16 2016, 12:15 PM · Auth
MuratUrsavas created T10602: Adding client side private key addition information to Diffusion Repo Hosting Guide..
Mar 16 2016, 11:49 AM · Feature Request
epriestley added a comment to T5214: Add Conduit API methods for workboards.

T10599 asks for column move APIs, which are adjacent to this.

Mar 16 2016, 11:49 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley updated subscribers of T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley merged task T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」 into T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Bug Report
epriestley added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

This transaction can only create a task into a column, it can't move a task. That's why the documentation says "Create into a workboard column.".

Mar 16 2016, 11:48 AM · Bug Report
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

I don't think we can detect this automatically -- a, say, web-ready PNG from Photoshop generally won't have DPI information, as far as I know.

Mar 16 2016, 11:46 AM · Pholio, Feature Request
MuratUrsavas added a comment to Q338: How can I edit the documentation? (Answer 344).

I agree providing solution on the software side rather than documentation is the best way to go. But since my request is for the client side, there is nothing to do for the Phabricator team except a minor improvement on the documentation.

Mar 16 2016, 11:44 AM
epriestley added a comment to T3167: Use full names in Conpherence messages.

We are vanishingly unlikely to revisit this decision. If this is important to your organization, you should look into forking the codebase to provide the functionality you are interested in.

Mar 16 2016, 11:40 AM · Conpherence
epriestley added Q338: How can I edit the documentation? (Answer 344).
Mar 16 2016, 11:36 AM
r0bbie added a comment to T10592: Ability to exclude certain projects in a Dashboard Panel.

Thanks @chad, that almost resolved it. I was able to create a query specifying active projects with particular icons only, save this, and use it as the query for the "Your Projects" panel.

Mar 16 2016, 11:36 AM · Feature Request
r0bbie added a comment to T10592: Ability to exclude certain projects in a Dashboard Panel.
Mar 16 2016, 11:18 AM · Feature Request
sascha-egerer added a comment to T8594: Develop system for dumping/backing up Phriction documents.

@jhurwitz I use conduit to fetch wiki pages and format them with conduit to get a html syntax. I do that to add Wiki-Pages to a Frontend-Styleguide. Then i just add the required phabricator css and everything looks fine.
So i think you can write your own simple script to do everything over conduit, right?

Mar 16 2016, 10:59 AM · Phriction, Restricted Project
• MalkavianBilbao removed a watcher for Community: • MalkavianBilbao.
Mar 16 2016, 10:07 AM
• MalkavianBilbao added a watcher for Community: • MalkavianBilbao.
Mar 16 2016, 10:06 AM
MuratUrsavas updated Q338: How can I edit the documentation? from to How can I edit the documentation?.
Mar 16 2016, 8:36 AM · Diffusion
• jlvillapalos added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

This is the version information, but it will be very useful to give instructions of where to look to get it.

Mar 16 2016, 7:39 AM · Installing & Upgrading, Bug Report
awfy created T10601: Scale retina images when they are used in a mock.
Mar 16 2016, 7:20 AM · Pholio, Feature Request
chad closed T10600: Add a Custom Name to Authentication Methods as Wontfix.

The short answer is we're allergic to options (see T8227), and you can do this yourself reasonably easy. Copy PhabricatorLDAPAuthProvider.php, change what you want into a new class, drop it in src/extensions and run arc liberate to rebuild the library. It should show up as a new option if you did it correctly.

Mar 16 2016, 3:07 AM · Feature Request
chad added a comment to T10600: Add a Custom Name to Authentication Methods.

root problem: Sometimes you want less technical clients to be able to file bugs in your fancy new phabricator.

Mar 16 2016, 2:57 AM · Feature Request
AmyLewis added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

@chad Probably the same purpose.

Mar 16 2016, 2:54 AM · Bug Report
ofbeaton created T10600: Add a Custom Name to Authentication Methods.
Mar 16 2016, 2:53 AM · Feature Request
chad added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

Is this different than T5214?

Mar 16 2016, 2:51 AM · Bug Report
AmyLewis created T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.
Mar 16 2016, 2:44 AM · Bug Report
chad added a comment to T10598: Options to display Real Name instead of username everywhere.

@ofbeaton ^^ That single line should convert 90% of the name links, if you need.

Mar 16 2016, 2:43 AM · Feature Request
chad added a comment to T10598: Options to display Real Name instead of username everywhere.
diff --git a/src/applications/phid/PhabricatorObjectHandle.php b/src/applications/phid/PhabricatorObjectHandle.php
index 2b626f2..ad2ff9e 100644
--- a/src/applications/phid/PhabricatorObjectHandle.php
+++ b/src/applications/phid/PhabricatorObjectHandle.php
@@ -340,7 +340,7 @@ final class PhabricatorObjectHandle
   public function getLinkName() {
     switch ($this->getType()) {
       case PhabricatorPeopleUserPHIDType::TYPECONST:
-        $name = $this->getName();
+        $name = $this->getFullName();
         break;
       default:
         $name = $this->getFullName();
Mar 16 2016, 2:36 AM · Feature Request
chad added a comment to T10598: Options to display Real Name instead of username everywhere.

If you're willing to maintain a fork / patch, this is probably just a few extra lines of code to get most of them.

Mar 16 2016, 2:32 AM · Feature Request
ofbeaton awarded T3167: Use full names in Conpherence messages a Like token.
Mar 16 2016, 2:31 AM · Conpherence
ofbeaton added a comment to T3167: Use full names in Conpherence messages.

I'm in the same boat as @devurandom here, imported horrible AD randomly generated usernames.

Mar 16 2016, 2:31 AM · Conpherence
chad changed the visibility for T3167: Use full names in Conpherence messages.
Mar 16 2016, 2:27 AM · Conpherence
ofbeaton added a comment to T10598: Options to display Real Name instead of username everywhere.

Thanks, I thought I had searched before filing, but apparently not with the right terms. Thanks for the information. I wish I could change the LDAP conventions, but I control Phabricator, not Corporate IT LDAP in other departments.

Mar 16 2016, 2:25 AM · Feature Request
ofbeaton awarded T6703: Allow multiple copies of the same auth provider type a Like token.
Mar 16 2016, 2:21 AM · Auth
epriestley added a comment to T6703: Allow multiple copies of the same auth provider type.

You can "Award Token".

Mar 16 2016, 2:21 AM · Auth
Krenair awarded T6703: Allow multiple copies of the same auth provider type a Love token.
Mar 16 2016, 2:19 AM · Auth
ofbeaton added a comment to T6703: Allow multiple copies of the same auth provider type.

Came here to request this feature, searched for it, found it. Multiple LDAPs over here. Is there some kind of +1 technology over here so you know how many people come here to request it?

Mar 16 2016, 2:18 AM · Auth
dereckson added a comment to T10598: Options to display Real Name instead of username everywhere.

@ofbeaton For more context and arguments to give if you wish to review your LDAP conventions, see T3167#32426.

Mar 16 2016, 2:14 AM · Feature Request
chad added a comment to T10598: Options to display Real Name instead of username everywhere.

Wow yeah, that's terrible.

Mar 16 2016, 2:14 AM · Feature Request
chad changed the visibility for T2950: Possibility to display the RealName instead of the UserName.
Mar 16 2016, 2:12 AM · Differential
chad updated subscribers of T2950: Possibility to display the RealName instead of the UserName.
Mar 16 2016, 2:12 AM · Differential
chad merged task T10598: Options to display Real Name instead of username everywhere into T2950: Possibility to display the RealName instead of the UserName.
Mar 16 2016, 2:12 AM · Feature Request