Page MenuHomePhabricator
Feed All Stories

Nov 23 2015

epriestley closed T7000: 404 when accessing repo via http as Invalid.

I can not reproduce this. Here's what I did:

Nov 23 2015, 4:14 PM · Diffusion
chad removed a reviewer for D11047: Inline Comments not working: chad.
Nov 23 2015, 4:04 PM
epriestley removed a reviewer for D11047: Inline Comments not working: Blessed Reviewers.
Nov 23 2015, 4:04 PM
epriestley closed T6777: Arcanist creates a branch when --nobranch is specified as Wontfix.

We haven't seen any other users find this confusing.

Nov 23 2015, 4:03 PM · Arcanist
epriestley added a comment to T4256: Support Azure as an auth provider.

As a general note, Azure appears to have both SAML and OAuth flavors. D10297 / D10289 implement the OAuth flavors, and don't invoke the messy SAML problem. I'm not sure if these providers are equivalent or not.

Nov 23 2015, 3:48 PM · Auth
epriestley moved T4256: Support Azure as an auth provider from Backlog to Far Future on the Auth board.
Nov 23 2015, 3:48 PM · Auth
epriestley added a comment to T4256: Support Azure as an auth provider.

Current state of the world is:

Nov 23 2015, 3:47 PM · Auth
epriestley updated subscribers of T4256: Support Azure as an auth provider.
Nov 23 2015, 3:45 PM · Auth
epriestley merged task T5899: Add support for authentication through Office 365 into T4256: Support Azure as an auth provider.
Nov 23 2015, 3:45 PM · Auth
epriestley closed T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest as Resolved by committing Restricted Diffusion Commit.
Nov 23 2015, 2:50 PM · Remarkup, Projects
chad claimed T9833: Remarkup comment areas have an excessively tall bottom margin.
Nov 23 2015, 2:38 PM · Remarkup
epriestley added a comment to T9789: Make it easier to write custom transaction types.

I think we can do this gradually by:

Nov 23 2015, 2:05 PM · Modernization, Transactions
epriestley claimed T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest.
Nov 23 2015, 1:59 PM · Remarkup, Projects
epriestley closed T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception as Resolved.
Nov 23 2015, 1:59 PM · Phriction
epriestley closed T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier as Resolved by committing Restricted Diffusion Commit.
Nov 23 2015, 1:58 PM · Harbormaster, Drydock
epriestley added a revision to T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest: Unknown Object (Differential Revision).
Nov 23 2015, 1:55 PM · Remarkup, Projects
epriestley added a comment to T9833: Remarkup comment areas have an excessively tall bottom margin.

(This is likely an example of the issue.)

Nov 23 2015, 1:44 PM · Remarkup
epriestley created T9833: Remarkup comment areas have an excessively tall bottom margin.
Nov 23 2015, 1:44 PM · Remarkup
epriestley added a comment to T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.

Oh, this was already fixed at HEAD (rP06aa3a0a1b). I pushed this server, should be good now.

Nov 23 2015, 1:38 PM · Phriction
bbrdaric created T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest.
Nov 23 2015, 1:36 PM · Remarkup, Projects
epriestley added a comment to T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.

Thanks, I'll look into this.

Nov 23 2015, 1:34 PM · Phriction
epriestley claimed T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.
Nov 23 2015, 1:34 PM · Phriction
tolbrino awarded T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available a Like token.
Nov 23 2015, 1:11 PM · Haskell.org, Auth
• nick.udell awarded T6805: Possibility to reply inline comments in Pholio mocks a Love token.
Nov 23 2015, 12:16 PM · Pholio
OCram added a comment to Q220: How to create and deploy custom linters? (Answer 254).

Do I have to create a new library when I create new files/classes in the extensions directory?
In my test the new linter worked, but only with single files...

Nov 23 2015, 11:51 AM
• nick.udell updated the task description for T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.
Nov 23 2015, 11:08 AM · Phriction
• nick.udell created T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.
Nov 23 2015, 11:06 AM · Phriction
rubikonx9 updated Q226: Arcanist with self-signed SSL certificate from to Arcanist with self-signed SSL certificate.
Nov 23 2015, 10:38 AM · Installing & Upgrading, Config, Arcanist
• quinyx_martin closed T9830: Remove as Resolved.
Nov 23 2015, 10:16 AM
• quinyx_martin renamed T9830: Remove from Temporary restore component edit buttons design to Remove.
Nov 23 2015, 10:16 AM
• quinyx_martin created T9830: Remove.
Nov 23 2015, 10:15 AM
sougat818 awarded T9829: Exception after Updating Phabricator a Like token.
Nov 23 2015, 7:15 AM · Phriction
sougat818 added a comment to T9829: Exception after Updating Phabricator.

Works well now. Thanks a lot @chad

Nov 23 2015, 7:15 AM · Phriction
chad closed T9829: Exception after Updating Phabricator as Resolved by committing Restricted Diffusion Commit.
Nov 23 2015, 7:07 AM · Phriction
chad added a revision to T9829: Exception after Updating Phabricator: Unknown Object (Differential Revision).
Nov 23 2015, 7:00 AM · Phriction
sougat818 updated the task description for T9829: Exception after Updating Phabricator.
Nov 23 2015, 6:58 AM · Phriction
sougat818 updated the task description for T9829: Exception after Updating Phabricator.
Nov 23 2015, 6:58 AM · Phriction
sougat818 added a comment to T9829: Exception after Updating Phabricator.

Thanks a lot @chad .

Nov 23 2015, 6:57 AM · Phriction
ablekh added a comment to T6609: Support math (LaTeX) equation in Remarkup.

@avivey: Thank you for clarification and references. I understand the rationale behind the changes, though, I still see that Phabricator still allows executing "trusted" binaries (whatever it means). Anyway, I could not find documentation on using extensions, so I'm not too sure about how to use tex2im, tex2png or similar programs in Phabricator's context. Perhaps, someone could point me to the relevant documentation and/or, better, share some examples for that approach.

Nov 23 2015, 6:50 AM · Restricted Project, Remarkup
chad added a comment to T9829: Exception after Updating Phabricator.

I think I found one here:

Nov 23 2015, 6:50 AM · Phriction
sougat818 edited projects for T9829: Exception after Updating Phabricator, added: Phriction; removed Maniphest.
Nov 23 2015, 6:48 AM · Phriction
chad added a comment to T9829: Exception after Updating Phabricator.

Specifically that error message is from Phriction, not Maniphest. So I don't know how to reproduce it.

Nov 23 2015, 6:44 AM · Phriction
chad added a comment to T9829: Exception after Updating Phabricator.

Please see Contributing Bug Reports. We need the full steps to reproduce the issue, or try to reproduce the issue here.

Nov 23 2015, 6:40 AM · Phriction
chad renamed T6609: Support math (LaTeX) equation in Remarkup from Support math (LaTeX) equation in Phriction wiki to Support math (LaTeX) equation in Remarkup.
Nov 23 2015, 6:30 AM · Restricted Project, Remarkup
sougat818 created T9829: Exception after Updating Phabricator.
Nov 23 2015, 6:19 AM · Phriction
avivey added a comment to T6609: Support math (LaTeX) equation in Remarkup.

@ablekh: quite a lot has changed in this front since April - see T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`; in particular, we no longer consider "executing arbitrary binaries" to be reasonable approach for this kind of situation.

Nov 23 2015, 5:44 AM · Restricted Project, Remarkup
chad closed T9793: Remarkup tables have uneven top and bottom margins as Resolved by committing Restricted Diffusion Commit.
Nov 23 2015, 5:10 AM · Remarkup
ablekh added a comment to T6609: Support math (LaTeX) equation in Remarkup.

After reading the Contributing Code guide, it seems that I would have quite a high barrier of entry, should I decide to contribute to the project on this feature (upstream; normal process). In regard to listed alternatives, local fork is likely not a good idea for me and developing an application is likely not relevant to this feature, as, if I understand correctly, it should be a part of general/core code (i.e, Remarkup blocks for wiki). Therefore, the only feasible option (for enabling this feature on local install) that I could think of (additional benefit: this would be general, enabling LaTeX for any Phabricator's Web output) is to move the LaTeX-to-HTML on-the-fly conversion outside of Phabricator's code, specifically, as part of Web server request processing. For example, it could be implemented as a Nginx module or directly - via Nginx config - pass the output through KaTeX's server-side processing ("Server side rendering: KaTeX produces the same output regardless of browser or environment, so you can pre-render expressions using Node.js and send them as plain HTML."). Does it make sense? Please let me know what you think about all this.

Nov 23 2015, 4:22 AM · Restricted Project, Remarkup
ablekh added a comment to T6609: Support math (LaTeX) equation in Remarkup.

@chad: Got it, thank you for the reference!

Nov 23 2015, 3:43 AM · Restricted Project, Remarkup
chad added a comment to T6609: Support math (LaTeX) equation in Remarkup.

See Planning.

Nov 23 2015, 3:26 AM · Restricted Project, Remarkup
ablekh added a comment to T6609: Support math (LaTeX) equation in Remarkup.

New kid on the Phabricator block here. Firstly, I just wanted to say that I thoroughly impressed by Phabricator and thank all of contributors you for producing such a nice piece of software. After rather comprehensive evaluation of existing tools (mostly open source), I have chosen Phabricator as a platform of choice for my initiatives on improvement of research and software engineering processes a materials science / materials informatics research group, where I currently work (Georgia Tech).

Nov 23 2015, 3:17 AM · Restricted Project, Remarkup
yelirekim created T9828: Make migrating files less scary.
Nov 23 2015, 2:31 AM · Restricted Project, Files
chad added a revision to T9793: Remarkup tables have uneven top and bottom margins: Unknown Object (Differential Revision).
Nov 23 2015, 2:10 AM · Remarkup
joshuaspence added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

Just wanted to clarify as I'm not entirely sure that I understand... So we currently have a puppet role named phabricator_worker which runs phd daemons. As a step in our puppet scripts, we basically run /usr/src/phabricator/bin/almanac register --device=worker.phabricator.example.com --private-key=/path/to/private.key.

Nov 23 2015, 2:08 AM

Nov 22 2015

bgamari edited the content of Community Resources.
Nov 22 2015, 11:24 PM
epriestley closed T9806: Exception while editing Ponder comment to an answer as Resolved by committing Restricted Diffusion Commit.
Nov 22 2015, 11:12 PM · Ponder
bgamari abandoned D14535: Add external-json linter.
Nov 22 2015, 11:09 PM
bgamari added a comment to D14535: Add external-json linter.

This code looks good to me in a technical sense, we just don't want to take over maintaining it. Two minor suggestions:

  • phutil_utf8_strtolower() has better behavior than strtolower() on some utf8 inputs.
  • phutil_json_decode() has better behavior (throws a detailed exception) on invalid JSON than json_decode() (returns false).

Thanks for the review!

Nov 22 2015, 11:05 PM
epriestley added a revision to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier: Unknown Object (Differential Revision).
Nov 22 2015, 11:01 PM · Harbormaster, Drydock
epriestley claimed T9806: Exception while editing Ponder comment to an answer.
Nov 22 2015, 10:59 PM · Ponder
epriestley added a comment to D14535: Add external-json linter.

This code looks good to me in a technical sense, we just don't want to take over maintaining it. Two minor suggestions:

Nov 22 2015, 10:53 PM
bgamari added a comment to T9827: Provide a more structured way of interfacing with external linters.

Fair enough. Thanks for your thoughtful reply.

Nov 22 2015, 10:46 PM · Lint, Arcanist
epriestley requested changes to D14535: Add external-json linter.

Per T9827, I currently believe this would be used by only one install and don't want to bring it upstream without seeing much broader interest first.

Nov 22 2015, 10:40 PM
epriestley closed T9827: Provide a more structured way of interfacing with external linters as Wontfix.

We haven't seen other requests in this vein from other users, and are not aware of a more general interest in using JSON bindings to write linters. From your problem description, it sounds like you have a fairly unusual and specific need within your project. We haven't seen other projects report similar needs, and I think this is isn't a good candidate for bringing upstream: we don't want to upstream code which will only be used by one install, and I have no reason to believe that these bindings will see wider use.

Nov 22 2015, 10:39 PM · Lint, Arcanist
bgamari updated the diff for D14535: Add external-json linter.

Correct comments

Nov 22 2015, 10:23 PM
bgamari added a comment to T9827: Provide a more structured way of interfacing with external linters.

@epriestley, the amended text should clarify my goals here.

Nov 22 2015, 10:18 PM · Lint, Arcanist
bgamari updated the task description for T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:18 PM · Lint, Arcanist
epriestley added a revision to T9806: Exception while editing Ponder comment to an answer: Unknown Object (Differential Revision).
Nov 22 2015, 10:15 PM · Ponder
epriestley added a comment to T9806: Exception while editing Ponder comment to an answer.

This probably requires $types[] = PhabricatorTransactions::TYPE_EDGE; in PonderAnswerEditor->getTransactionTypes(). It would be vaguely nice to do this more automatically/consistently, but probably not worth pursuing some grander approach at this time. T9789 is probably on the horizon and represents a better opportunity.

Nov 22 2015, 10:13 PM · Ponder
epriestley moved T9811: Make it easier to diagnose command failures occurring inside Drydock allocations from Backlog to Far Future on the Drydock board.
Nov 22 2015, 10:09 PM · Drydock
epriestley added a comment to T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.

This obscurity is currently intentional, for policy/security reasons. I don't want to leak anything sensitive into the relatively-accessible web UI.

Nov 22 2015, 10:09 PM · Drydock
epriestley added a comment to T9827: Provide a more structured way of interfacing with external linters.

See Contributing Feature Requests. Please describe the specific, concrete problem you're encountering.

Nov 22 2015, 10:08 PM · Lint, Arcanist
bgamari updated the task description for T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:07 PM · Lint, Arcanist
bgamari added a revision to T9827: Provide a more structured way of interfacing with external linters: D14535: Add external-json linter.
Nov 22 2015, 10:06 PM · Lint, Arcanist
bgamari added a task to D14535: Add external-json linter: T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:06 PM
bgamari created T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:04 PM · Lint, Arcanist
epriestley triaged T9811: Make it easier to diagnose command failures occurring inside Drydock allocations as Wishlist priority.
Nov 22 2015, 10:04 PM · Drydock
epriestley merged T9812: Show SSH diagnostic information in Drydock logs into T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.
Nov 22 2015, 10:04 PM · Drydock
epriestley merged task T9812: Show SSH diagnostic information in Drydock logs into T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.
Nov 22 2015, 10:04 PM · Drydock
epriestley closed T9814: Add SVG icon for Safari 9's pinned tabs as Resolved.

Fixed by D14527.

Nov 22 2015, 10:04 PM · User Delight
epriestley added a comment to T9825: Remarkup is rendered literally in Diviner.

To move forward, we should split this into two tasks:

Nov 22 2015, 10:03 PM · Diviner
epriestley triaged T9825: Remarkup is rendered literally in Diviner as Low priority.
Nov 22 2015, 10:02 PM · Diviner
epriestley added a comment to T9825: Remarkup is rendered literally in Diviner.

These cases aren't closely related.

Nov 22 2015, 10:01 PM · Diviner
epriestley renamed Blog Post: Development Notes (2015 Week 47) blog post from to Development Notes (2015 Week 47).
Nov 22 2015, 9:55 PM
chad edited the content of 2015 Week 47 (Late November).
Nov 22 2015, 9:22 PM
epriestley edited the content of 2015 Week 47 (Late November).
Nov 22 2015, 9:18 PM
chad closed T9826: Phriction saved page is not same as previewing one as Resolved.
Nov 22 2015, 9:12 PM · Phriction
epriestley requested changes to D14535: Add external-json linter.

See Contributing Code.

Nov 22 2015, 9:05 PM
joshuaspence renamed T9826: Phriction saved page is not same as previewing one from phriction saved page is not same as previewing one. to Phriction saved page is not same as previewing one.
Nov 22 2015, 8:17 PM · Phriction
bgamari retitled D14535: Add external-json linter from to Add external-json linter.
Nov 22 2015, 8:04 PM
joshuaspence added a comment to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.

@joshuaspence what do you think about this issue?

Nov 22 2015, 7:18 PM · Subversion, Arcanist
chad added a revision to T9826: Phriction saved page is not same as previewing one: Unknown Object (Differential Revision).
Nov 22 2015, 4:56 PM · Phriction
seungrye created T9826: Phriction saved page is not same as previewing one.
Nov 22 2015, 11:42 AM · Phriction
• andrask added a comment to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.

@avivey I'm not sure how I can create a patch for that repo as it has no valid .arcconfig and I don't have the config for the whole Phabricator project. So I just created an svn diff that you can apply locally and then create the patch with your setup. I uploaded it here: https://secure.phabricator.com/F989152

Nov 22 2015, 8:18 AM · Subversion, Arcanist
avivey added a comment to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.

@andrask: I couldn't quite understand what exactly is going on, and what is the expected behavior.

Nov 22 2015, 6:14 AM · Subversion, Arcanist
halojedi20 updated the task description for T9456: Evaluate upstream support for third-party build systems.
Nov 22 2015, 4:09 AM · Restricted Project, Harbormaster
joshuaspence renamed T9819: Allow Phurl URLs to reference objects from allow multiple aliases to a phurl to Allow multiple aliases to a Phurl URL.
Nov 22 2015, 2:34 AM · Restricted Project, Phurl
joshuaspence added a comment to T9825: Remarkup is rendered literally in Diviner.

("No time specified" in Phame is a bit odd too, but I think that's been fixed already)

Nov 22 2015, 2:33 AM · Diviner

Nov 21 2015

chad added a comment to T5908: Rename "Export to Excel" to "Export to Spreadsheet".

See Contributing Bug Reports. Mainly, contributing comments to an unrelated task will not likely get a bug verified or fixed.

Nov 21 2015, 11:45 PM · Wikimedia, Maniphest, Badge Awarded
hach-que added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

Because the publish step isn't run command. The publishing step is actually 8 other "Run Build plan" steps; these in turn have run command, but there's about 10 run command steps (these build plans clone a repository, update the binary artifact in them, then commit and push).

Nov 21 2015, 11:41 PM · Restricted Project, Harbormaster