Page MenuHomePhabricator
Feed Advanced Search

Mar 10 2017

epriestley added a revision to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: Unknown Object (Differential Revision).
Mar 10 2017, 10:48 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Hrrm -- I can adjust bin/mail send-test to accept raw email addresses, and then you can use it to send a message to test+00001@gmail.com, test+00002@gmail.com and similar. Shouldn't be too involved.

Mar 10 2017, 10:43 PM · Mail, Bug Report
epriestley created T12379: Instance reporting difficulty pushing the Linux kernel to a Phacility instance.
Mar 10 2017, 1:06 AM · Customer Impact, Diffusion, Ops

Mar 9 2017

Sohojoe awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 9 2017, 8:28 PM · Workboards (v3), Restricted Project
epriestley added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 9 2017, 7:43 PM · Badges (v0)
epriestley merged T12376: Export workboard columns for reporting into T5024: Provide a dedicated page for viewing a single workboard column.
Mar 9 2017, 7:39 PM · Restricted Project, Workboards
epriestley merged task T12376: Export workboard columns for reporting into T5024: Provide a dedicated page for viewing a single workboard column.
Mar 9 2017, 7:39 PM · Feature Request
epriestley added a comment to T12376: Export workboard columns for reporting.

Here's a (not so great) workaround:

Mar 9 2017, 7:39 PM · Feature Request
epriestley added a comment to T12270: Unbeta Badges.

I'll send you some kind of something-or-other for dropping "Quality" from Conduit for the moment.

Mar 9 2017, 7:29 PM · Badges (v0)
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Internally, PHPMailer sends headers through two adjustment phases:

Mar 9 2017, 6:30 PM · Mail, Bug Report
epriestley added a comment to T12359: Registration does not accept valid email addresses.

I know someone who has a normalname@domain.horse address and frequently finds services which won't accept it (since they're hard-coded for 3-letter TLDs) so I'd guess users with ={^_^}=@nekoneko.com addresses run into more frequent problems. We should handle .horse, .technology, etc., properly.

Mar 9 2017, 6:18 PM · Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Can you test if this fixes the issue in your environment?

Mar 9 2017, 6:15 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

I think this is the controlling specification -- 2008 was a simpler time when no sequence of non-whitespace characters could ever be longer than 78 bytes, and a thousand bytes of memory was an untold wealth of riches:

Mar 9 2017, 6:09 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

I think the actual issue is that we're not wrapping the header. When I generate a synthetic message locally with a "To:" header with a length of ~50,000 bytes, the raw output is an unbroken line ~50,00 bytes long. I suspect this is RFC-violating and that whatever the mail gets handed to next gets upset by it.

Mar 9 2017, 5:57 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Perfect, thanks!

Mar 9 2017, 5:28 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

What is metamta.mail-adapter set to?

Mar 9 2017, 5:26 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

See also T12046 for why all open source is sketchy voodoo and the eventual pathway forward here is likely replacing it with first-party code.

Mar 9 2017, 5:25 PM · Mail, Bug Report
epriestley updated subscribers of T12374: Saved Workboard Queries.

Two workarounds you could use here are:

Mar 9 2017, 5:15 PM · Workboards, Feature Request
epriestley added a comment to T12375: Integrate Conduit API for Policy Object Creation.

(Are you associated with WMF, or just noting that they have an extension for this?)

Mar 9 2017, 4:56 PM · Policy, Feature Request
epriestley added a comment to T12376: Export workboard columns for reporting.

Or maybe a better question is: @mrybczyn, are you asking on behalf of KDE, or a different project?

Mar 9 2017, 4:55 PM · Feature Request
epriestley updated subscribers of T12376: Export workboard columns for reporting.

@bcooksley, is this another one of yours?

Mar 9 2017, 4:53 PM · Feature Request
epriestley awarded T12378: "This task has been locked" on all logged out tasks a Pterodactyl token.
Mar 9 2017, 4:52 PM · Maniphest, EditEngine
epriestley added a comment to T12378: "This task has been locked" on all logged out tasks.

Thanks for catching this, and for the clear reproduction steps.

Mar 9 2017, 4:52 PM · Maniphest, EditEngine
epriestley closed T12378: "This task has been locked" on all logged out tasks as Resolved by committing Restricted Diffusion Commit.
Mar 9 2017, 4:51 PM · Maniphest, EditEngine
epriestley added a revision to T12378: "This task has been locked" on all logged out tasks: Unknown Object (Differential Revision).
Mar 9 2017, 4:46 PM · Maniphest, EditEngine
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I have no idea either. We need reproduction steps. Reinstalling will not resolve this.

Mar 9 2017, 4:44 PM · Bug Report, EditEngine
epriestley added a comment to T12373: Support macros in Phame.

That is, the problem would be:

Mar 9 2017, 3:37 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

I guess we actually have to test this use case:

Mar 9 2017, 3:36 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

https://secure.phabricator.com/source/phabricator/browse/master/src/infrastructure/markup/PhabricatorMarkupEngine.php;4c7d464f8bf2627ef7455596fde2ae5667e67a57$356

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
epriestley updated subscribers of T12373: Support macros in Phame.

Macros are disabled in Phame posts, via markup engine. This originated in D2202.

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
epriestley claimed T12378: "This task has been locked" on all logged out tasks.

I think the way the view gets built is a little odd and I didn't get the logic quite right. Definitely a bug, thanks.

Mar 9 2017, 3:16 PM · Maniphest, EditEngine

Mar 8 2017

epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

The general headers/sections are mostly scripted now so they should be fairly consistent, but I'm still editing the actual markup at the end of the day.

Mar 8 2017, 11:04 PM · Restricted Project, Restricted Project, Audit
epriestley updated the task description for T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:57 PM · Restricted Project, Audit, Differential
epriestley updated the task description for T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:57 PM · Restricted Project, Audit, Differential
epriestley created T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:56 PM · Restricted Project, Audit, Differential
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

I think we currently get about equal amounts of "your changelogs should be more detailed" and "your changelogs have too much irrelevant stuff" feedback so I'll take that feedback under consideration but don't plan to make changes unless the overall balance of feedback shifts substantially in one direction.

Mar 8 2017, 10:55 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

We support viewerprojects() elsewhere but it isn't currently a component of the "Auditors" datasource. See also T9362#207080. I'll file a version of T9362 for the "Auditors" field.

Mar 8 2017, 10:49 PM · Restricted Project, Restricted Project, Audit
epriestley added a project to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?: KDE.
Mar 8 2017, 6:36 PM · KDE, Feature Request (Needs Information)
epriestley merged T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? into T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 8 2017, 6:36 PM · KDE, Restricted Project, Diffusion, Differential
epriestley merged task T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? into T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 8 2017, 6:36 PM · KDE, Feature Request (Needs Information)
epriestley updated subscribers of T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

I'm going to merge this into T5029. This is an extremely low priority for this upstream because this workflow is virtually unheard of among full-time software development professionals (see "Target Audience" in Contributing Feature Requests) because it is inherently error-prone.

Mar 8 2017, 6:35 PM · KDE, Feature Request (Needs Information)
epriestley added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

How do you make guarantee that unrelated, simultaneous, uncommitted changes in the same working copy do not interfere with each other?

Mar 8 2017, 5:18 PM · KDE, Feature Request (Needs Information)
Croakx awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 8 2017, 2:44 PM · Workboards (v3), Restricted Project
joshuaspence awarded T12270: Unbeta Badges a Like token.
Mar 8 2017, 5:13 AM · Badges (v0)
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

I haven't been able to reproduce this locally by artificially making services unavailable or connections fail. Debugging this in production will require momentary service interruptions on admin until I can narrow things down so I'm going to wait until off-peak to poke at it.

Mar 8 2017, 12:00 AM · Phacility, Daemons, Ops

Mar 7 2017

epriestley added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

There isn't enough information here for us to reproduce this, or even begin.

Mar 7 2017, 4:12 PM · Daemons, Bug Report

Mar 6 2017

epriestley closed T12359: Registration does not accept valid email addresses as Wontfix.

You can adjust the validation here:

Mar 6 2017, 8:24 PM · Bug Report
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

I think that's right, yes.

Mar 6 2017, 5:28 PM · Installing & Upgrading, Differential
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

Users do count, but I thiiiiiink user mentions are a special kind of mention because they have more complicated rules and you can't read them with edge.search today. T4654 discusses better rules around "notify me when I'm mentioned"; there are some related Conpherence-specific tasks too.

Mar 6 2017, 5:23 PM · Feature Request
epriestley closed T12358: Not secure generating as Invalid.

Sometimes, Apache is configured with a rule which prevents any access to any URL which contains /..

Mar 6 2017, 5:15 PM · Bug Report

Mar 5 2017

epriestley accepted D17468: Remove the the duplicate words.

courageous 🎆

Mar 5 2017, 6:12 PM
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I dropped the cache, looks like they're working.

Mar 5 2017, 5:01 PM · Feature Request, People
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

Specifically, I suspect it won't affect repo because db restarts separately, so the database won't be unavailable when daemons on repo restart.

Mar 5 2017, 12:32 PM · Phacility, Daemons, Ops
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

It looks like this might be an issue with MySQL not being available yet when the daemons start. The deployment script restarts MySQL, then immediately restarts the daemons, and a bunch of this stuff is ending up in the log in the 1-2 seconds after the restart:

Mar 5 2017, 12:32 PM · Phacility, Daemons, Ops
epriestley added a project to T12355: Daemons are having a rough time starting on `admin`: Phacility.
Mar 5 2017, 12:24 PM · Phacility, Daemons, Ops
epriestley created T12355: Daemons are having a rough time starting on `admin`.
Mar 5 2017, 12:24 PM · Phacility, Daemons, Ops
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

I believe that's unavoidable with offset-based paging (the solution is to switch to cursor-based paging, but I think we can't do that for fulltext).

Mar 5 2017, 12:18 PM · Elasticsearch, Wikimedia, Search
epriestley edited the content of 2017 Week 9 (Early March).
Mar 5 2017, 2:34 AM
joshuaspence edited the content of 2017 Week 9 (Early March).
Mar 5 2017, 2:24 AM
epriestley added a comment to T10319: Generate unique? profile images for each new user.

🍞 🐦

Mar 5 2017, 12:30 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

fancy 👑

Mar 5 2017, 12:30 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think bin/cache purge --purge-user will do it (but for every user). There's no way to do it for just one user, I don't think.

Mar 5 2017, 12:22 AM · Feature Request, People
epriestley edited the content of Changelog.
Mar 5 2017, 12:19 AM
epriestley created 2017 Week 9 (Early March).
Mar 5 2017, 12:18 AM
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

I've implemented a new edge.search API method. This method generally works similarly to other *.search API methods:

Mar 5 2017, 12:04 AM · Feature Request

Mar 4 2017

epriestley added a revision to T12337: Provide conduit access to related tasks and in particular 'mentions': Unknown Object (Differential Revision).
Mar 4 2017, 11:25 PM · Feature Request
epriestley added a comment to T12351: diviner generate book failed.

This should now be fixed in HEAD of master. Thanks for the report!

Mar 4 2017, 6:27 PM · Bug Report
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Mar 4 2017, 6:11 PM · Phage, Infrastructure
epriestley closed T12351: diviner generate book failed as Resolved by committing Restricted Diffusion Commit.
Mar 4 2017, 5:54 PM · Bug Report
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Mar 4 2017, 5:54 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T12337: Provide conduit access to related tasks and in particular 'mentions': Unknown Object (Differential Revision).
Mar 4 2017, 5:53 PM · Feature Request
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Unknown Object (Differential Revision).
Mar 4 2017, 4:07 PM · Maniphest, Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

Here's the intended behavior from the source:

Mar 4 2017, 3:28 PM · Feature Request
epriestley added a revision to T12351: diviner generate book failed: Unknown Object (Differential Revision).
Mar 4 2017, 3:17 PM · Bug Report
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

The build system should be able to call Phabricator via Conduit and ask for revision status today if you want a short-term fix.

Mar 4 2017, 3:13 PM · Feature Request
epriestley added a comment to T12349: The language stanza in a code block shouldn't be indexed..

Hrrm, it looks like my reply to your email bounced. Short answer is that we don't offer anything special for academic or open source right now. We'd like to in the future, but are focusing on building our core business first.

Mar 4 2017, 12:10 PM · Bug Report
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

(That is, the expected failure mode of this query when it fails to scale is "silently return an incomplete result set", not "be really slow".)

Mar 4 2017, 11:51 AM · Elasticsearch, Wikimedia, Search
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

To start with here, let's identify exactly what's slow? It's not clear to me from the downstream task unless I'm just misreading, and not evident to me from reasoning about the behavior of this query. This query strategy is fundamentally not scalable, but I would not expect it to be slow unless the ElasticSearch query is slow.

Mar 4 2017, 11:48 AM · Elasticsearch, Wikimedia, Search
epriestley closed T12354: testing as Invalid.
Mar 4 2017, 11:43 AM · Feature Request
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

The results are ordered by "match strength", but this is computed at runtime and isn't unique to each result: we can't start with the 100th result and use it to build any sort of clause like WHERE rank > 12345 that starts on the 101st result.

Mar 4 2017, 11:34 AM · Elasticsearch, Wikimedia, Search
epriestley closed T12352: Table of conent should be visible in beginning of the page as Invalid.

Sorry, this isn't a feature request we can accept. See Support Resources for help understanding what kind of support is available, and Contributing Feature Requests for help with feature requests.

Mar 4 2017, 11:11 AM · Phriction, Feature Request
epriestley merged T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald into T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Mar 4 2017, 11:10 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley merged task T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald into T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Mar 4 2017, 11:10 AM · Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

See T10109. I'm going to merge this into T2543.

Mar 4 2017, 11:10 AM · Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

You've personally observed a build trigger as the result of a user choosing "Plan Changes"?

Mar 4 2017, 4:48 AM · Feature Request
epriestley closed T12349: The language stanza in a code block shouldn't be indexed. as Wontfix.

The document contains "bash". This behavior seems correct to me.

Mar 4 2017, 3:53 AM · Bug Report
groenroos awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 4 2017, 3:30 AM · Workboards (v3), Restricted Project

Mar 3 2017

epriestley added a revision to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed"): Unknown Object (Differential Revision).
Mar 3 2017, 10:22 PM · Guides, Security
epriestley added a comment to T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'.".

This should be resolved at HEAD of master, thanks for the report!

Mar 3 2017, 9:45 PM · EditEngine, Bug Report
epriestley closed T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'." as Resolved by committing Restricted Diffusion Commit.
Mar 3 2017, 9:44 PM · EditEngine, Bug Report
epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): Unknown Object (Differential Revision).
Mar 3 2017, 9:43 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a revision to T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'.": Unknown Object (Differential Revision).
Mar 3 2017, 9:43 PM · EditEngine, Bug Report
epriestley added a comment to T10319: Generate unique? profile images for each new user.

Something like:

Mar 3 2017, 7:37 PM · Feature Request, People
epriestley closed T12346: `repository list-paths` reports non-existing path as Resolved.
Mar 3 2017, 4:38 PM · Bug Report
epriestley merged T12345: Links in titles into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Mar 3 2017, 1:24 PM · libphutil, Remarkup
epriestley merged task T12345: Links in titles into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Mar 3 2017, 1:24 PM · Phriction, Bug Report
epriestley added a comment to T12335: Ability to lock a task to prevent further edits.

We've implemented a basic version of this, roughly along the lines of the recommendation above. Here's how it works:

Mar 3 2017, 1:23 AM · Maniphest, Feature Request
epriestley closed T11207: User can change properties on the task, even when not having edit policy rights as Resolved by committing Restricted Diffusion Commit.
Mar 3 2017, 12:57 AM · Restricted Project, Policy, Bug Report

Mar 2 2017

epriestley added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

(I think I've used this workflow fewer than 5 times outside of testing, and although similar workflows like "Award Badge" and "Add Project Members" have the same issue, I think they're similarly rare.)

Mar 2 2017, 9:49 PM · Feature Request (Needs Information)
epriestley added a comment to T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown.

This is also nontrivial: when we display a dialog, we already attempt to focus the first input. But the first input here is a tokenizer, not a real input, and naively focusing it fails because it hasn't activated or rendered yet.

Mar 2 2017, 9:48 PM · Feature Request (Needs Information)