Page MenuHomePhabricator

Harbormaster build step "Make HTTP request" don't trim URL field
Closed, DuplicatePublic

Description

Reproduction steps:

  • Create a new harbormaster plan from Phabricator
  • Add a new "Make HTTP request" step, with an URL preceded by spaces (eg: http://www.google.fr)
  • Execute the plan

Expected result:

  • Spaces in the URL step field are trimmed at step creation.
  • The build get an HTTP response and success.

Actual result:

  • The build fails without explaination. The build log contains only one line: "HTTP 1"

Adding a "trim" on URL field will fix the bug, but I thinks the lack of message is also a problem on its own.


Tested on a recent version of phabricator:

  • phabricator c21a71f02489b53e5ec5c34deffc693950b69847 (Fri, Oct 21)
  • arcanist fad85844314b151994769a461825c90f7400c145 (Sat, Oct 22)
  • phutil f275bb3a363d8ef7e75426c99355efe281aa2c21 (Wed, Oct 19)

Event Timeline

I'm going to merge this into T10510, which discusses improving Harbormaster error behavior.

The actual behavior (respecting the URL you entered) is not a bug, but the error messaging can be improved.