Page MenuHomePhabricator
Feed Advanced Search

Aug 10 2015

epriestley triaged T5822: Implement garbage collection / automatic archiving for Harbormaster logs as Normal priority.
Aug 10 2015, 2:20 PM · Harbormaster, Restricted Project
epriestley moved T5822: Implement garbage collection / automatic archiving for Harbormaster logs from v1 to v2 on the Harbormaster board.
Aug 10 2015, 2:19 PM · Harbormaster, Restricted Project
epriestley added a subtask for T5822: Implement garbage collection / automatic archiving for Harbormaster logs: T9124: Support uploading build log data via the Harbormaster API.
Aug 10 2015, 2:19 PM · Harbormaster, Restricted Project
epriestley added a parent task for T9124: Support uploading build log data via the Harbormaster API: T5822: Implement garbage collection / automatic archiving for Harbormaster logs.
Aug 10 2015, 2:19 PM · Restricted Project, Harbormaster
epriestley moved T9124: Support uploading build log data via the Harbormaster API from Backlog to v2 on the Harbormaster board.
Aug 10 2015, 2:18 PM · Restricted Project, Harbormaster
epriestley closed T5920: Support grey-area results ("unstable" builds, "non-critical" builds) in Harbormaster, a subtask of T8097: Allow external systems to report results into Harbormaster, as Resolved.
Aug 10 2015, 2:17 PM · Harbormaster
epriestley closed T5920: Support grey-area results ("unstable" builds, "non-critical" builds) in Harbormaster as Resolved.

There's nothing specifically actionable here so I'm going to close this. We'll probably expand states in the future, but I think many/most/all of these cases only differ in what they're labeled, and not in the actions the system takes as a result.

Aug 10 2015, 2:17 PM · Harbormaster
epriestley moved T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted from v1 to v2 on the Harbormaster board.
Aug 10 2015, 1:51 PM · Restricted Project, Harbormaster
epriestley renamed T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted from Allow Harbormaster build failures to provide a reason to Allow designation of "summary" build logs which are sorted to the top or otherwise promoted.
Aug 10 2015, 1:51 PM · Restricted Project, Harbormaster
epriestley added a parent task for T9124: Support uploading build log data via the Harbormaster API: T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted.
Aug 10 2015, 1:50 PM · Restricted Project, Harbormaster
epriestley added a subtask for T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted: T9124: Support uploading build log data via the Harbormaster API.
Aug 10 2015, 1:50 PM · Restricted Project, Harbormaster
epriestley added a comment to T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted.

I don't think this is meaningfully distinguishable from logs. There's no reason a target can't fail for multiple reasons, there may be other non-failure data targets wish to log, this data essentially has to be text which we can't understand or do anything special with and I don't think it makes sense for us to do anything about it anyway.

Aug 10 2015, 1:50 PM · Restricted Project, Harbormaster
epriestley removed a subtask for T8097: Allow external systems to report results into Harbormaster: T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted.
Aug 10 2015, 1:47 PM · Harbormaster
epriestley removed a parent task for T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted: T8097: Allow external systems to report results into Harbormaster.
Aug 10 2015, 1:47 PM · Restricted Project, Harbormaster
epriestley created T9124: Support uploading build log data via the Harbormaster API.
Aug 10 2015, 1:46 PM · Restricted Project, Harbormaster
epriestley created T9123: Build Phabricator in Harbormaster (v2).
Aug 10 2015, 1:36 PM · Prioritized, Harbormaster
epriestley added a comment to T9122: Translatable Maniphest Task Priorities.

I'd still like to wait for someone to hit the, e.g., Russian + Spanish problem in case more complications arise between now and then, but that allow-a-map solution seems relatively upstreamable to me when we do.

Aug 10 2015, 10:50 AM · Maniphest
epriestley added a comment to T9122: Translatable Maniphest Task Priorities.

I suppose we could do something like this, hypothetically:

Aug 10 2015, 10:47 AM · Maniphest
epriestley added a comment to T9122: Translatable Maniphest Task Priorities.

That will technically work as a local patch, it just isn't extractable by translation tools.

Aug 10 2015, 10:41 AM · Maniphest
joshuaspence added a revision to T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results: Unknown Object (Differential Revision).
Aug 10 2015, 10:06 AM · Lint
epriestley added a comment to T9122: Translatable Maniphest Task Priorities.

This isn't currently possible.

Aug 10 2015, 9:54 AM · Maniphest
epriestley closed T9121: documentation on how to add a new field to Differential as Resolved.

https://secure.phabricator.com/book/phabricator/article/custom_fields/

Aug 10 2015, 9:33 AM · Documentation, Custom Fields, Differential

Aug 9 2015

epriestley closed T8981: test svn repo doesn't work as Resolved.

This should be fixed now (see rSVNTEST1).

Aug 9 2015, 4:58 PM · Subversion
joshuaspence added a comment to T9100: Linter autofix produces a syntax error.

See http://www.phpwtf.org/poor-parser-easily-confused

Aug 9 2015, 7:37 AM · Lint
epriestley added a comment to T8428: Allow packages to be disabled.

Yeah, you should be good to go -- I don't think there are any surprises here. The old code just nuked the actual data since it was written in like 1950.

Aug 9 2015, 4:33 AM · Owners
epriestley closed T8921: arc diff failing due to "invalid type" error as Resolved.

Presuming this is fixed for real now, let us know if you're still seeing any issues.

Aug 9 2015, 4:31 AM · Arcanist
epriestley added a comment to T8556: Pastes index fails to load..

(I did fix a couple of similar things a while ago, so it seems reasonable that this may be resolved at HEAD.)

Aug 9 2015, 4:29 AM · Paste
epriestley added a comment to T8556: Pastes index fails to load..

Oh! Sorry, ignore me.

Aug 9 2015, 4:28 AM · Paste
epriestley added a comment to T8556: Pastes index fails to load..

Yeah, you're about two months out of date. Does updating fix the issue? See:

Aug 9 2015, 4:26 AM · Paste
epriestley added a comment to T8973: Encoding JSON for presentation could use more human-friendly escaping rules.

The specific UI (Phacility → Instances → (Choose an Instance) → Adjust Configuration) in question doesn't actually use PhutilJSON to format the output right now, so it's still rendering the less-preferred form:

Aug 9 2015, 4:25 AM · Customer Impact
epriestley closed T9109: How to integrate Arcanist with less granular build systems as Wontfix.

I guess you can conceivably use some static property somewhere to coordinate a lint engine and unit test engine in a hacky-but-functional way.

Aug 9 2015, 4:22 AM · Arcanist
epriestley added a comment to T9108: Don't die horribly when large commit is pushed.

Generally, since we don't have access to your hosts or to any monitoring or logs, we're relatively powerless to help you resolve operational issues which can't be directly reproduced and which other installs don't experience. We can chip away at this stuff, but there's a lot of fishing involved and progress may be extremely slow (T8588 is a similar issue, where we've gone through multiple rounds of investigation and back-and-forth without truly making much real progress).

Aug 9 2015, 3:56 AM · Diffusion, Restricted Project
epriestley added a comment to T9108: Don't die horribly when large commit is pushed.

Do you have any more specific details about what happens here?

Aug 9 2015, 3:36 AM · Diffusion, Restricted Project
epriestley added a comment to T9116: Shell completion doesn't work for filenames containing a space.

This is at least somewhat our fault, behavior on nano foo<tab> is different from arc upload foo<tab>. There's probably some shell-specific magic in there too, of course...

Aug 9 2015, 3:27 AM · Restricted Project, Arcanist
epriestley added a comment to T5542: Allow individual Harbormaster targets to be restarted.

Realistically, your use case is just way outside what Harbormaster is targeting or what I consider reasonable for a general-purpose build system to have in its core set of capabilities. It is not going to support these sorts of things for a very long time (years and years).

Aug 9 2015, 3:15 AM · Harbormaster
epriestley added a comment to T5542: Allow individual Harbormaster targets to be restarted.

If the artifact is literally a binary on disk on that server, and you want to be able to restart part of the build from after that binary is built, I think we have no choice?

Aug 9 2015, 12:30 AM · Harbormaster
joshuaspence created T9116: Shell completion doesn't work for filenames containing a space.
Aug 9 2015, 12:16 AM · Restricted Project, Arcanist

Aug 8 2015

epriestley added a comment to T9112: Timestamp is not shown on mobile.

(I'm generally not huge on content source being especially useful anywhere, but it's occasionally nice to have for debugging, especially for Conduit/Daemons content sources..)

Aug 8 2015, 9:57 PM · Conpherence
epriestley added a comment to T9112: Timestamp is not shown on mobile.

Or do you mean exposing it in the UI? I don't think it's too useful, but it might be helpful to see if someone is mobile vs web, maaaybe? We could put an icon on their picture or something though. I think all other cases of content source don't matter.

Aug 8 2015, 9:56 PM · Conpherence
epriestley added a comment to T9112: Timestamp is not shown on mobile.

It's just on the transactions, right? Not rooms?

Aug 8 2015, 9:55 PM · Conpherence
epriestley added a comment to T5542: Allow individual Harbormaster targets to be restarted.

I tend to agree, mostly, but I think D9807's global-namespace-on-artifacts thing isn't the best approach.

Aug 8 2015, 7:32 PM · Harbormaster
epriestley removed a project from T6553: Support for static code analysis: Harbormaster.
Aug 8 2015, 7:20 PM
epriestley moved T5515: Support estimation of time remaining and progress indicator based on previous builds from Backlog to Future on the Harbormaster board.
Aug 8 2015, 7:18 PM · Restricted Project, Harbormaster
epriestley triaged T5515: Support estimation of time remaining and progress indicator based on previous builds as Wishlist priority.
Aug 8 2015, 7:18 PM · Restricted Project, Harbormaster
epriestley closed T4591: Allow Harbormaster to source GitHub pull requests as buildables as Wontfix.

I'm just going to close this in favor of T8783. If we build this it would happen via Nuance importing pulls as revisions, not Harbormaster being specifically aware of GitHub pull requests as a buildable, at least in the upstream. You're welcome to do something third-party and implement BuildableInterface on it, which might be a plausible approach, but isn't something I'd want to do in the upstream.

Aug 8 2015, 7:16 PM · Harbormaster
epriestley closed T1049: Implement Harbormaster as Resolved.

Harbormaster is now unprototyped. See T8089 for more focused/modern discussion.

Aug 8 2015, 7:14 PM · Harbormaster
epriestley closed T1049: Implement Harbormaster, a subtask of T5479: Unbeta Phragment, as Resolved.
Aug 8 2015, 7:14 PM · Phragment
epriestley closed T1049: Implement Harbormaster, a subtask of T4591: Allow Harbormaster to source GitHub pull requests as buildables, as Resolved.
Aug 8 2015, 7:14 PM · Harbormaster
epriestley closed T1049: Implement Harbormaster, a subtask of T7419: Provide a straightforward way to create and update CI test statuses for a revision, as Resolved.
Aug 8 2015, 7:14 PM · Differential, Harbormaster
epriestley closed T1049: Implement Harbormaster, a subtask of T7869: Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously), as Resolved.
Aug 8 2015, 7:14 PM · Phacility
epriestley closed T8457: harbormaster.sendmessage return with invalid type is a bit too terse as Wontfix.

We currently allow any message, we just don't do anything with messages we don't understand. Possibly this should be made more strict, but I imagine accepting any message and possibly letting extensions handle them in the future. We might not be able to figure out if anything will accept a message or not when we receive it.

Aug 8 2015, 7:11 PM · Conduit, Harbormaster
epriestley requested changes to D13421: Prevent rapid AWS calls being made due to SSH test returning quickly.

(under certain, unknown conditions).

Aug 8 2015, 6:55 PM
epriestley edited the content of Changelog.
Aug 8 2015, 2:59 PM
epriestley created 2015 Week 32 (Mid August).
Aug 8 2015, 2:59 PM
epriestley added a comment to T8090: Allow Harbormaster to perform change handoff in a defensible way.

then it is totally invisible to the reviewer that the patch relies on X()

Aug 8 2015, 2:37 PM · Haskell.org, Restricted Project, Harbormaster
epriestley added a comment to T8090: Allow Harbormaster to perform change handoff in a defensible way.

When merged, it took with it all changes between bB and bA into bA.

Aug 8 2015, 2:13 PM · Haskell.org, Restricted Project, Harbormaster
epriestley added a comment to T8090: Allow Harbormaster to perform change handoff in a defensible way.

I want every change to the code based to be explicitly accepted before it's landed.

Aug 8 2015, 2:03 PM · Haskell.org, Restricted Project, Harbormaster
joshuaspence added a comment to T9109: How to integrate Arcanist with less granular build systems.

You would be better off setting up the linters / unit tests through arc, and then making gradle run arc lint and arc unit as part of it's process.

Aug 8 2015, 11:51 AM · Arcanist
joshuaspence added a comment to T9112: Timestamp is not shown on mobile.

Screenshot_2015-08-08-20-45-23.png (1×1 px, 231 KB)

Aug 8 2015, 10:46 AM · Conpherence
joshuaspence created T9112: Timestamp is not shown on mobile.
Aug 8 2015, 10:44 AM · Conpherence
epriestley closed T9110: arc diff should have an option to update the title and summary as Resolved.

The fields that are updated depend on the server configuration, which is why they aren't enumerated in the help.

Aug 8 2015, 12:09 AM · Differential, Restricted Project

Aug 7 2015

epriestley added a comment to T9110: arc diff should have an option to update the title and summary.

T2543 is also likely to add a formal "wip/draft" state soon for "this isn't ready for review yet, but I want to share/get comments on it".

Aug 7 2015, 11:52 PM · Differential, Restricted Project
epriestley added a comment to T9110: arc diff should have an option to update the title and summary.
$ arc help diff
...
          --edit
              Supports: git, hg
              When updating a revision under git, edit revision information
              before updating.
...
          --verbatim
              Supports: hg, git
              When creating a revision, try to use the working copy commit
              message verbatim, without prompting to edit it. When updating a
              revision, update some fields from the local commit message.
...
Aug 7 2015, 11:51 PM · Differential, Restricted Project
joshuaspence added a comment to T9109: How to integrate Arcanist with less granular build systems.
Aug 7 2015, 11:11 PM · Arcanist
joshuaspence added a comment to T9109: How to integrate Arcanist with less granular build systems.

Essentially, the issue here is that tools such as gradledont have any east way to run linters/tests on a subset of the code base. It's possible to write a linter which wraps around ./gradlew check but this means that arc lint -- file takes the same amount of time and resources as arc lint --everything .

Aug 7 2015, 11:11 PM · Arcanist
epriestley added a comment to T9106: mailing list users should have their emails displayed on the user page.

Why do you care about this information?

Aug 7 2015, 7:46 PM · People
nateguchi2 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Aug 7 2015, 6:35 PM · Workboards (v3), Restricted Project
epriestley deleted Metamta.
Aug 7 2015, 4:00 PM
epriestley deleted "><img src=x onerror=prompt(1)>.
Aug 7 2015, 4:00 PM
• sshannin awarded T7924: Unprototype Calendar (v1) a Mountain of Wealth token.
Aug 7 2015, 3:55 PM · Restricted Project, Prioritized, Calendar
joshuaspence created T9104: "Find Owners" link 404s.
Aug 7 2015, 1:55 PM · Owners, Diffusion
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Aug 7 2015, 12:25 PM · Harbormaster
epriestley added a comment to T9098: Implement Default Edit Answer capability.

This is something I've been thinking a little bit about recently, too, although I don't have many ideas or much of a plan yet.

Aug 7 2015, 11:49 AM · Ponder
joshuaspence claimed T9100: Linter autofix produces a syntax error.
Aug 7 2015, 7:00 AM · Lint
joshuaspence added a revision to T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results: Unknown Object (Differential Revision).
Aug 7 2015, 4:21 AM · Lint
joshuaspence added a revision to T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results: Unknown Object (Differential Revision).
Aug 7 2015, 3:59 AM · Lint
joshuaspence updated the task description for T9100: Linter autofix produces a syntax error.
Aug 7 2015, 3:55 AM · Lint
joshuaspence updated the task description for T9100: Linter autofix produces a syntax error.
Aug 7 2015, 3:27 AM · Lint
joshuaspence created T9100: Linter autofix produces a syntax error.
Aug 7 2015, 3:25 AM · Lint
epriestley added a comment to T9067: phabricator daemon fails when updating repository (possibly due to attempting to email a user without access).

Are people supposed to be able to see the repo if they are not in the project but in the space?

Aug 7 2015, 1:40 AM · Herald, Differential, Daemons

Aug 6 2015

epriestley added a comment to T9092: Allow setting a default view and edit policy for Phriction.

The default policy for x/y/ is inherited from x/. The expectation is that this is always the correct default. What's your use case where this isn't the correct default?

Aug 6 2015, 10:23 PM · Policy, Phriction
epriestley added a comment to T9093: Add a "Can Create" policy for Phriction.

You have to be able to edit x/ to create x/y/. The UX is kind of junk, but I think this does technically work. Is that sufficient?

Aug 6 2015, 10:22 PM · Phriction, Policy
joshuaspence created T9093: Add a "Can Create" policy for Phriction.
Aug 6 2015, 9:43 PM · Phriction, Policy
joshuaspence created T9092: Allow setting a default view and edit policy for Phriction.
Aug 6 2015, 9:42 PM · Policy, Phriction
epriestley merged task T7794: Differential revision list "draft notification" bubble should ignore deleted drafts into T8917: Diff says it has unsubmitted comments, but I can't find them.
Aug 6 2015, 6:55 PM · Differential, Audit
epriestley updated subscribers of T8917: Diff says it has unsubmitted comments, but I can't find them.
Aug 6 2015, 6:55 PM · Differential
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

(This command may take a while to run since I was extremely lazy about loading the data.)

Aug 6 2015, 6:40 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

We don't actually store the outcome of preference filtering at the time we sent the mail right now (we will after T5791) so I can only report an "Unfiltered" column, which is the maximum number of messages we may have sent (I could do a little better than this now, but it's probably better to hold it until T5791 for a more complete picture). Users with any settings which disable mail will have received less mail than the "unfiltered" number.

Aug 6 2015, 6:32 PM · Aphlict, Conpherence
epriestley added a revision to T7013: Support bulk transmission of notification frames in internal Aphlict protocol: Unknown Object (Differential Revision).
Aug 6 2015, 6:29 PM · Aphlict, Conpherence
epriestley closed T8097: Allow external systems to report results into Harbormaster as Resolved.

This could be more flexible (there's no real way to report logs or artifacts yet) but lint/unit work fine. We'll expand these capabilities in the future.

Aug 6 2015, 5:26 PM · Harbormaster
epriestley closed T8097: Allow external systems to report results into Harbormaster, a subtask of T8089: Unprototype Harbormaster (v1), as Resolved.
Aug 6 2015, 5:26 PM · Prioritized, Harbormaster
epriestley removed a parent task for T5822: Implement garbage collection / automatic archiving for Harbormaster logs: T8097: Allow external systems to report results into Harbormaster.
Aug 6 2015, 5:25 PM · Harbormaster, Restricted Project
epriestley removed a subtask for T8097: Allow external systems to report results into Harbormaster: T5822: Implement garbage collection / automatic archiving for Harbormaster logs.
Aug 6 2015, 5:25 PM · Harbormaster
epriestley closed T5854: User reporting Herald claims it triggered a build plan, but buildable and plan are nowhere to be found, a subtask of T8096: Improve Harbormaster UI/UX (v1), as Wontfix.
Aug 6 2015, 5:24 PM · Harbormaster
epriestley closed T5854: User reporting Herald claims it triggered a build plan, but buildable and plan are nowhere to be found as Wontfix.

This report is about a year old, things have changed a lot, and I haven't seen other reports and can't immediately reproduce it.

Aug 6 2015, 5:24 PM · Herald, Harbormaster
epriestley closed T5058: Improve diagnostics around waiting targets in Harbormaster as Wontfix.

This has changed a bunch and I haven't experienced any difficulty with it in the last year or so.

Aug 6 2015, 5:23 PM · Harbormaster
epriestley closed T5058: Improve diagnostics around waiting targets in Harbormaster, a subtask of T8096: Improve Harbormaster UI/UX (v1), as Wontfix.
Aug 6 2015, 5:23 PM · Harbormaster
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Well, no level other than 0.

Aug 6 2015, 5:21 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Yeah -- we can pursue that stuff, but I'm strongly suspicious that user complaints about mail volume aren't meaningfully correlated to actual mail volume and that there is no level we can drive it down to which will meaningfully reduce user frustration.

Aug 6 2015, 5:19 PM · Aphlict, Conpherence
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

And I generally agree about dependencies and externals getting ignored for now, but I'd like to assume we'll eventually support both and plan around that.

Aug 6 2015, 5:17 PM · Arcanist