I wonder if when I mark a bunch as "Done" but clear them with a new diff upload, if the diff still thinks I have unsubmitted comments.
Description
Revisions and Commits
Related Objects
- Duplicates Merged Here
- T7794: Differential revision list "draft notification" bubble should ignore deleted drafts
Event Timeline
It looks like you have an unsubmitted inline on line 70 of PhabricatorBadgesRemoveRecipientsController.php with this text:
I should note I can't upload files on my install, some PHP Deprecated error I need to put in my ini file. I think I have a task. I'll see if fixing that resolves this, but unclear why it needs to write a file?
Is that consistent with your UI?
Note that this comment is on an earlier diff.
Specifically, I would expect the comment to appear in the preview at the bottom of the page, but not be visible inline in the diff itself.
(or posting, I tried just submitting and it wouldn't let me)
Can you clarify what you experienced? Did you get an error message?
For my own reference:
mysql> SELECT phid FROM differential_revision WHERE id = 13626; +--------------------------------+ | phid | +--------------------------------+ | PHID-DREV-mejvngkydfi2imdzcyig | +--------------------------------+ 1 row in set (0.00 sec)
mysql> SELECT phid FROM secure_user.user WHERE username = 'chad'; +--------------------------------+ | phid | +--------------------------------+ | PHID-USER-nbueerxdfl6csylnv6oe | +--------------------------------+ 1 row in set (0.00 sec)
mysql> SELECT * FROM differential_draft WHERE objectPHID = 'PHID-DREV-mejvngkydfi2imdzcyig'\G *************************** 1. row *************************** id: 315073 objectPHID: PHID-DREV-mejvngkydfi2imdzcyig authorPHID: PHID-USER-nbueerxdfl6csylnv6oe draftKey: PHID-XCMT-e55fvrrtaqljhw5hxx64 dateCreated: 1437087955 dateModified: 1437087955 1 row in set (0.00 sec)
mysql> SELECT * FROM differential_transaction_comment WHERE phid = 'PHID-XCMT-e55fvrrtaqljhw5hxx64'\G *************************** 1. row *************************** id: 46942 phid: PHID-XCMT-e55fvrrtaqljhw5hxx64 transactionPHID: NULL authorPHID: PHID-USER-nbueerxdfl6csylnv6oe viewPolicy: public editPolicy: PHID-USER-nbueerxdfl6csylnv6oe commentVersion: 1 content: I should note I can't upload files on my install, some PHP Deprecated error I need to put in my ini file. I think I have a task. I'll see if fixing that resolves this, but unclear why it needs to write a file? contentSource: {"source":"legacy","params":[]} isDeleted: 1 dateCreated: 1437087955 dateModified: 1437088605 revisionPHID: PHID-DREV-mejvngkydfi2imdzcyig changesetID: 234338 isNewFile: 1 lineNumber: 70 lineLength: 0 fixedState: NULL hasReplies: 0 replyToCommentPHID: PHID-XCMT-oxz3yqyfhfprg7qzzv65 1 row in set (0.00 sec)
I missed that the comment is isDeleted, so this might be a bad interaction between the draft code and comment deletion.
Repro instructions are:
- Write an inline comment.
- Use the "Delete" action (not Edit -> Clear text -> Save) to delete it.
- Draft icon incorrectly persists.
That change doesn't fix things retroactively. I can delete draft 315073 if you really don't like that specific bubble.