Page MenuHomePhabricator
Feed Advanced Search

Jul 7 2015

epriestley added a comment to T8786: Add support for custom fields per project.

Phabricator does not support per-project fields, and we have no plans to add them at this time.

Jul 7 2015, 9:44 PM · Projects, Custom Fields
epriestley added a comment to T8096: Improve Harbormaster UI/UX (v1).

Per T8744 and elsewhere, the "Synthetic Inlines" for lint and Differential coverage both still need to be switched to read from Harbormaster sources.

Jul 7 2015, 9:12 PM · Harbormaster
epriestley updated subscribers of T3670: Add subprojects.
Jul 7 2015, 9:04 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley merged task T8786: Add support for custom fields per project into T3670: Add subprojects.
Jul 7 2015, 9:04 PM · Projects, Custom Fields
epriestley added a comment to T8785: Typo in copy on phabricator.org.

Thanks! This is now deployed.

Jul 7 2015, 8:47 PM · Public & Media Relations
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

niice

Jul 7 2015, 8:22 PM · Chad's House
epriestley added a revision to T8780: Exception, Cursor "1" does not identify a valid object: Unknown Object (Differential Revision).
Jul 7 2015, 8:19 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Aha! I think I figured it out.

Jul 7 2015, 8:14 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

SELECT * FROM phabricator_almanac.almanac_service;

Jul 7 2015, 8:12 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Show me the row?

Jul 7 2015, 8:12 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

My theory here is that your services table is kinda messed up, but I'm having a hard time coming up with a clean way to fix this in the general case. I think I'm just going to soften the failure here for now, unless that query produces surprises.

Jul 7 2015, 8:10 PM · Chad's House
epriestley added a comment to T7338: Build more status tools for monitoring Phacility cluster health.

From T8781, monitoring instance daemon queue lengths would be particularly helpful in identifying at least 1-2 issues we've hit.

Jul 7 2015, 8:08 PM · Almanac, Phacility
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Do you have stuff in almanac_service?

Jul 7 2015, 8:00 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

You can also probably do this to get a meaningful stack trace, near line 410 of PhabricatorCursorPagedPolicyAwareQuery.php:

Jul 7 2015, 7:54 PM · Chad's House
epriestley added a revision to T8780: Exception, Cursor "1" does not identify a valid object: Unknown Object (Differential Revision).
Jul 7 2015, 7:51 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Actually, I guess we can't check the environment that early to see if the setting is set. Let me just start by tailoring the error message, and maybe that'll give me enough to go on that I can figure it out.

Jul 7 2015, 7:49 PM · Chad's House
epriestley updated the task description for T8783: Unprototype Nuance (v1).
Jul 7 2015, 7:48 PM · Nuance, Restricted Project
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Ah, okay. Let me fix that UI to respect developer mode so we can get a stack trace.

Jul 7 2015, 7:41 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Oh, sorry, I just mean the web UI itself -- I'd expect it to look like this if you have developer-mode enabled:

Jul 7 2015, 7:39 PM · Chad's House
epriestley added a comment to T8780: Exception, Cursor "1" does not identify a valid object.

Do you have a full stack trace? You might need to bin/config set phabricator.developer-mode 1 to get one, although presumably you're already in developer mode...

Jul 7 2015, 7:27 PM · Chad's House
epriestley closed T8774: Crash when viewing search with viewer() while logged out as Resolved by committing Restricted Diffusion Commit.
Jul 7 2015, 6:52 PM · ApplicationSearch
epriestley closed T8784: Error en factura as Invalid.
Jul 7 2015, 6:50 PM
epriestley closed T8781: Not receiving emails as Resolved.

This looks like it was primarily caused by operator error. I stopped some services on the paired repo host in order to recover db001 in connection with T8764 yesterday. This worked, and let me revive the host immediately rather than needing to restart it, but I then failed to completely restart services later.

Jul 7 2015, 6:47 PM · Phacility Support
epriestley created T8783: Unprototype Nuance (v1).
Jul 7 2015, 6:45 PM · Nuance, Restricted Project
epriestley changed the visibility for T7338: Build more status tools for monitoring Phacility cluster health.
Jul 7 2015, 6:32 PM · Almanac, Phacility
epriestley added a comment to T8781: Not receiving emails.

I think the immediate issue is now resolved, I'll look at this in more detail and post a followup a little later.

Jul 7 2015, 5:05 PM · Phacility Support
epriestley added a comment to T8781: Not receiving emails.

Looking into this now.

Jul 7 2015, 4:50 PM · Phacility Support
epriestley closed T8778: Test as Invalid.
Jul 7 2015, 3:25 PM
epriestley closed T6817: Token given feed entry's target link is not struck through and greyed out when the target is closed as Resolved.

Seems resolved in the example. This is not 100% completely perfect yet (there's still some cruft kicking around) but I think it has no user-facing impact anymore.

Jul 7 2015, 3:25 PM · Feed, Tokens
epriestley set the image for Ops to F595837: project.png.
Jul 7 2015, 3:24 PM
epriestley changed the visibility for Ops.
Jul 7 2015, 3:24 PM
epriestley updated subscribers of T8172: "Edit" button shouldn't be hidden in "Actions".
Jul 7 2015, 3:15 PM · FreeBSD, Restricted Project, Phriction
epriestley merged task T8779: Take "Edit" action out of "Actions" menu on wiki pages into dedicated button into T8172: "Edit" button shouldn't be hidden in "Actions".
Jul 7 2015, 3:15 PM · Phriction
epriestley closed T8777: Support sending creators of a task a "receipt" with a link to the task they just created as Invalid.

Oh, @chad is correct, I get this mail on this install.

Jul 7 2015, 2:27 PM · Mail, Herald, Maniphest
epriestley created T8778: Test.
Jul 7 2015, 2:25 PM
joshuaspence added a revision to T5568: Support `.arcunit`, similar to `.arclint`: Unknown Object (Differential Revision).
Jul 7 2015, 2:07 PM · Unit, Arcanist
epriestley closed T8776: Duplicate info in the feed as Wontfix.
Jul 7 2015, 1:33 PM · Feed
joshuaspence edited P1818 CustomTestEngine.php.
Jul 7 2015, 1:31 PM · Arcanist
epriestley triaged T8774: Crash when viewing search with viewer() while logged out as Normal priority.
Jul 7 2015, 12:56 PM · ApplicationSearch
epriestley added a revision to T8774: Crash when viewing search with viewer() while logged out: Unknown Object (Differential Revision).
Jul 7 2015, 12:55 PM · ApplicationSearch
epriestley closed T8772: test as Invalid.
Jul 7 2015, 12:46 PM
epriestley closed T8771: "/><svg/onload=prompt(1)> as Invalid.
Jul 7 2015, 12:46 PM · Space Test Users
epriestley closed T8773: "/><iframe/src=javascript:prompt(1)> as Invalid.
Jul 7 2015, 12:45 PM
epriestley claimed T8774: Crash when viewing search with viewer() while logged out.

Thanks.

Jul 7 2015, 12:45 PM · ApplicationSearch
epriestley closed T8775: Test Task as Invalid.
Jul 7 2015, 12:44 PM · Chad's House
epriestley added a comment to T7903: Conduit differential.query search by branches is broken.

No. If there was, it would be posted here.

Jul 7 2015, 12:41 PM · Restricted Project, Differential, Conduit
epriestley reopened T8762: Upgrade process should be more informative when unable to create new databases as "Open".

Thanks.

Jul 7 2015, 12:31 PM · Setup
epriestley closed T3949: Support mailto URI in Remarkup as Resolved.

However this is, as you already mentioned, rather useless, because clicking the link will not allow to send an email

Jul 7 2015, 12:31 PM · Remarkup
nemobis awarded T8549: Feedback on 2015 Redesign a Manufacturing Defect? token.
Jul 7 2015, 9:28 AM · Design
joshuaspence added a revision to T8760: Show progress when running long-running lint commands: Unknown Object (Differential Revision).
Jul 7 2015, 8:13 AM · Arcanist

Jul 6 2015

joshuaspence closed T8767: Destroyed credentials should render as strikethrough as Invalid.

Hmm, nevermind me.

Jul 6 2015, 9:19 PM · Remarkup, Passphrase
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 6 2015, 9:15 PM · Herald
epriestley added a comment to T8767: Destroyed credentials should render as strikethrough.

I can't reproduce this:

Jul 6 2015, 9:13 PM · Remarkup, Passphrase
joshuaspence created T8767: Destroyed credentials should render as strikethrough.
Jul 6 2015, 9:08 PM · Remarkup, Passphrase
epriestley added a comment to T8765: Links for installers don't work.

No worries, sorry these aren't working right now. We swapped hosts out and some of the domain rules changed a bit.

Jul 6 2015, 7:48 PM · Documentation
epriestley claimed T8746: 20131121.repocredentials.2.mig.php fails.
Jul 6 2015, 7:16 PM · Setup
epriestley added a comment to T8751: Links to installation/update scripts are broken.

Oh, and remove the scripts from version control if their chosen destination is not Diffusion, I suppose.

Jul 6 2015, 7:15 PM · Badge Awarded, Documentation
epriestley merged task T8765: Links for installers don't work into T8751: Links to installation/update scripts are broken.
Jul 6 2015, 7:14 PM · Documentation
epriestley updated subscribers of T8751: Links to installation/update scripts are broken.
Jul 6 2015, 7:14 PM · Badge Awarded, Documentation
epriestley added a revision to T8746: 20131121.repocredentials.2.mig.php fails: Unknown Object (Differential Revision).
Jul 6 2015, 7:14 PM · Setup
epriestley added a comment to T8746: 20131121.repocredentials.2.mig.php fails.

Since this migration is ~18 months old and there's no easy way to correct it, I'm just going to no-op it. You'll need to update your repositories to set the correct credentials after upgrading.

Jul 6 2015, 7:08 PM · Setup
epriestley added a project to T8751: Links to installation/update scripts are broken: Badge Awarded.
Jul 6 2015, 7:03 PM · Badge Awarded, Documentation
epriestley added a comment to T8751: Links to installation/update scripts are broken.

We should fix this since it's confusing, but I don't want to put www.phabricator.com back in service as a host since this was the only thing it was used for.

Jul 6 2015, 7:02 PM · Badge Awarded, Documentation
epriestley closed T8764: Reduce impact of backups on running instances as Resolved.

I pushed a change to record instance out-of-service dates (D13561) and stop running backups for out-of-service instances after about 48 hours (D13563). I promoted these changes to rSAAS stable and deployed admin. I manually updated all "Suspended" and "Disabled" instances to have an out-of-service date of July 1, 2015.

Jul 6 2015, 6:35 PM · Phacility, Ops
epriestley closed T8750: Graphviz remarkup blocks produce graphs too wide to display as Resolved.

(I think this is fixed?)

Jul 6 2015, 5:46 PM · Remarkup
epriestley added a comment to T8764: Reduce impact of backups on running instances.

I stopped storage upgrade from running on out-of-service instances (rCOREe9f998b109c1) and upgraded db002 and repo002 to verify this change. We don't need to keep out-of-service schemata up to date, and this reduces the ongoing cost of out-of-service instances.

Jul 6 2015, 5:01 PM · Phacility, Ops
epriestley added a revision to T8764: Reduce impact of backups on running instances: Unknown Object (Differential Revision).
Jul 6 2015, 4:52 PM · Phacility, Ops
epriestley added a comment to T8746: 20131121.repocredentials.2.mig.php fails.

ab7dc13c67fd (Sun, Jul 5, 12:28 PM) is after the earlier patch 92b73fed6b2c (Fri, Jul 3, 10:59 AM). This is still an error with the migration.

Jul 6 2015, 4:46 PM · Setup
epriestley added a revision to T8764: Reduce impact of backups on running instances: Unknown Object (Differential Revision).
Jul 6 2015, 4:31 PM · Phacility, Ops
epriestley closed T8759: Awkward first experience with Spaces as Resolved by committing Restricted Diffusion Commit.
Jul 6 2015, 4:20 PM · Spaces
epriestley added a comment to T8764: Reduce impact of backups on running instances.

I no-op'd the debian-start script and deployed db002 with the new changes (rCORE51d7570f5ddf) to verify it. I'm not going to restart db001 for the moment, since bringing it down is more disruptive and I only need confidence that the change is correct.

Jul 6 2015, 4:10 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

I've restarted the tier with a ~50% buffer pool configuration (4GB of 7.5GB) and 8GB swap (rCORE471d3a7acee1) and things seem to be holding stable. I'll pursue the other changes now.

Jul 6 2015, 3:56 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

Ubuntu also ships with some debian-sys-maint junk which runs huge, slow queries to check for problematic table data on every restart, which we should likely disable.

Jul 6 2015, 3:51 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

While I was writing this up, the host ran out of RAM and stopped working, so this is probably a memory management issue.

Jul 6 2015, 3:42 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

Some immediate observations:

Jul 6 2015, 3:41 PM · Phacility, Ops
epriestley added a comment to T4610: Implement robots.txt.

Since your code is mostly PHP, you could possibly just run Diviner on things to get something for Google to hit. That might be way off (and we may not be able to parse/atomize things in the MW codebase correctly), but I could see it being at least as good as indexing the source itself. If someone searches for a class or function name, I think getting the definition is almost always way more useful than getting callsites -- maybe even if the hit is shell docs with a link to the definition. And in some future world where everyone has infinite time to generate wonderful stable docs, the doc hit seems clearly preferable.

Jul 6 2015, 3:24 PM
epriestley added a comment to T4610: Implement robots.txt.

...so I could get a better idea of how these fields are used. In this case, sadly. I didn't find much at all, though it probably isn't because of the robots.txt exclusion in diffusion.

Jul 6 2015, 3:06 PM
epriestley created T8764: Reduce impact of backups on running instances.
Jul 6 2015, 2:46 PM · Phacility, Ops
epriestley added a revision to T8759: Awkward first experience with Spaces: Unknown Object (Differential Revision).
Jul 6 2015, 2:23 PM · Spaces
epriestley claimed T8759: Awkward first experience with Spaces.
Jul 6 2015, 2:13 PM · Spaces
epriestley closed T8762: Upgrade process should be more informative when unable to create new databases as Invalid.

https://secure.phabricator.com/book/phabflavor/article/please_please_please/

Jul 6 2015, 2:07 PM · Setup
epriestley closed T8761: Projects shouldn't allow setting "joinable by" to itself as Wontfix.

Generally, we prefer UI consistency and a simpler UI ruleset over preventing users from doing silly things.

Jul 6 2015, 2:05 PM · Projects
epriestley added a comment to T8763: Help arcanist keep track of which branch matches which review on Git.

The assumption is that you won't mix history.immutable (which compels arc not to mutate history) with rebasing (which mutates history): if you mutate history, we assume you're comfortable letting arc mutate history too. If you configure it as you have, you're locking us out of both commit messages (which we're forbidden from mutating) and commit/tree hashes (which may change after rebasing), so we don't have much to go on.

Jul 6 2015, 1:51 PM · Arcanist
epriestley added a comment to T8763: Help arcanist keep track of which branch matches which review on Git.

Mmmm, do you mean if I put "Differential Revision: DXXX" as the last line of the first commit of the branch, it'll be seen by arc and any subsequent arc diff will update the right review instead of creating a new one ?

Jul 6 2015, 1:44 PM · Arcanist
epriestley added a comment to T8762: Upgrade process should be more informative when unable to create new databases.

Can you paste the exact error message you received?

Jul 6 2015, 1:22 PM · Setup
epriestley added a comment to T8763: Help arcanist keep track of which branch matches which review on Git.

Use arc which to understand what arc diff will do and why.

Jul 6 2015, 1:21 PM · Arcanist
epriestley added a comment to T8759: Awkward first experience with Spaces.

(The more-correct remedy is likely for the administrator to disable policy.allow-public or set the visibility of at least one space to "Public (No Login Required)" so logged-out users can see some objects.)

Jul 6 2015, 3:55 AM · Spaces
epriestley added a comment to T8759: Awkward first experience with Spaces.

I just visited a site I don't have access to, so it should just say login or sign up.

Jul 6 2015, 3:54 AM · Spaces
joshuaspence created T8760: Show progress when running long-running lint commands.
Jul 6 2015, 1:17 AM · Arcanist

Jul 5 2015

epriestley added a comment to T8759: Awkward first experience with Spaces.

Do you have one Space, which is available to "All Users" instead of "Public"?

Jul 5 2015, 7:20 PM · Spaces
epriestley added a comment to T8549: Feedback on 2015 Redesign.

This is now merged to master.

Jul 5 2015, 12:19 PM · Design
epriestley edited the content of Changelog.
Jul 5 2015, 12:14 PM
epriestley closed T8756: Just Test as Resolved.
Jul 5 2015, 11:52 AM
epriestley created 2015 Week 27 (Early July).
Jul 5 2015, 11:51 AM
epriestley added a comment to T8756: Just Test.

You can not delete tasks.

Jul 5 2015, 11:50 AM
epriestley added a comment to T8752: PhabricatorAuthProviderOAuthGoogle and PhabricatorAuthProviderPassword both show Provider Implementation Missing! .

Also note that 20140218.passwords.2.prefix.sql is not idempotent, so re-running it if it already ran could break things.

Jul 5 2015, 11:03 AM · Auth
epriestley added a comment to T8752: PhabricatorAuthProviderOAuthGoogle and PhabricatorAuthProviderPassword both show Provider Implementation Missing! .

The expectation is that 20140722.renameauth.php renamed provider classes, and 20140218.passwords.2.prefix.sql reformatted the passwords.

Jul 5 2015, 11:02 AM · Auth

Jul 4 2015

epriestley added a comment to T4610: Implement robots.txt.

Can you give me an example of the kind of integration you're interested in? For example, what's a good query I can plug into Google or Bing and get a reasonable result in a codebase for?

Jul 4 2015, 11:50 PM
epriestley placed T7343: arc install-certificate doesn't work with bot users up for grabs.
Jul 4 2015, 6:56 PM · Arcanist
epriestley added a comment to T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist.

See "Managing Storage Adjustments" in the documentation, which discusses this under "Troubleshooting":

Jul 4 2015, 10:24 AM · Maniphest