Page MenuHomePhabricator
Create Task
Maniphest T8750

Graphviz remarkup blocks produce graphs too wide to display
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
tel
Jul 3 2015, 6:51 PM
Tags
Referenced Files
F584263: pasted_file
Jul 3 2015, 8:47 PM
F583554: pasted_file
Jul 3 2015, 6:51 PM
Subscribers
chad
epriestley
tel

Description

Today it is possible to construct Graphviz graphs which are too large display in Phriction wiki, yet they still will be displayed overflowing the text area. A fix should either display the generated graph inline shrunk to fit and then enable the user to click to expand it.

pasted_file (576×1 px, 103 KB)

Revisions and Commits

rP Phabricator
D13548rP54194acd39d6 [Redesign] Set a max-width on Graphviz

Related Objects

Event Timeline

tel created this task.Jul 3 2015, 6:51 PM
tel raised the priority of this task from to Needs Triage.
tel updated the task description. (Show Details)
tel added a project: Remarkup.
tel updated the task description. (Show Details)
tel added a subscriber: tel.
chad added a subscriber: chad.Jul 3 2015, 8:18 PM

I have a vague recollection this was fixed some time ago. What browser are you using and is your Phabricator at HEAD?

tel added a comment.Jul 3 2015, 8:34 PM

It's not, but it's fairly recent. I'm on Chrome and I'll try an upgrade.

tel added a comment.Jul 3 2015, 8:41 PM

Updated to head—no dice.

chad added a comment.Jul 3 2015, 8:41 PM

I'm thinking of T8221, which was May 19th. Might not be the same bug.

tel added a comment.Jul 3 2015, 8:47 PM

It's a similar looking problem. Indeed, it has a similar solution!

pasted_file (483×891 px, 99 KB)

Not sure why it's not working currently.

chad added a revision: D13548: [Redesign] Set a max-width on Graphviz.Jul 3 2015, 10:57 PM
chad added a comment.Jul 3 2015, 11:01 PM

D13548 will only correct images when they are newly built. If you have existing images that don't fit, you'll need to regenerate them.

chad added a commit: rP54194acd39d6: [Redesign] Set a max-width on Graphviz.Jul 4 2015, 8:17 PM
epriestley closed this task as Resolved.Jul 6 2015, 5:46 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

(I think this is fixed?)

tel added a comment.Jul 6 2015, 6:27 PM

I'll confirm in a moment.

tel added a comment.Jul 6 2015, 6:31 PM

Yup! When I regenerate the graph it's well-sized.

Phabricator · Built by Phacility