Page MenuHomePhabricator
Feed Advanced Search

Apr 9 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 12:16 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Still needs work:

Apr 9 2018, 12:15 PM · Plans, Files, Differential, Diffusion

Apr 8 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 7:53 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 4:34 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13047: Plans: Symbol Indexes: Unknown Object (Differential Revision).
Apr 8 2018, 4:34 PM · Plans, Symbols
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 3:13 PM · Plans, Files, Differential, Diffusion
epriestley closed T7895: Make HIGHLIGHT_BYTE_LIMIT configurable as Wontfix.

I don't currently plan to pursue this. We haven't seen interest from other installs and I think the upstream behavior is reasonably good most of the time and not a huge issue even when we get it wrong (you can still review the file without doing anything, and can get highlighting with a few clicks -- plus, the file and page render much faster).

Apr 8 2018, 3:05 PM · Restricted Project, Restricted Project, Differential
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 8 2018, 1:33 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • The secret $1-2,7-9 syntax for highlighting multiple noncontiguous blocks of lines in Diffusion is no longer supported.
Apr 8 2018, 1:31 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 8 2018, 1:18 PM · Plans, Differential
epriestley closed T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources as Resolved by committing Restricted Diffusion Commit.
Apr 8 2018, 1:17 PM · Typeahead
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 1:16 PM · Plans
epriestley closed T13118: Code block headers wrap in the dumbest way in Safari as Resolved by committing Restricted Diffusion Commit.
Apr 8 2018, 1:16 PM · Remarkup
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 8 2018, 1:12 PM · Plans
epriestley added a revision to T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources: Unknown Object (Differential Revision).
Apr 8 2018, 1:12 PM · Typeahead
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 8 2018, 1:07 PM · Plans
epriestley added a revision to T13118: Code block headers wrap in the dumbest way in Safari: Unknown Object (Differential Revision).
Apr 8 2018, 1:06 PM · Remarkup
epriestley added a parent task for T13117: `patch` just runs any command?: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Apr 8 2018, 12:59 PM · Security
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T13117: `patch` just runs any command?.
Apr 8 2018, 12:59 PM · Arcanist, Differential
epriestley closed T13116: Plans: 2018 Week 14 Bonus Content as Resolved.
Apr 8 2018, 12:55 AM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:54 AM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:54 AM · Plans
epriestley edited the content of Changelog.
Apr 8 2018, 12:30 AM
epriestley created 2018 Week 14 (Early April).
Apr 8 2018, 12:29 AM
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:10 AM · Plans
epriestley renamed T13120: Plans: 2018 Week 15 Bonus Content from Week 15 to Plans: 2018 Week 15 Bonus Content.
Apr 8 2018, 12:05 AM · Plans

Apr 7 2018

epriestley created T13120: Plans: 2018 Week 15 Bonus Content.
Apr 7 2018, 4:00 PM · Plans
epriestley triaged T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources as Normal priority.
Apr 7 2018, 1:24 PM · Typeahead
epriestley added a comment to T13117: `patch` just runs any command?.

A related attack is a bare whatever.patch file which writes to .git/config or .hg/hgconfig or whatever.

Apr 7 2018, 12:54 PM · Security
epriestley added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

In Safari we get this marvel:

Apr 7 2018, 2:26 AM · Remarkup
epriestley triaged T13118: Code block headers wrap in the dumbest way in Safari as Normal priority.
Apr 7 2018, 2:25 AM · Remarkup

Apr 6 2018

epriestley created P2088 nuker.php.
Apr 6 2018, 12:03 AM

Apr 5 2018

arend.danielek awarded T550: Build an SSH conduit client a Love token.
Apr 5 2018, 11:07 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley triaged T13117: `patch` just runs any command? as Normal priority.
Apr 5 2018, 6:46 PM · Security
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 6:40 PM · Plans, Files, Differential, Diffusion
epriestley closed T2442: Show images in Diffusion diffs as Resolved.

This will ultimately be covered by T13105.

Apr 5 2018, 5:54 PM · Wikimedia, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T5698: Github-style Remarkup previews on a checked-in resource, as Resolved.
Apr 5 2018, 5:52 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T12824: Redesign Diffusion, as Resolved.
Apr 5 2018, 5:52 PM · Design, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting as Resolved.

Effectively now covered by T13105.

Apr 5 2018, 5:52 PM · Diffusion
epriestley closed T3788: Improve encoding management in Diffusion, a subtask of T4045: Store diffs as binary, not UTF-8, as Resolved.
Apr 5 2018, 5:51 PM · Restricted Project, Support Impact, Differential
epriestley closed T3788: Improve encoding management in Diffusion as Resolved.

See T13105 for browse cases (and perhaps diff cases, eventually).

Apr 5 2018, 5:51 PM · Restricted Project, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • If a file is non-UTF8, we should try the repository's "Encoding" as a default (or maybe just remove this feature).
Apr 5 2018, 5:50 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Junk I'm about to break in Diffusion (but plan to restore):

Apr 5 2018, 5:38 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 4:17 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 2:33 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 5 2018, 1:34 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 5 2018, 1:29 PM · Plans, Differential

Apr 4 2018

epriestley closed T3965: Better indentation and tab handling in remarkup editor as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 3:45 PM · Remarkup
epriestley closed T8430: Support emoticons as Wontfix.

We now support emoji; we might support stickers at some point. If we did, I'd expect them to use the autocomplete element (which I think is in a relatively good place for emoji), not actually be invoked with :P, ^-^, etc.

Apr 4 2018, 3:44 PM · Restricted Project, Remarkup
epriestley closed T10398: Phabricator UI uses deprecated <tt> tag as Wontfix.

Since there's no known actual problem with this today, I don't plan to fix it.

Apr 4 2018, 2:11 PM · Remarkup, Bug Report
epriestley closed T11126: Allow embedding XKCD panes in Remarkup as Wontfix.

This is well-suited to a third-party extension, particularly after T5055.

Apr 4 2018, 2:09 PM · Restricted Project, User Delight, Remarkup, Feature Request
epriestley closed T10582: Support colspan and rowspan in tables as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 2:08 PM · Remarkup, Feature Request
epriestley closed T10729: Improve layout tools for side-by-side tables of images in Remarkup documents as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 2:08 PM · Remarkup, Feature Request
epriestley closed T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables) as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 2:07 PM · Feature Request, Remarkup
epriestley closed T5427: Force a line break in a table cell as Wontfix.

I don't currently plan to support this.

Apr 4 2018, 2:02 PM · Remarkup
epriestley closed T11284: Allow line breaks in list items as Wontfix.

I don't currently plan to support this. You may be able to add a rule to support something like <br /> with a Remarkup extension.

Apr 4 2018, 2:01 PM · Remarkup
epriestley closed T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax as Wontfix.

I don't currently plan to change the remaining edge case behaviors since I'm not sure they ever occur in the wild.

Apr 4 2018, 1:59 PM · Remarkup, Bug Report
epriestley closed T10163: Remarkup Autocomplete Errata as Resolved.

This seems largely resolved.

Apr 4 2018, 1:59 PM · Remarkup, Typeahead
epriestley closed T5393: Add support for <dl> HTML definition lists in Remarkup as Wontfix.

This request seems very niche, so I don't currently plan to pursue this. It may be possible to implement it as an extension.

Apr 4 2018, 1:57 PM · Remarkup
epriestley closed T7966: would like to have list in table with remarkup or html syntax. as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 1:57 PM · Remarkup
epriestley closed T4939: Block level items in lists in remarkup as Wontfix.

This is unlikely to ever happen without stronger use cases for nested block-level elements.

Apr 4 2018, 1:55 PM · Remarkup
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 4 2018, 1:51 PM · Plans, Differential
epriestley closed T8612: Improve handling of "large" changesets as Wontfix.

See T13110 for some followups.

Apr 4 2018, 1:47 PM · Restricted Project, Performance, Differential

Apr 3 2018

epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 11:36 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

This script can back-populate revision sizes that haven't been updated since D18832:

Apr 3 2018, 8:08 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

where I plan to explore the [----++ ] element

Apr 3 2018, 7:45 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 7:32 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 6:51 PM · Plans, Differential
epriestley added a revision to T13116: Plans: 2018 Week 14 Bonus Content: Unknown Object (Differential Revision).
Apr 3 2018, 5:50 PM · Plans
epriestley updated the task description for T13116: Plans: 2018 Week 14 Bonus Content.
Apr 3 2018, 5:50 PM · Plans
epriestley updated the task description for T13116: Plans: 2018 Week 14 Bonus Content.
Apr 3 2018, 5:49 PM · Plans
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 5:04 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 5:00 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:56 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:42 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

Some states:

Apr 3 2018, 4:38 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:28 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:56 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:47 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • shouldBroadcast() has been removed; getShouldBroadcast() now means the same thing.
Apr 3 2018, 3:38 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:23 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • getHasBroadcast(), setHasBroadcast(), and PROPERTY_HAS_BROADCAST are now getShouldBroadcast(), etc.
Apr 3 2018, 3:11 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Restricted Differential Revision.
Apr 3 2018, 3:11 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 2:31 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 1:48 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • Implementing BuildableInterface now requires implementing newBuildableEngine().
  • Implementing BuildableInterface no longer requires implementing getHarbormasterPublishablePHID(). Publishing indirection is now handled by BuildableEngine.
  • PhabricatorTransactions::TYPE_BUILDABLE no longer exists. Instead, applications should implement application-specific modular transactions to report build status information. DiffusionCommitBuildableTransaction may be useful as a template.
Apr 3 2018, 1:47 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 1:05 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 11:46 AM · Plans, Differential

Apr 2 2018

epriestley added a revision to T13116: Plans: 2018 Week 14 Bonus Content: Unknown Object (Differential Revision).
Apr 2 2018, 11:05 PM · Plans
epriestley triaged T13116: Plans: 2018 Week 14 Bonus Content as Normal priority.
Apr 2 2018, 11:00 PM · Plans
epriestley triaged T13115: Handle mail bounces inside Phabricator as Low priority.
Apr 2 2018, 10:53 PM · Mail

Mar 31 2018

epriestley closed T13114: Plans: 2018 Week 13 Bonus Content as Resolved.
Mar 31 2018, 11:38 AM · Plans
epriestley edited the content of Changelog.
Mar 31 2018, 12:51 AM
epriestley created 2018 Week 13 (Very Late March).
Mar 31 2018, 12:50 AM

Mar 30 2018

epriestley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Differential Revision).
Mar 30 2018, 10:57 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I'd like to analyze data on the $5 tier with an eye to removing it. Anecdotally, this doesn't seem to be doing anything good for us ... It also feels like we have a lot of $5 test instances.

Mar 30 2018, 10:50 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

The UI and allocation logic for shards need tweaking.

Mar 30 2018, 10:26 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster as Resolved by committing Restricted Diffusion Commit.
Mar 30 2018, 10:25 PM · Ops, Phacility
epriestley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Restricted Differential Revision.
Mar 30 2018, 10:22 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a revision to T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster: Restricted Differential Revision.
Mar 30 2018, 10:22 PM · Ops, Phacility