Page MenuHomePhabricator
Feed Advanced Search

Oct 4 2016

epriestley added a comment to T11730: Remove image crop from Conpherence.

I think it sort-of does something if you upload an irregularly-sized image (say, 100x200) instead of a square image. But I don't think it's particularly useful or works well even in that case, and I definitely support getting rid of it.

Oct 4 2016, 2:46 PM · Conpherence (v4)
epriestley added a comment to T3165: Provide Search in Conpherence.

Should basically just be UI, yeah.

Oct 4 2016, 1:58 AM · Conpherence (v4)

Oct 3 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 3 2016, 4:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 3 2016, 3:43 PM · Restricted Project, Prioritized, Calendar

Oct 2 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 2 2016, 1:55 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11724: One More as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11724: One More, a subtask of T11721: SR-45454, as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11723: DO Backend as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11723: DO Backend, a subtask of T11721: SR-45454, as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11722: DO UI task first, a subtask of T11721: SR-45454, as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11722: DO UI task first as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11721: SR-45454 as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11720: Test Feature as Spite.
Oct 2 2016, 11:21 AM · Feature Request
20after4 awarded T8238: Formally support side-band change handoff in external repositories a Doubloon token.
Oct 2 2016, 12:29 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Oct 1 2016

epriestley edited the content of Changelog.
Oct 1 2016, 1:14 PM
epriestley created 2016 Week 40 (Very Late September).
Oct 1 2016, 1:13 PM

Sep 30 2016

epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

Looks like we use the function to mean "codepoints" in some places in phabricator/.

Sep 30 2016, 12:01 AM · libphutil, Bug Report

Sep 29 2016

epriestley added a comment to T11714: Unified diffs don't allow selecting text in inline comments.

With no claim that this is the world's most elegant fix, I think this may be a fix:

Sep 29 2016, 11:59 PM · Differential, Bug Report
epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

In the short term, I'll accept a patch to do this if you want to test it?

Sep 29 2016, 11:52 PM · libphutil, Bug Report
epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

T9640 and T2383 are somewhat related.

Sep 29 2016, 11:47 PM · libphutil, Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 11:13 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11712: file chunks not encrypted when enabling file encryption as Resolved by committing Restricted Diffusion Commit.
Sep 29 2016, 10:47 PM · Bug Report
epriestley added a comment to T11712: file chunks not encrypted when enabling file encryption.

When you upload a file that is stored as chunks, the chunks are also files. For example, file F123 may have chunks F124, F125, F126, etc. These files are not normally visible in the web UI but you can see that the next file you upload will skip some numbers (e.g., be F127).

Sep 29 2016, 10:46 PM · Bug Report
epriestley added a revision to T11712: file chunks not encrypted when enabling file encryption: Unknown Object (Differential Revision).
Sep 29 2016, 10:42 PM · Bug Report
epriestley added a comment to T11712: file chunks not encrypted when enabling file encryption.

Why do you believe that files which are split into chunks don't get encrypted?

Sep 29 2016, 10:18 PM · Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 9:54 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 8:09 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 7:12 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

The examples that use the BYSETPOS and WKST rules are omitted, because these rules are not supported by Oracle Application Server Containers for J2EE.

Sep 29 2016, 7:07 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 6:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

I'm sorry you feel that way. These kinds of requests are frustrating for us too, which is why we try to make it clear upfront in the documentation that this is not an appropriate forum for them.

Sep 29 2016, 6:49 PM · Bug Report
epriestley closed T11709: Arc land fails: no commits on <feature-branch> which are not already present on target as Invalid.

Since it doesn't seem like the documentation is incorrect anywhere, this doesn't appear to describe a bug in Phabricator which we can accept upstream. See Support Resources and Contributing Bug Reports for details on what we do and do not provide support for.

Sep 29 2016, 6:47 PM · Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 6:39 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 6:17 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10412: Change Milestone sort options.

Please file a new task following Contributing Feature Requests if you'd like us to consider your feature request. We do not track resolved tickets.

Sep 29 2016, 5:43 PM · Feature Request
epriestley closed T11707: Creating master branch by default in diffusion as Invalid.

Please see Contributing Feature Requests and Describing Root Problems for guidance on filing a valid feature request. You need to follow all the instructions in those documents before we can accept your request upstream.

Sep 29 2016, 4:54 PM · Diffusion, Feature Request
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

Additionally, coming to phabricator, my expectation is that arcanist would handle the front-end (i.e. phabricator), but not strong-arming my local development environment.

Sep 29 2016, 4:44 PM · Bug Report
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

That document says:

Sep 29 2016, 4:42 PM · Bug Report
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

What led you to arc land, specifically?

Sep 29 2016, 4:32 PM · Bug Report
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Also possible is stuff like "the diff has a custom policy which you destroyed", etc.

Sep 29 2016, 4:30 PM · Daemons, Differential, Bug Report
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

If an object exists but is failing to load, it's usually because a required related object does not exist (in most cases, "required" means "required in order to evaluate policy checks").

Sep 29 2016, 4:29 PM · Daemons, Differential, Bug Report
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

This isn't a bug -- I think we've just set you up with the wrong expectations somehow. There's probably some sort of documentation we can improve to make it more clear what arc land does, and maybe I can figure out how where we led you astray by asking some questions:

Sep 29 2016, 4:16 PM · Bug Report
epriestley closed T11711: exm as Invalid.
Sep 29 2016, 11:14 AM · Bug Report

Sep 28 2016

joshuaspence added a comment to T11705: Repositories are getting stuck.

Thanks!

Sep 28 2016, 10:02 PM · Diffusion, Daemons
epriestley closed T11705: Repositories are getting stuck as Resolved by committing Restricted Diffusion Commit.
Sep 28 2016, 10:02 PM · Diffusion, Daemons
epriestley added a revision to T11705: Repositories are getting stuck: Unknown Object (Differential Revision).
Sep 28 2016, 9:55 PM · Diffusion, Daemons
epriestley added a comment to T11705: Repositories are getting stuck.

Yeah, ON DUPLICATE KEY UPDATE is sensitive to order. Setup:

Sep 28 2016, 9:48 PM · Diffusion, Daemons
epriestley added a comment to T11705: Repositories are getting stuck.

I think this is:

Sep 28 2016, 9:39 PM · Diffusion, Daemons
sudoforge awarded T3569: Make Phrequent somewhat usable a Like token.
Sep 28 2016, 6:58 PM · Phrequent
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:46 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

(The major goal of using refs instead of tags wouldn't really be to hide them per se, just to make them extremely difficult to fetch by accident.)

Sep 28 2016, 2:07 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Maybe my assumptions about default behaviors are off, or the more-recent base tags (but not necessarily the diff tags) are getting fetched because they're often ancestors of master?

Sep 28 2016, 2:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm a little confused about how these tags are appearing so widely in developer working copies in the first place. Is git clone fetching them by default? Do you have unusual default options configured? Do users regularly explicitly fetch all tags present in the remote?

Sep 28 2016, 2:00 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I think cleaning up closed tags probably isn't a particularly great long-term solution since some fraction of the revisions likely just get left open forever -- so you'd have 500 tags instead of 50000, but I assume that still causes about as many problems, and you'll be back to 50000 in just 100 more years anyway.

Sep 28 2016, 12:29 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T11706: Retrieve event date from Calendar "calendar.event.search" method API.

See some discussion in T7944, particularly T7944#194982.

Sep 28 2016, 12:10 PM · Calendar, Feature Request
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

We're planning to put application-level stemming on the MySQL index (see T6740). Are there problems with the InnoDB search that you're aware of that aren't fixable with application adjustments?

Sep 28 2016, 12:05 PM · Elasticsearch, Search
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:18 AM · Restricted Project, Prioritized, Calendar
joshuaspence added a comment to T11705: Repositories are getting stuck.

I clicked "Update Now" and the update frequency for our most active repository has dropped back down to 15 seconds.

Sep 28 2016, 2:04 AM · Diffusion, Daemons
joshuaspence created T11705: Repositories are getting stuck.
Sep 28 2016, 2:03 AM · Diffusion, Daemons
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 1:24 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 1:06 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:48 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:28 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:17 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:08 AM · Restricted Project, Prioritized, Calendar

Sep 27 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:39 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:30 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:20 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 6:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T4190: Rebuild remarkup image proxying.

(I'll follow up on this once I have a chance to bang on it a bit, but I want to try to finish up the RRULE stuff while it's still somewhat fresh in my mind.)

Sep 27 2016, 5:03 PM · Contributor Onboarding, Remarkup
epriestley closed T11524: Import-time diff generation fails for particular commits in cluster mode as Resolved.

This went out a while ago and I confirmed the fix in production.

Sep 27 2016, 4:43 PM · Phacility, Clusters, Daemons, Diffusion
epriestley closed T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived as Resolved.

I'm going to presume we got this, but reopen or yell if you're still seeing issues on the new code.

Sep 27 2016, 4:38 PM · Restricted Project, Bug Report
epriestley closed T11703: Floating point issue on points on workboards as Resolved by committing Restricted Diffusion Commit.
Sep 27 2016, 4:36 PM · Workboards, Bug Report
epriestley moved T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:35 PM · Contributor Onboarding, Modernization
epriestley added a project to T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting: Contributor Onboarding.
Sep 27 2016, 4:35 PM · Contributor Onboarding, Modernization
epriestley edited projects for T11692: Open differential submission and public view, added: Bug Report (Needs Information); removed Bug Report.
Sep 27 2016, 4:33 PM · Differential, Bug Report (Needs Information)
epriestley claimed T11703: Floating point issue on points on workboards.
Sep 27 2016, 4:32 PM · Workboards, Bug Report
epriestley added a comment to T11703: Floating point issue on points on workboards.

Thanks for the report! The detailed reproduction instructions were very helpful in resolving this.

Sep 27 2016, 4:32 PM · Workboards, Bug Report
epriestley added a revision to T11703: Floating point issue on points on workboards: Restricted Differential Revision.
Sep 27 2016, 4:31 PM · Workboards, Bug Report
epriestley added a comment to T11217: Make Tokens modular / real application.

I'm also not sure if we can use SVG as a data: URL in CSS. It probably should work, but if it doesn't we'll have to rasterize (and, I guess, serve 5+ different sizes to every user).

Sep 27 2016, 4:18 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

Alright -- we can have bin/celerity map rasterize SVG into arbitrary sizes if I'm not comfortable serving SVG directly from Celerity.

Sep 27 2016, 4:17 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T10715: Badge name on badge cards should be a link to the badge page from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:12 PM · Contributor Onboarding, Badges
epriestley reassigned T10715: Badge name on badge cards should be a link to the badge page from lpriestley to jcox.
  • Create a badge.
  • Award it to a user.
  • Visit their profile page.
  • On the profile page, the badge title should link to the badge detail page (currently: no way to get to the badge detail page).
Sep 27 2016, 4:11 PM · Contributor Onboarding, Badges
epriestley moved T9063: Conduit application search from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:08 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley reassigned T9063: Conduit application search from joshuaspence to jcox.

I'm not really sure this is actually useful given that every method is now named <application>.whatever and you can search by substring.

Sep 27 2016, 4:08 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley added a comment to T11217: Make Tokens modular / real application.

(That will give us slightly bad scale-downs on 1X screens, but I bet they're not worse than scaling down an SVG would be.)

Sep 27 2016, 4:05 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

I think we can just do 2x in all cases for these, if that's reasonable?

Sep 27 2016, 4:04 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley assigned T11217: Make Tokens modular / real application to jcox.

This one is a little scattered, so let me know where I can fill in any gaps. Most of the details are in D16178.

Sep 27 2016, 3:59 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Backlog to Ready on the Contributor Onboarding board.
Sep 27 2016, 3:57 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley added a project to T11701: Add a lint rule for `if (CONSTANT) { ... }`: Contributor Onboarding.
Sep 27 2016, 3:57 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T11217: Make Tokens modular / real application from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:47 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley reassigned T10681: Add Phurl Conduit API methods from lpriestley to jcox.
Sep 27 2016, 3:46 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley moved T10681: Add Phurl Conduit API methods from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:46 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl

Sep 26 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 26 2016, 10:50 PM · Restricted Project, Prioritized, Calendar
epriestley created T11701: Add a lint rule for `if (CONSTANT) { ... }`.
Sep 26 2016, 3:12 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley added a comment to T11693: Make drydock command interfaces accessible via SSH workflows.

Do you have any use cases which are not approximately some flavor of:

Sep 26 2016, 1:31 PM · Restricted Project, Drydock