Page MenuHomePhabricator
Feed Advanced Search

May 12 2016

epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
May 12 2016, 7:13 PM · Mail, Differential
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments, a subtask of T10694: Improve behavior of context for inline comments in mail, as Resolved.
May 12 2016, 7:13 PM · Prioritized, Restricted Project, Differential, Mail
epriestley moved T5000: Using Differential with plain Git, without requiring Arc from Backlog to Preflight on the Prioritized board.
May 12 2016, 6:57 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a project to T5000: Using Differential with plain Git, without requiring Arc: Prioritized.

We're prioritizing the research to estimate how much work this is so we can possibly eventually prioritize it, so this is going into the queue, but don't read too much into it.

May 12 2016, 6:57 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

@epriestley Thats good to know. Also, will this change include formatting the Change Details section of emails? That one is currently a blob of visually unparseable text even in HTML emails.

May 12 2016, 5:55 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 12 2016, 5:51 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley placed T6616: Typeahead uses locale-specific comparison up for grabs.
May 12 2016, 5:31 PM · Typeahead, PHUI
epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from Backlog to Preflight on the Prioritized board.
May 12 2016, 4:51 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a project to T5187: Make "Upload File" dialog have a vanilla file upload control: Prioritized.
May 12 2016, 4:51 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

Sure. I'd estimate this is 1-2 hours of work if we develop a patch ourselves and 2-3 hours of work if we work with @matmarex to make his patch suitable for inclusion and maintenance in the upstream. Which would you prefer?

May 12 2016, 4:42 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley moved T10939: Support for OWNERS files from Backlog to Preflight on the Prioritized board.
May 12 2016, 4:37 PM · Prioritized, Restricted Project, Owners
epriestley added a project to T10939: Support for OWNERS files: Prioritized.

(I'm just getting this into the preflight column for communication purposes since there's a slot reserved, we won't start work on this until we have an explicit confirmation.)

May 12 2016, 4:37 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

(If that answer isn't particularly satisfying, maybe see discussion starting here: T7820#172877.)

May 12 2016, 4:31 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

We haven't seen much interest in this from outside WMF, so there are probably several hundred tasks ahead of it on our natural roadmap.

May 12 2016, 4:25 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to Q388: Should Differential notify you on inline comments submitted with no additional actions being taken?.

Ignore my answer, I misunderstood your question. This is not expected. File a bug with reproduction instructions.

May 12 2016, 4:19 PM
epriestley marked Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? (Answer 376) as hidden.
May 12 2016, 4:18 PM
epriestley added Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? (Answer 376).
May 12 2016, 4:17 PM
epriestley closed T10958: Dead Link at Diviner as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 3:30 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 12 2016, 3:29 PM · Diffusion (v3)
epriestley added a comment to T10958: Dead Link at Diviner.

Thanks!

May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley claimed T10958: Dead Link at Diviner.
May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10958: Dead Link at Diviner: Unknown Object (Differential Revision).
May 12 2016, 3:19 PM · Documentation, Diviner, Bug Report
epriestley added a comment to T4292: Implement repository replication.

T10748 is moving into production, which is the last major new piece here. Remaining cleanup work I plan to do in this phase:

May 12 2016, 3:17 PM · Restricted Project, Diffusion
epriestley added a comment to T10751: Make Phabricator Highly Available.

I think this is the current state of the world. I'm planning to tackle the three major issues noted below (observed repository versioning, repository lock granularity, device enrollment behavior) and then try to wind down this phase, move all this followup work to a new "make clustering more powerful" sort of task, and then plan where to go from there based on which goals are most important (scalability vs multi-region vs read-only vs hg/svn vs drydock vs whatever crops up as installs actually deploy this stuff).

May 12 2016, 3:12 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10955: Changing tags doesn't seem possible on repositories any more? as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 2:17 PM · Diffusion, Bug Report
epriestley closed T10860: After an inconsistent cluster repository write, consider just ignoring the lock, a subtask of T4292: Implement repository replication, as Resolved.
May 12 2016, 2:10 PM · Restricted Project, Diffusion
epriestley closed T10860: After an inconsistent cluster repository write, consider just ignoring the lock as Resolved.

Going any farther than this risks some inconsistency / data loss and we haven't managed to break this yet, so I'm going to consider this sufficiently robust until we see evidence otherwise.

May 12 2016, 2:10 PM · Clusters, Diffusion
epriestley added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

They can link their accounts in Settings → External Accounts.

May 12 2016, 2:09 PM · Auth, Bug Report
epriestley added a revision to T10751: Make Phabricator Highly Available: Unknown Object (Differential Revision).
May 12 2016, 1:56 PM · Restricted Project, Infrastructure, Prioritized
epriestley added a revision to T10955: Changing tags doesn't seem possible on repositories any more?: Unknown Object (Differential Revision).
May 12 2016, 1:26 PM · Diffusion, Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 12 2016, 1:26 PM · Diffusion (v3)
epriestley added a comment to T10955: Changing tags doesn't seem possible on repositories any more?.

It's on an invisible page <_< >_>

May 12 2016, 1:17 PM · Diffusion, Bug Report
epriestley claimed T10955: Changing tags doesn't seem possible on repositories any more?.
May 12 2016, 1:17 PM · Diffusion, Bug Report
epriestley closed T10957: When logged in through an external auth provider, user is invited to re-create his account as Invalid.

This is expected. This is a security feature, not a bug. Just because you have a Phabricator user account named joe does not mean you have authority over the LDAP user account named joe, and vice versa. In many cases LDAP and Phabricator user account names differ. Users must prove they have control over external accounts by linking them before they can use those external accounts to access Phabricator.

May 12 2016, 1:16 PM · Auth, Bug Report
epriestley closed I3 Development of making callsigns optional / flexible.
May 12 2016, 1:31 AM · Diffusion
epriestley added a comment to I3 Development of making callsigns optional / flexible.

Callsigns have been optional for a while now so I'm going to close this. See T4245 for context and followups.

May 12 2016, 1:31 AM · Diffusion
epriestley added a comment to T4245: Make repository URIs slightly prettier.

Callsigns have been optional for some time (roughly since D15305 in February 2016, although there were a trickle of bugs after that).

May 12 2016, 1:11 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley renamed T4245: Make repository URIs slightly prettier from Make repository callsigns optional or more flexible to Make repository URIs slightly prettier.
May 12 2016, 1:06 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T10751: Make Phabricator Highly Available: Unknown Object (Differential Revision).
May 12 2016, 12:03 AM · Restricted Project, Infrastructure, Prioritized

May 11 2016

epriestley added a comment to T10751: Make Phabricator Highly Available.

T10748 is wrapping up, and repositories now show cluster status in the new "Storage" panel of the new UI:

May 11 2016, 11:46 PM · Restricted Project, Infrastructure, Prioritized
epriestley updated the task description for T10922: Upgrading: New Repository UI, APIs, and URI management.
May 11 2016, 11:21 PM · Diffusion (v3), Installing & Upgrading
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

I think this is substantially complete now. There will probably still be a trickle of issues as this gets more use and T10923 has some stuff that didn't get fully addressed here, but everything I've been tracking is in reasonable shape as far as I'm aware.

May 11 2016, 11:10 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T10930: Exception in editengine for Paste as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 10:35 PM · ApplicationEditor, Bug Report
epriestley closed T10952: Cannot edit pastes, if you want to keep the content as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 10:35 PM · Paste, Bug Report
epriestley added a revision to T10930: Exception in editengine for Paste: Unknown Object (Differential Revision).
May 11 2016, 10:34 PM · ApplicationEditor, Bug Report
epriestley added a revision to T10952: Cannot edit pastes, if you want to keep the content: Unknown Object (Differential Revision).
May 11 2016, 10:34 PM · Paste, Bug Report
florianb awarded T5132: Document the special syntax you can use in commit messages to cause effects a Love token.
May 11 2016, 5:40 PM · Guides, Diffusion
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 11 2016, 5:27 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 5:21 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 4:48 PM · Diffusion (v3)
epriestley added a comment to T10939: Support for OWNERS files.

I think some setting like:

May 11 2016, 4:28 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 3:19 PM · Diffusion (v3)
epriestley added a comment to T3980: Support "Bind to External Thing" to define project membership.

This was moved into the prioritization queue by a particular customer that was interested in defining Owners via Projects via external sync.

May 11 2016, 2:56 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 2:27 PM · Diffusion (v3)
yelirekim awarded T10751: Make Phabricator Highly Available a Mountain of Wealth token.
May 11 2016, 2:23 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10948: Hide non-functional clone URLs as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 2:18 PM · Feature Request, Diffusion
epriestley closed T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist as Resolved.

Cool -- thanks for the report, and sorry about the issue! Some of the Diffusion/repository stuff has been a little choppy lately as we've rolled out changes in connection with T10922 / T10923. Let us know if you run into anything else.

May 11 2016, 2:11 PM · Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 2:03 PM · Diffusion (v3)
epriestley added a revision to T10948: Hide non-functional clone URLs: Unknown Object (Differential Revision).
May 11 2016, 2:03 PM · Feature Request, Diffusion
epriestley added a comment to T10948: Hide non-functional clone URLs.

If your install is not available over http, set security.require-https in Config. This will disable the http URI.

May 11 2016, 1:55 PM · Feature Request, Diffusion
epriestley removed a project from T3980: Support "Bind to External Thing" to define project membership: Prioritized.

I think this was building up toward T10939, and the actual solutions we're looking at there probably don't involve this.

May 11 2016, 1:51 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley removed a project from T10621: Create projects from external thing (extension to T3980): Prioritized.

I think this was building up toward T10939, and the actual solutions we're looking at there probably don't involve this.

May 11 2016, 1:51 PM · Restricted Project, Restricted Project, LDAP, Projects, Feature Request
epriestley closed T10941: Subversion fails to execute pre-commit hook if CWD isn't readable as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 1:48 PM · Diffusion, Subversion, Bug Report
epriestley closed T10815: Confusing diffusion error with empty, non-activated hosted repository as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 1:39 PM · Diffusion, Bug Report
epriestley added a comment to T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist.

This should now be fixed in HEAD of master -- try updating again? You'll need to git pull in phabricator/ to pick up the change.

May 11 2016, 1:37 PM · Bug Report
epriestley closed T9554: Trigger "import" heuristics for imported repositories as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 1:36 PM · Diffusion, Restricted Project, Restricted Project
epriestley added a comment to T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist.

This should be fixed shortly by D15876.

May 11 2016, 1:35 PM · Bug Report
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

The problem is that a user will not read the entire email from top to bottom. There is far too much information to do that on every email that gets sent, and most of it is essentially boiler plate.

May 11 2016, 1:20 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10939: Support for OWNERS files.

I mean that it's minor to implement -- the current plan on T9372 is "don't make any major structural changes, just adjust the existing bucketing algorithm".

May 11 2016, 12:57 PM · Prioritized, Restricted Project, Owners
epriestley changed the visibility for D3025: Add/update some documentation on branches and reviewable code.
May 11 2016, 12:26 PM
• oswaldo awarded T4548: Support "Mylyn" Eclipse plugin a Like token.
May 11 2016, 7:03 AM · Feature Request, Maniphest
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 11 2016, 2:07 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 11 2016, 1:39 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 11 2016, 1:12 AM · Prioritized, Restricted Project, Differential, Mail
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 11 2016, 12:18 AM · Diffusion (v3)
epriestley created T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist.
May 11 2016, 12:17 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 11 2016, 12:14 AM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 12:14 AM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 12:01 AM · Diffusion (v3)

May 10 2016

epriestley added a comment to T10926: Make it more likely to see assignee & reporter in task view without having to scroll down.

I think it's a custom select field with an explicit nonempty "None" value, so display is expected.

May 10 2016, 11:32 PM · Transactions, Feature Request, Maniphest
rftfaria awarded T5954: Modularize "Export to Excel" as a feature of ApplicationSearch a Like token.
May 10 2016, 8:35 PM · Custom Fields, ApplicationSearch
epriestley closed T10090: Updating Herald rule throws Unhandled Exception as Resolved.

This may have been fixed by D15507. Otherwise, we can't reproduce it, so we can't move forward. See Providing Reproduction Steps.

May 10 2016, 4:20 PM · Herald, Bug Report
epriestley renamed T10941: Subversion fails to execute pre-commit hook if CWD isn't readable from Subversion commits fail with "Commit blocked by pre-commit hook (exit code 255) with no output" to Subversion fails to execute pre-commit hook if CWD isn't readable.
May 10 2016, 2:33 PM · Diffusion, Subversion, Bug Report
epriestley added a revision to T10941: Subversion fails to execute pre-commit hook if CWD isn't readable: Unknown Object (Differential Revision).
May 10 2016, 2:32 PM · Diffusion, Subversion, Bug Report
epriestley awarded T10941: Subversion fails to execute pre-commit hook if CWD isn't readable a Mountain of Wealth token.
May 10 2016, 2:30 PM · Diffusion, Subversion, Bug Report
epriestley edited this Badge.
May 10 2016, 2:30 PM
epriestley added a comment to T10941: Subversion fails to execute pre-commit hook if CWD isn't readable.

Awesome! Thanks for doing all the work to figure out what was going on. I'll get a diff out to apply that fix in a slightly nicer way.

May 10 2016, 2:30 PM · Diffusion, Subversion, Bug Report
epriestley closed T3607: Diffusion should raise a reasonable error when the default branch does not exist as Resolved.

This behavior seems reasonable at HEAD and we haven't seen other issues with it.

May 10 2016, 2:26 PM · Diffusion
epriestley closed T7796: Import from SVN is running forever as Invalid.

This report doesn't include reproduction steps so we can't move forward. See Contributing Bug Reports and Providing Reproduction Steps.

May 10 2016, 2:19 PM · Diffusion
epriestley closed T10460: Commit Still Parsing as Resolved.

It sounds like this is resolved.

May 10 2016, 2:16 PM · Diffusion, Bug Report (Needs Information)
epriestley added a revision to T10815: Confusing diffusion error with empty, non-activated hosted repository: Unknown Object (Differential Revision).
May 10 2016, 2:15 PM · Diffusion, Bug Report
epriestley moved T10923: Diffusion API/URI Errata from Backlog to v3 on the Diffusion board.
May 10 2016, 2:06 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 2:06 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 10 2016, 2:05 PM · Diffusion (v3)
epriestley added a revision to T9554: Trigger "import" heuristics for imported repositories: Unknown Object (Differential Revision).
May 10 2016, 2:05 PM · Diffusion, Restricted Project, Restricted Project
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 1:28 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 1:27 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 10 2016, 1:27 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 12:56 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 10 2016, 12:56 PM · Diffusion (v3)