Page MenuHomePhabricator

unify "table of contents" views between Differential and Diffusion
Closed, ResolvedPublic

Description

I think DifferentialDiffTableOfContentsView and DiffusionCommitChangeTableView should be merged into one functional heap of awesomeness. Mostly, I think DifferentialDiffTableOfContentsView should win.

Event Timeline

I wanted to get feedback on this idea. If some consensus or whatnot is formed, feel free to assign to me.

Your description sounds good to me. Agreed that DifferentialDiffTableOfContentsView should come out the victor, broadly speaking.

For mobile, I think we can just hide most of the columns in the table/list/view thing (and maybe hide the section by default).

chad assigned this task to btrahan.Dec 16 2012, 5:05 AM
chad triaged this task as Normal priority.Dec 16 2012, 9:29 PM
chad added a comment.Apr 23 2013, 3:28 PM

Is this task still relevant?

btrahan removed btrahan as the assignee of this task.Apr 23 2013, 10:29 PM

Yes.

Consider D5769 vs rP482be727ab1ca6bd93de8a75cf2ca66aef9d9948. The former has a "Table of Contents" element and the latter has a "Changes" element. I think the UI difference doesn't do anything positive and thus increases cognitive load. Word?

I just tried to re-load my branch on this and it was conflict city, plus I don't think I had too much so upforgrabbsin'.

epriestley renamed this task from unify "table of contents" views between Differential and Maniphest to unify "table of contents" views between Differential and Diffusion.May 5 2014, 8:31 PM
epriestley edited this Maniphest Task.May 25 2014, 2:16 PM
sicnervo moved this task to Short Term on the Design board.May 29 2014, 7:44 AM
epriestley moved this task from Short Term to Backlog on the Design board.May 29 2014, 12:46 PM
chad removed a project: Design.Sep 17 2014, 8:30 PM
btrahan added a subscriber: aik099.

T6426 is a specific complaint about the differences here, asking for the file count to be surfaced consistently.

chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 4:41 AM
epriestley moved this task from Backlog to Dark Ages on the Owners board.Aug 11 2015, 1:50 PM
epriestley added a subscriber: nickz.