I think DifferentialDiffTableOfContentsView and DiffusionCommitChangeTableView should be merged into one functional heap of awesomeness. Mostly, I think DifferentialDiffTableOfContentsView should win.
Description
Description
Revisions and Commits
Revisions and Commits
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | joshuaspence | T7603 Remove the deprecated "Repositories" application | ||
| Resolved | joshuaspence | T7604 Remove "Arcanist Projects" | ||
| Resolved | epriestley | T8320 Bring Owners out of the dark ages | ||
| Resolved | None | T8004 Highlight files owned by self/project when viewing revision | ||
| Resolved | epriestley | T5644 Add controls to prevent `pygmentize` from saturating system resources | ||
| Resolved | epriestley | T5179 Unearth Differential rendering technical debt | ||
| Resolved | epriestley | T2183 unify "table of contents" views between Differential and Diffusion |
Event Timeline
Comment Actions
I wanted to get feedback on this idea. If some consensus or whatnot is formed, feel free to assign to me.
Comment Actions
Your description sounds good to me. Agreed that DifferentialDiffTableOfContentsView should come out the victor, broadly speaking.
For mobile, I think we can just hide most of the columns in the table/list/view thing (and maybe hide the section by default).
Comment Actions
Yes.
Consider D5769 vs rP482be727ab1ca6bd93de8a75cf2ca66aef9d9948. The former has a "Table of Contents" element and the latter has a "Changes" element. I think the UI difference doesn't do anything positive and thus increases cognitive load. Word?
I just tried to re-load my branch on this and it was conflict city, plus I don't think I had too much so upforgrabbsin'.
Comment Actions
T6426 is a specific complaint about the differences here, asking for the file count to be surfaced consistently.