Page MenuHomePhabricator

Unhandled Exception ("InvalidArgumentException") on random Differential
Closed, ResolvedPublic

Description

An existing Differential on my site was commandeered and updated, and now it is displaying...

Unhandled Exception ("InvalidArgumentException")
Argument 2 passed to phutil_implode_html() must be of the type array, string given, called in /home/hawksnest/phab/phabricator/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php on line 277 and defined

All the other Differentials are working fine.

Event Timeline

We now have TWO Differentials doing this - one that was just posted did the same thing.

Now we also have errors on ALL of our Phabricator-hosted Git repositories when you try to view a branch.

Unhandled Exception ("PhutilInvalidStateException")
Call withControl() before calling getControllingPackagesForPath()!

Do we need both a task and an audit on this? Can one place serve as master?

I originally made the task, and then I happened to find the code responsible. Which would you prefer? (Frankly, I'd wager that the task is less useful.)

I'm just a bit flustered. We're under a deadline (Saturday), and until this is fixed, we're dead in the water.

epriestley claimed this task.

You may want to try running the stable branch instead of master:

https://secure.phabricator.com/book/phabricator/article/upgrading/#stable-branch

In particular, we usually cut stable early Saturday morning and tend to delay any high-risk changes until after that, so upgrading to master on Saturday exposes you to the greatest level of instability and risk.

Hi @epriestley, thanks for the fix and the advice. I've switched to stable. All is well now.