Page MenuHomePhabricator
Feed Advanced Search

May 18 2020

epriestley closed T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE" as Resolved by committing Restricted Diffusion Commit.
May 18 2020, 7:10 PM · Infrastructure
epriestley updated the task description for T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".
May 18 2020, 7:10 PM · Infrastructure
epriestley added a revision to T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE": Unknown Object (Differential Revision).
May 18 2020, 7:09 PM · Infrastructure
epriestley added a comment to T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".

The actual query we use to inspect table information is:

May 18 2020, 6:46 PM · Infrastructure
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

See T13537 for a subtle issue where digestWithNamedKey() keys were cached in APCu on the web tier. Importing instance data may require restarting the web tier until the import process can either dump these caches or version them (versioning may be easier).

May 18 2020, 5:38 PM · Phacility
epriestley added a comment to T13537: Support local port forwarding through Phacility cluster bastion hosts.

So I'm going to turn web off and on again and see if that fixes things; my expectation is that it will.

May 18 2020, 5:36 PM · Phacility
epriestley added a comment to T13537: Support local port forwarding through Phacility cluster bastion hosts.

The specific issue I'm trying to debug is fairly bizarre.

May 18 2020, 5:35 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
May 18 2020, 4:59 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
May 18 2020, 4:56 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
May 18 2020, 4:47 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
May 18 2020, 4:37 PM · Phacility
epriestley triaged T13537: Support local port forwarding through Phacility cluster bastion hosts as Low priority.
May 18 2020, 4:33 PM · Phacility
epriestley added a comment to Blog Post: Quick Look: Inline Comments on Character Ranges.

Thanks! I figured out how to make somewhat-reasonable GIFs with ffmpeg.

May 18 2020, 4:04 PM · Quick Look, Differential
20after4 added a comment to Blog Post: Quick Look: Inline Comments on Character Ranges.

Thanks for the quick-look posts, these are nice.

May 18 2020, 3:58 PM · Quick Look, Differential

May 17 2020

epriestley renamed T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE" from MySQL "SHOW CREATE TABLE" syntax has changed for integers to In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".
May 17 2020, 3:53 PM · Infrastructure
epriestley triaged T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE" as Low priority.
May 17 2020, 3:53 PM · Infrastructure

May 15 2020

epriestley edited the content of Changelog.
May 15 2020, 8:55 PM
epriestley updated the post content for Blog Post: Quick Look: Jupyter Diff Context.
May 15 2020, 8:54 PM · Quick Look, Differential
epriestley created an object: 2020 Week 19 (Mid May).
May 15 2020, 8:53 PM
epriestley updated the subtitle for Blog Post: Quick Look: Jupyter Diff Context.
May 15 2020, 8:52 PM · Quick Look, Differential
epriestley created Blog Post: Quick Look: Inline Comments on Character Ranges.
May 15 2020, 8:52 PM · Quick Look, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 15 2020, 8:27 PM · Inline Comments, Diffusion, Differential
epriestley renamed Blog Post: Quick Look: Jupyter Diff Context blog post from Quick Look: Jupyter Diff Context (2020 Week 18) to Quick Look: Jupyter Diff Context.
May 15 2020, 8:23 PM · Quick Look, Differential
epriestley created Blog Post: Quick Look: Jupyter Diff Context.
May 15 2020, 8:22 PM · Quick Look, Differential
epriestley created Quick Look.
May 15 2020, 8:19 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 15 2020, 7:43 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
May 15 2020, 4:42 PM · Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 15 2020, 4:35 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13529: Phacility domain rename errata and SSH user identity: Unknown Object (Differential Revision).
May 15 2020, 1:31 PM · Phacility
PXke added a member for Arcanist: PXke.
May 15 2020, 1:16 PM
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • The line-triggered reticle should be updated to use the hover-reticle cell style.
May 15 2020, 12:24 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Screen Shot 2020-05-14 at 5.01.17 PM.png (545×661 px, 44 KB)

May 15 2020, 12:03 AM · Inline Comments, Diffusion, Differential

May 14 2020

epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
May 14 2020, 10:56 PM · Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 14 2020, 10:53 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 14 2020, 8:18 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 14 2020, 6:46 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 14 2020, 6:40 PM · Inline Comments, Diffusion, Differential
epriestley triaged T13535: Investigate PHP 7.4 Preloading as Wishlist priority.
May 14 2020, 6:26 PM · Infrastructure
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 14 2020, 6:19 PM · Inline Comments, Diffusion, Differential
epriestley triaged T13534: Inline Comment errata after editing persistence as Wishlist priority.
May 14 2020, 6:13 PM · Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 14 2020, 5:57 PM · Inline Comments, Diffusion, Differential
epriestley closed T13533: Support arbitrary cURL options, for Kerberos auth as Resolved by committing Restricted Diffusion Commit.
May 14 2020, 4:16 PM · Infrastructure
epriestley added a revision to T13533: Support arbitrary cURL options, for Kerberos auth: Unknown Object (Differential Revision).
May 14 2020, 4:14 PM · Infrastructure
epriestley triaged T13533: Support arbitrary cURL options, for Kerberos auth as Wishlist priority.
May 14 2020, 3:54 PM · Infrastructure

May 13 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 13 2020, 11:55 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In Jupyter notebooks (and, theoretically, other rich content) we find an inner <td /> before finding the content <td />, preventing context menus from working.
May 13 2020, 11:05 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 13 2020, 8:47 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In Firefox, multi-line selections don't generate a context menu properly.
  • Clicking the "New Inline Comment" action disables the oncopy behavior onmousedown but doesn't take the action until onclick. This creates a flash of selected content which spans both sides of the change and looks odd.
  • Context selection doesn't activate in unified mode, maybe because data-copy stuff is being used to identify content cells.
May 13 2020, 8:20 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 13 2020, 8:17 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: Unknown Object (Differential Revision).
May 13 2020, 4:31 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 13 2020, 4:31 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • When you create an inline, do nothing, then click "Cancel", inlines briefly count themselves in the paths panel.
May 13 2020, 4:30 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
May 13 2020, 4:19 PM · Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I have a patch which allows you to edit published inlines. It "works", but it causes a ton of weird side effects when you perform an edit.

May 13 2020, 4:18 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: Unknown Object (Differential Revision).
May 13 2020, 3:09 PM · Auth
epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: Unknown Object (Differential Revision).
May 13 2020, 3:05 PM · Passphrase
epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: Unknown Object (Differential Revision).
May 13 2020, 12:57 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 13 2020, 12:57 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Inline stuff:

May 13 2020, 12:43 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13229: On Third-Party Integrations.
May 13 2020, 12:01 AM · Phacility

May 12 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 12 2020, 11:00 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 12 2020, 9:09 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 12 2020, 8:33 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 12 2020, 7:19 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Probably kicking this, but:

May 12 2020, 6:31 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

See PHI1703. The document engine the original comment was made on should be persisted, so email can do something better than dumping unrelated lines of text into the body.

May 12 2020, 6:29 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13529: Phacility domain rename errata and SSH user identity.

The SSH username change wasn't sufficient because there's a hard-coded piece of logic to select the username by instance name:

May 12 2020, 6:20 PM · Phacility

May 8 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 8 2020, 11:51 PM · Inline Comments, Diffusion, Differential
epriestley edited the content of Changelog.
May 8 2020, 9:24 PM
epriestley created an object: 2020 Week 18 (Early May).
May 8 2020, 9:22 PM
epriestley added a comment to T13532: Git commit hooks may mutate commits in "arc land", discarding "Differential Revision: ...".

If pre-commit can not mutate the commit

May 8 2020, 9:02 PM · Arcanist
epriestley closed T13531: Phacility cluster account/service sync issues (account identifiers, instance refs) as Resolved.
May 8 2020, 6:49 PM · Phacility
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

The preview section underneath the comment area doesn't mark "editing" inlines in any special way.

May 8 2020, 3:56 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 8 2020, 3:09 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 8 2020, 2:51 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 8 2020, 1:39 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 8 2020, 1:26 PM · Inline Comments, Diffusion, Differential

May 7 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 8:59 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 8:31 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 8:03 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 7:54 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 7:28 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 7:09 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 6:56 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 5:56 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 7 2020, 3:50 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Not exactly related, but:

May 7 2020, 3:48 PM · Inline Comments, Diffusion, Differential

May 6 2020

epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

In D21225, I made the "attach_inlines" parameter to differential.createcomment a no-op. This originated in D7019 and was a "Facebook Feature" at the time with no use case or rationale.

May 6 2020, 6:30 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 6 2020, 6:28 PM · Inline Comments, Diffusion, Differential
epriestley triaged T13532: Git commit hooks may mutate commits in "arc land", discarding "Differential Revision: ..." as Wishlist priority.
May 6 2020, 6:00 PM · Arcanist
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 6 2020, 3:36 PM · Inline Comments, Diffusion, Differential

May 5 2020

epriestley added a comment to T13531: Phacility cluster account/service sync issues (account identifiers, instance refs).

There was a related AccountIdentifier issue with InstancesShadowUserQuery: we loaded shadow users based on accountID, but this is no longer consistently populated after T13493.

May 5 2020, 6:32 PM · Phacility
epriestley added a comment to T13531: Phacility cluster account/service sync issues (account identifiers, instance refs).

AccountIdentifiers do not sync during setup after T13493.

May 5 2020, 4:18 PM · Phacility
epriestley added a comment to T13531: Phacility cluster account/service sync issues (account identifiers, instance refs).

bin/services sync --instance X exits with no error if X does not exist.

May 5 2020, 4:15 PM · Phacility
epriestley triaged T13531: Phacility cluster account/service sync issues (account identifiers, instance refs) as Normal priority.
May 5 2020, 3:10 PM · Phacility

May 4 2020

epriestley added a revision to T13519: Support collapsing folders in the diff paths panel: Unknown Object (Differential Revision).
May 4 2020, 11:02 PM · Differential
epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: Unknown Object (Differential Revision).
May 4 2020, 10:48 PM · Differential
epriestley added a revision to T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes: Unknown Object (Differential Revision).
May 4 2020, 10:38 PM · Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 4 2020, 9:01 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: Unknown Object (Differential Revision).
May 4 2020, 8:46 PM · Inline Comments, Diffusion, Differential