I really haven't looked into the backwards compatibility issue as we're already test-driving on PHP 7.3 preview, so I can't help you out there. Your suggestion to detect the PHP version and offer this solution only for versions of PHP 7 and higher seems like the most obvious approach.

I didn't even suggest dropping support, I'm merely listing the options to allow both versions to work.
We use a manually patched version of arcanist because it suits our company's use case, but it wouldn't be suitable for a merge in Phabricator's codebase in this state.

@mydeveloperday Thanks! That'll work

@dwilches I needed the same ,just wrote up my solution here

Tough decision to make. Given the fact that most PHP projects are abandoning PHP 5 support is great, but with forcing users to upgrade is not always a good thing, as I'm not sure how this would impact the corporate/enterprise customers.

@DragonBe Backwards compatibility is broken by this fix. I'm not sure what the phabricator policy is regarding this, but I see two options:

• Creating another test engine (one for PHPUnit <= 5 and one for PHPUnit > 5)
• Parsing output differently depending on the PHPUnit version and reuse the old code where needed. This would require a little work to do things properly I guess.

In T8510#200946, @aklapper wrote:

In https://phabricator.wikimedia.org/T76732#2803813 ksmith brings up that "In the search bar in the toolbar at the top of the screen, searching for "Maps" brings up Maps as the third option. Searching for "Discovery" brings up Discovery as the second option."

Can't wait for "connect 2" to come out on playstation six.

Is there a workaround for including a newline in a table's cells? I've tried with both pipe and HTML syntax, and with %%%, triple back-tick and <br> with no success.

PHI781 asks for [ ] Show on commit message template. for "Maniphest Tasks:".

I think the label Maniphest Tasks is no longer rendered, because the tasks are being parsed from the message body ("fixes Txxx").

I'm also wondering about this. I've moved the fields around in that config setting, but I can't get Maniphest Tasks: to appear in the template when running arc diff. Is this still the place to make the change or has it moved since you comment?

In T12164#239595, @mydeveloperday wrote:

just wanted to give you some reference data (your mileage may vary), I have 2 Phabricator instances with multiple git repos

one has ~300,000 commits ( a mixture of read-only (mirrors) and hosted repos), the other ~200,000 (all hosted)

in both cases I ran rebuild-identities after doing the Week25 upgrade

time ./bin/repository rebuild-identities --all

it took

21 minutes on the one with 300,000 commits and
16 minutes on the one with 200,000

Can't help but think that this was most likely limited by the speed of the terminal output.

Hope that helps others

just wanted to give you some reference data (your mileage may vary), I have 2 Phabricator instances with multiple git repos

This sounds similar to "Customize Fields Shown In List View", except that it allows per-view customization (And a DSL for "view" instead of property on the Field, as in T418).

Also, when you global-search for an object PHID, we should maybe start taking you to the developer view instead of the main object page.

Ah, nice. Yeah, P2080 looks pretty much like the start of what I'm thinking here.

I have P2080 and P2081 for this :)

This originally came up in the context of PHI706, which asks for a "Query for all tasks mentioned in wiki page X" feature, although the actual feature request there is more involved and this would only be an approximate approach.

See also PHI689 and PHI629 for an adjacent issue with autopay.

To the issue in PHI699 in particular -- finding workboard column PHIDs -- a "Developer View" in the workboard "Manage" menu to take you to the project developer view, plus a "Workboards" section or EngineExtension would probably fit the bill.

Maybe something like this gorgeous mock which I only spilled a little water on:

T13146 is somewhat adjacent.

As a possible workaround, a trivial diff which might "fix" this problem is to change the dialog to tell users that they may get more access while they wait by logging out:

Back when this was originally reported, I'm pretty sure git lfs clone didn't exist (or at least I wasn't aware of it's existence). The appropriate fix now is probably different to the fix suggested in the original report.

We have a similar issue - however I think the "fix" is probably worse then the workaround.

Thanks for the great explanation and the pointers!

(I suppose "wontfix" is a more appropriate resolution.)

It's intentional that unapproved accounts have less access than logged-out accounts in some configurations.

@epriestley T7468: No way to disable web notifications for token awards was marked as duplicate of T10448, which in turn was resolved with a pointer to this task.

I deployed D19484 and db010, db024 and db025 finished up with no issues.

D19485 fixed one small remaining bug; I deployed that to admin.