Page MenuHomePhabricator
Feed Advanced Search

Jan 15 2021

ptarjan added a comment to T3277: `arc cleanup` to cleanup branches used by `arc patch`.

+1 for this command. We have use a web-based UI for landing so our branches stick around locally. To fix this I'm currently using:

arc branches | grep ' Closed ' | sed 's/[^ ]* //' | sed 's/ .*//' | grep -v master | grep -v '^[0-9a-f.]*$' | xargs git br -D
Jan 15 2021, 7:41 PM · Arcanist
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 15 2021, 6:45 PM · Security, Git
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 15 2021, 6:44 PM · Security, Git
epriestley removed a project from T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Security.
Jan 15 2021, 6:44 PM · Security, Git

Jan 14 2021

aleb added a comment to T12404: Implement a first-party SMTP client.

Recently smtp-relay.gmail.com stopped accepting email from our Phabricator instance because it turns out Phabricator was sending HELO localhost.localdomain instead of HELO smtp-relay.gmail.com when doing the SMTP connection.

Jan 14 2021, 6:45 PM · Infrastructure, Mail

Jan 13 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Jan 13 2021, 9:38 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Jan 13 2021, 9:01 PM · Accessibility, Differential
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Jan 13 2021, 8:39 PM · Harbormaster
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Jan 13 2021, 8:33 PM · Accessibility, Differential

Jan 12 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Unknown Object (Differential Revision).
Jan 12 2021, 8:11 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 12 2021, 8:10 PM · Security, Git
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Unknown Object (Differential Revision).
Jan 12 2021, 8:09 PM · Security, Git
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I'm not completely thrilled about maintaining PHP builtin webserver support...

Jan 12 2021, 7:11 PM · Infrastructure
epriestley triaged T13589: Git may interpret refnames as flags in some commands which accept both refs and paths as Normal priority.
Jan 12 2021, 6:26 PM · Security, Git

Jan 11 2021

epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I added M1, etc., to the ignored list in D21507.

Jan 11 2021, 8:16 PM · Infrastructure
epriestley closed T13575: PHP built-in webserver fails on POST as Resolved.

I think this is now resolved. I'm not completely thrilled about maintaining PHP builtin webserver support because I think use is very limited, but since I'm currently using it I expect to support it at least until I summon the nerve to deal with Homebrew.

Jan 11 2021, 8:14 PM · Infrastructure
epriestley added a revision to T13575: PHP built-in webserver fails on POST: Unknown Object (Differential Revision).
Jan 11 2021, 6:59 PM · Infrastructure
epriestley added a revision to T13575: PHP built-in webserver fails on POST: Unknown Object (Differential Revision).
Jan 11 2021, 6:51 PM · Infrastructure
epriestley added a revision to T13575: PHP built-in webserver fails on POST: Unknown Object (Differential Revision).
Jan 11 2021, 6:34 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

Guess I should probably add M1 to the remarkup blocklist now.

Jan 11 2021, 5:52 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I switched to an M1 Mac Mini on Big Sur, which has motivated me somewhat to try to get this working since I suspect doing another install through Homebrew on M1 silicon will be more adventure than I have stomach for.

Jan 11 2021, 5:45 PM · Infrastructure
epriestley claimed T13575: PHP built-in webserver fails on POST.
Jan 11 2021, 5:43 PM · Infrastructure
epriestley added a comment to T13588: PHP 8 Compatibility.

So I don't forget:

Jan 11 2021, 4:33 AM · Infrastructure
jrtc27 added a comment to T13588: PHP 8 Compatibility.

With the four revisions I've just added, arc lint works with PHP 8 when run inside the arcanist repo, and arc unit --everything has no regressions compared with PHP 7.4 (both do have a few failures but they're the same and relate to pyflakes/jshint/hg, and look environment-specific so nothing to do with PHP 8).

Jan 11 2021, 2:24 AM · Infrastructure
jrtc27 added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Jan 11 2021, 2:21 AM · Infrastructure
jrtc27 added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Jan 11 2021, 2:21 AM · Infrastructure
jrtc27 added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Jan 11 2021, 2:20 AM · Infrastructure
jrtc27 added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Jan 11 2021, 2:20 AM · Infrastructure

Jan 10 2021

epriestley added a comment to T13588: PHP 8 Compatibility.

In D21496, declaring a method private final (which is redundant, as a private method may never be overridden) causes an issue in PHP8.

Jan 10 2021, 10:25 PM · Infrastructure
epriestley added revisions to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision), Unknown Object (Differential Revision), Unknown Object (Differential Revision).
Jan 10 2021, 10:23 PM · Infrastructure
epriestley triaged T13588: PHP 8 Compatibility as Low priority.
Jan 10 2021, 10:23 PM · Infrastructure
epriestley added a member for Blessed Committers: jrtc27.
Jan 10 2021, 10:01 PM

Jan 8 2021

yuanchen.zhu added a comment to T11091: Make `arc patch` try the local working copy and staging areas.

Just want to add a note that with git lfs managed files, arc patch won't work unless one fetch the ref tag and then the lfs blobs from the staging server first. See https://discourse.phabricator-community.org/t/arc-patch-fails-with-git-lfs-files/2447/3

Jan 8 2021, 2:06 AM · Haskell.org, Arcanist

Dec 22 2020

flippingtables updated flippingtables.
Dec 22 2020, 1:35 PM

Dec 18 2020

epriestley added a comment to T13230: Native Applications.

As of macOS X 11 (Big Sur), php on the CLI emits:

Dec 18 2020, 12:48 AM · Phacility

Dec 3 2020

epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

That seems reasonable. I also ran into a couple of other suggestions elsewhere:

Dec 3 2020, 4:32 PM · Workboards (v3)
20after4 added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

Off the wall suggestion: how about a trigger that sets the subtype:

Dec 3 2020, 7:31 AM · Workboards (v3)

Nov 19 2020

epriestley added a revision to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes: Unknown Object (Differential Revision).
Nov 19 2020, 9:36 PM · Search
epriestley triaged T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes as Normal priority.
Nov 19 2020, 8:24 PM · Search

Nov 7 2020

epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: Unknown Object (Differential Revision).
Nov 7 2020, 12:20 AM · Herald
epriestley triaged T13586: In Herald transcripts, surface exceptions encountered while evaluating fields as Low priority.
Nov 7 2020, 12:18 AM · Herald
epriestley closed T13298: Improve Herald profiling information available in transcripts as Resolved.

The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issues.

Nov 7 2020, 12:09 AM · Herald

Nov 3 2020

epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: Unknown Object (Differential Revision).
Nov 3 2020, 8:50 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Nov 3 2020, 8:49 PM · Conduit, Harbormaster
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: Unknown Object (Differential Revision).
Nov 3 2020, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Nov 3 2020, 8:45 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Nov 3 2020, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Nov 3 2020, 8:17 PM · Conduit, Harbormaster
epriestley renamed T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values from PCRE segfaults readily with default "pcre.backtrace_limit" and "pcre.recursion_limit" values to PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.
Nov 3 2020, 7:36 PM · Phacility
epriestley closed T13584: Shallow Git clones fail under recent versions of Git as Resolved.

This appears fixed by D21484 (and @20after4 confirmed the fix on rPc0414732 -- thanks!) so I'm going to mark it as resolved.

Nov 3 2020, 7:04 PM · Diffusion
epriestley added a revision to T2312: Modifying PHP: Restricted Differential Revision.
Nov 3 2020, 6:37 PM · Infrastructure
epriestley added a comment to T2312: Modifying PHP.

See https://discourse.phabricator-community.org/t/strpos-throwing-in-phabricatorauthpasswordengine/4335, and D21477.

Nov 3 2020, 6:19 PM · Infrastructure

Oct 30 2020

jcox updated jcox.
Oct 30 2020, 5:31 PM
avivey added a revision to T5055: Distribution mechanism for arc extensions: Unknown Object (Differential Revision).
Oct 30 2020, 4:50 PM · Arcanist

Oct 26 2020

• sshannin added a comment to T4627: PhabricatorTaskmasterDaemon 100% CPU load.

I know it's an old thread, but I am encountering what is, as far as I can tell, exactly the same issue. I'm on the latest version of trunk (~Oct 26) with php 5.5.9 on Linux 3.13.0. I also observed the issue on the May 30 version.

Oct 26 2020, 11:17 PM · Daemons
altendky added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

I think I've got a small tidbit to add on a specific use-case with Jenkins. I had been using pipeline builds which are working nicely but I just tried to setup a multi-branch pipeline build and this requires the branch name in the Jenkins URL of the HTTP request triggering the build. I suspect in this case the proper thing to do would be to trigger and build twice. I guess that's more of an on-branch-change sort of situation than on-commit and using those triggers in Herald (they look to be present, I haven't used them) and having that information passed on to Harbormaster as mentioned could fill the need.

Oct 26 2020, 9:40 PM · Restricted Project, Harbormaster

Oct 24 2020

epriestley triaged T13584: Shallow Git clones fail under recent versions of Git as Low priority.
Oct 24 2020, 11:05 PM · Diffusion

Oct 19 2020

• bastiao added a comment to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.

Same issue here.

Oct 19 2020, 10:32 PM · Arcanist
epriestley edited the content of Changelog.
Oct 19 2020, 7:05 PM
epriestley created an object: 2020 Week 42.
Oct 19 2020, 7:04 PM
epriestley added a revision to T13491: Why does Arcanist require "--"?: Unknown Object (Differential Revision).
Oct 19 2020, 6:54 PM · Guides

Oct 16 2020

epriestley added a revision to T13583: Support reasonable guardrails against mismatched data retention policies in comment content: Unknown Object (Differential Revision).
Oct 16 2020, 8:29 PM · Herald
epriestley triaged T13583: Support reasonable guardrails against mismatched data retention policies in comment content as Normal priority.
Oct 16 2020, 8:27 PM · Herald
epriestley added a revision to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool: Unknown Object (Differential Revision).
Oct 16 2020, 7:31 PM · Daemons

Oct 9 2020

Netrics updated Netrics.
Oct 9 2020, 8:47 AM
Netrics updated Netrics.
Oct 9 2020, 8:45 AM
Netrics updated Netrics.
Oct 9 2020, 8:44 AM

Sep 30 2020

epriestley added a member for Community: bootstraponline.
Sep 30 2020, 3:07 PM
epriestley added a member for Blessed Committers: bootstraponline.
Sep 30 2020, 3:07 PM

Sep 28 2020

epriestley added a revision to T13564: Remarkup tables should show all content when printed to PDF: Unknown Object (Differential Revision).
Sep 28 2020, 4:22 PM · Google Chrome, Remarkup

Sep 18 2020

epriestley edited the content of Changelog.
Sep 18 2020, 7:03 PM
epriestley created an object: 2020 Week 37 (Mid September).
Sep 18 2020, 6:55 PM

Sep 17 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 17 2020, 8:52 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 17 2020, 8:38 PM · Differential
epriestley added a revision to T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring: Unknown Object (Differential Revision).
Sep 17 2020, 8:19 PM · Arcanist, Conduit
epriestley triaged T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring as Low priority.
Sep 17 2020, 8:17 PM · Arcanist, Conduit
epriestley added a comment to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool.

This synthetic script demonstrates the conceptual problem with FutureIterator:

Sep 17 2020, 7:49 PM · Daemons

Sep 16 2020

epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
Sep 16 2020, 12:44 AM · Differential
epriestley closed T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Resolved by committing Restricted Diffusion Commit.
Sep 16 2020, 12:37 AM · Daemons
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: Unknown Object (Differential Revision).
Sep 16 2020, 12:24 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: Unknown Object (Differential Revision).
Sep 16 2020, 12:20 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: Unknown Object (Differential Revision).
Sep 16 2020, 12:19 AM · Differential
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Sep 16 2020, 12:16 AM · Differential

Sep 15 2020

epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly, a subtask of T13570: Amazon is retiring SMTP V3 Signatures, as Resolved.
Sep 15 2020, 8:03 PM · Mail
epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly as Resolved by committing Restricted Diffusion Commit.
Sep 15 2020, 8:03 PM · Mail
epriestley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

I've marked D21461 as resolving this, since the new errors surface the particulars:

Sep 15 2020, 4:19 PM · Mail
epriestley added a revision to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: Restricted Differential Revision.
Sep 15 2020, 4:15 PM · Mail
epriestley added a revision to T13570: Amazon is retiring SMTP V3 Signatures: Restricted Differential Revision.
Sep 15 2020, 4:15 PM · Mail
epriestley edited the content of Dependencies.
Sep 15 2020, 4:08 PM
epriestley added a subtask for T13570: Amazon is retiring SMTP V3 Signatures: T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.
Sep 15 2020, 4:08 PM · Mail
epriestley added a parent task for T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: T13570: Amazon is retiring SMTP V3 Signatures.
Sep 15 2020, 4:08 PM · Mail

Sep 8 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 8 2020, 8:42 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 8 2020, 8:16 PM · Differential
epriestley added a revision to T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail: Unknown Object (Differential Revision).
Sep 8 2020, 8:15 PM · Daemons
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Sep 8 2020, 7:55 PM · Differential
epriestley triaged T13580: Make "fully imported" a separate commit bit or standalone flag, not a complex bitmask operation as Wishlist priority.
Sep 8 2020, 7:49 PM · Diffusion
epriestley closed T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Resolved.
  • D21457 fixes approximately 20 additional errors identified by the linter in phabricator/.
Sep 8 2020, 6:48 PM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 8 2020, 3:55 PM · Arcanist

Sep 5 2020

tiguchi added a comment to T5776: Make Slowvote choices editable by the author.

I just created a poll where I accidentally hit enter while editing options, so I was left with an incomplete poll which I wasn't allowed to complete, so I had to close it. Would you consider adding a feature that allows us to edit poll options as long as there are no votes cast yet?

Sep 5 2020, 4:46 PM · Slowvote
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.
  • D21454 fixes the specific issue in HTTPSFuture.
Sep 5 2020, 12:32 AM · Arcanist