Page MenuHomePhabricator
Feed Advanced Search

Jan 21 2017

epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Obviously, we can't just hand out estimates for free. Converting units and multiplying numbers together takes away valuable time and resources we could be using to develop Phabricator.

Jan 21 2017, 1:53 PM · Bug Report (Needs Information)
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

What'd be the fee for that 1 second command and a 5 second copy/paste?

Jan 21 2017, 8:13 AM · Bug Report (Needs Information)
chad added a project to T12098: Create Revision from FavoritesMenuItem doesn't work: Profile Menu Item.
Jan 21 2017, 3:16 AM · Dashboards, Differential
chad awarded T12139: Add a proper emoji picker to Remarkup bar a Haypence token.
Jan 21 2017, 3:14 AM · Remarkup, PHUI
chad updated the task description for T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:14 AM · Remarkup, PHUI
chad created T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:13 AM · Remarkup, PHUI
ftdysa added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

I'll make sure to update this task with full reproduction steps on Monday.

Jan 21 2017, 1:14 AM · Search, Customer Impact, Bug Report
cspeckmim added a comment to T11521: Request Review action should clear "accepted older" status.

I appreciate the details and pointers - we may look at a custom reject transaction and/or required action bucket. I just went digging here for related discussion to see if others may have run across similar scenarios.

If you miss a comment and then forget about a revision you authored for a while, it probably wasn't that critical?

I can investigate further what issues people are having with the current solutions - I'm not sure being critical is the concern but more-so there being a delay for the change to land/verify without it being clear who should be the next step (presumably from the dashboard/bucket?).

Jan 21 2017, 12:45 AM · Restricted Project, Differential, Bug Report

Jan 20 2017

epriestley added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Jan 20 2017, 11:40 PM · Remarkup, Conpherence
chad added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Jan 20 2017, 11:39 PM · Remarkup, Conpherence
epriestley created T12138: Send-on-Enter and Fullscreen Mode interact destructively.
Jan 20 2017, 11:36 PM · Remarkup, Conpherence
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to, see Consulting to move forward.

Jan 20 2017, 11:23 PM · Bug Report (Needs Information)
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

How do I reproduce unexpected results at the application level (for example, what's something I can search for that doesn't match but should match)?

Jan 20 2017, 11:18 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T11521: Request Review action should clear "accepted older" status.

Yes and no. So: maybe?

Jan 20 2017, 11:12 PM · Restricted Project, Differential, Bug Report
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

Could you at least give me the time output for the broken/test repository update on your test system, so that I have a baseline for comparison later? Thanks!

Jan 20 2017, 11:00 PM · Bug Report (Needs Information)
ftdysa created T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
Jan 20 2017, 10:56 PM · Search, Customer Impact, Bug Report
chad added a revision to T12136: What to do with "Application Counts" with MenuItem: Unknown Object (Differential Revision).
Jan 20 2017, 9:28 PM · Profile Menu Item
cspeckmim added a comment to T11521: Request Review action should clear "accepted older" status.

I want to resist adding additional actions here if they would be rarely used and reasonable workarounds already exist. After EditEngine (T11114), third-party extensions will also be able to provide supplemental actions.

Jan 20 2017, 9:24 PM · Restricted Project, Differential, Bug Report
johnny-bit added a comment to T12136: What to do with "Application Counts" with MenuItem.
In T12136#208145, @chad wrote:

I can vanish them now.

Jan 20 2017, 9:17 PM · Profile Menu Item
chad added a comment to T12136: What to do with "Application Counts" with MenuItem.

I can vanish them now.

Jan 20 2017, 9:02 PM · Profile Menu Item
chad added a comment to T11957: Add MenuEngine to Home.

Yeah I meant to clean that up too

Jan 20 2017, 7:38 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

While I've got you, how do you feel about a diff to:

Jan 20 2017, 7:34 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

(If there's pushback, maybe like a "one-time hacky copy your old global app settings into the menu script that we don't support" sort of thing? But I'd guess users won't feel like this is too painful since the new menu is a lot more flexible/powerful.)

Jan 20 2017, 7:31 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

I think it would potentially be reasonable to not migrate, especially if you do another blog post like the Favorites one to ease migration pain. Global stuff is relatively recent and pretty easy to put back in place, and I think a gentle nudge to configure the menu to work well for your install isn't a bad thing.

Jan 20 2017, 7:29 PM · Profile Menu Item, Dashboards
epriestley added a comment to T12136: What to do with "Application Counts" with MenuItem.

Maybe less complainey now that Audit and Differential have fairly sane default "stuff you should do" bucketed queries which can go on a dashboard? But who knows. I tend to think we should make an effort to toss these and see how much pushback we get. In particular, they're very expensive to build relative to their utility (and no one has complained yet that I nuked the Audit count, although it has only been gone for a little while).

Jan 20 2017, 7:24 PM · Profile Menu Item
chad added a comment to T11957: Add MenuEngine to Home.

@epriestley my assumption here is:

Jan 20 2017, 7:23 PM · Profile Menu Item, Dashboards
chad created T12136: What to do with "Application Counts" with MenuItem.
Jan 20 2017, 7:22 PM · Profile Menu Item
epriestley added a revision to T12128: Favorites Menu Errata : Unknown Object (Differential Revision).
Jan 20 2017, 7:16 PM · Profile Menu Item
epriestley closed T12129: Mercurial repository updates cause high CPU usage as Invalid.

Sounds good. I'm going to close this since it doesn't seem to be moving toward becoming a bug report which we can accept upstream.

Jan 20 2017, 6:24 PM · Bug Report (Needs Information)
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

We are certainly not going to engage into paid consulting without knowing how long it might take to solve the problem, given your hourly rate :)
I would have appreciated at least a tiny hint on how to solve this ourselves instead, so I guess I'm going to dive into the code and implement a workaround somewhere. For example, tinkering with the $smart_wait calculation might be a start.

Jan 20 2017, 6:22 PM · Bug Report (Needs Information)
epriestley renamed T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username from when editing bot account settings, the default values suggest I'm editing my own settings to When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.
Jan 20 2017, 6:20 PM · User Preferences, Bug Report
epriestley triaged T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username as Wishlist priority.

There's a TODO about this in the code:

Jan 20 2017, 6:19 PM · User Preferences, Bug Report
allixsenos created T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.
Jan 20 2017, 6:15 PM · User Preferences, Bug Report
cspeckmim awarded T12134: Develop a Nuance-based Phabricator reporting/support flow a Party Time token.
Jan 20 2017, 6:00 PM · Abuse
epriestley merged task T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 6:00 PM · Public & Media Relations, Support
epriestley merged T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 6:00 PM · Abuse
epriestley added a comment to T9212: Community Feedback: How should we handle free support?.

I'm going to merge this into T12134, which begins defining a more concrete plan roughly following some of the outline above. The major change from an upstream perspective since this task was filed is that we have a more specific set of harder technical requirements around support for Phacility SAAS instances (particularly after the launch of free instances), so it makes more sense to let those requirements drive product design and then accommodate general free support under that umbrella. Broadly, I expect to move support (bug reports, feature requests) into Nuance and continue reducing user access to the upstream.

Jan 20 2017, 6:00 PM · Public & Media Relations, Support
epriestley created T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 5:32 PM · Abuse
chad added a comment to T12133: Manually Closing Revisions not possible in Audit.

@Ondrej I was mostly trying to understand if you were seeing a regression, a mis-understanding of how Audit currently works, or missing some setting we should be trying against a default install. There were a number of variables still open based on your explanation to me at least, sounds like @epriestley has plans forward here though already.

Jan 20 2017, 5:06 PM · Bug Report
chad closed T12131: Edit History inserts itself wherever it feels like as Resolved by committing Restricted Diffusion Commit.
Jan 20 2017, 4:56 PM · Bug Report
• Ondrej added a comment to T12133: Manually Closing Revisions not possible in Audit.
  • Chad, lets say I would rise a concern on your commit and I would never come back to Phabricator's website. You cannot mark your revision as closed. You need to remove me as an auditor and accept your commit (what is little bit complicated). What's more, there's no functionality to help me to follow this concern. When you commit a fix, how can you let me know about this fix?
  • Epriestley, T2393 would fix the second issue, that would be great to have it today:-)!
Jan 20 2017, 3:44 PM · Bug Report
epriestley added a revision to T12131: Edit History inserts itself wherever it feels like: Unknown Object (Differential Revision).
Jan 20 2017, 3:40 PM · Bug Report
• Ondrej awarded T2393: Adds a "Needs Verification" state to Audits a Like token.
Jan 20 2017, 3:38 PM · Restricted Project, Audit
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

(This change was half-accidental, and then I just figured I'd roll it into T2393 when I realized I'd made it.)

Jan 20 2017, 3:30 PM · Bug Report
epriestley merged T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Jan 20 2017, 3:30 PM · Restricted Project, Audit
epriestley merged task T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Jan 20 2017, 3:29 PM · Bug Report
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

This did actually change in connection with T10978, but only if audit.can-author-close-audit is configured. I plan to resolve T2393 (maybe today?) and hopefully get rid of "Close" and this option entirely. I'm just going to merge this there.

Jan 20 2017, 3:29 PM · Bug Report
bilalbaqar added a watcher for Phrequent: bilalbaqar.
Jan 20 2017, 3:13 PM
chad added a comment to T12133: Manually Closing Revisions not possible in Audit.

if a concern is raised; no one except this auditor can close the audit.

Jan 20 2017, 3:01 PM · Bug Report
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to work with you one-on-one to help troubleshoot issues in your environment, but we can't offer that kind of support for free. This process almost always takes up a large amount of our time and very rarely uncovers any real bugs in Phabricator or helps anyone except the single user experiencing a configuration problem. See Support Resources for more discussion of the kinds of free and paid support we offer. If you'd like to move forward with one-on-one configuration and environment support, see Consulting.

Jan 20 2017, 12:51 PM · Bug Report (Needs Information)
• Ondrej created T12133: Manually Closing Revisions not possible in Audit.
Jan 20 2017, 9:52 AM · Bug Report
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

I was afraid this would happen. However, short of giving you access to our server, there is no way I can exactly describe our setup: there are fare too many variables. Perhaps we could narrow it down a bit? What could be a factor here? The obvious non-standard features of our setup are :

  • linux-vserver
  • 32bit userland
  • LVM on soft raid
  • daemon user = web user

That said, I can't understand why the same user can run hg log with negligible CPU impact, and run the same hg log through phabricator with significant performance impact. Clearly phabricator does something in addition to calling mercurial that is causing the problem, and I don't know what it could be. That's where your input would help :-)

Jan 20 2017, 9:04 AM · Bug Report (Needs Information)
chad triaged T12132: Subscribing to blogs should be easier as Low priority.
Jan 20 2017, 5:19 AM · Phame
chad closed T12107: Pick new icon for Phame, a subtask of T5867: Move Quick Create to MenuItemEngine, as Resolved.
Jan 20 2017, 4:31 AM · Design
chad closed T12107: Pick new icon for Phame as Resolved.
Jan 20 2017, 4:31 AM · Phame, Design
chad added a comment to T12107: Pick new icon for Phame.

I did for now, will see what FontAwesome 5 brings, but the was never something I really liked for Phame anyways.

Jan 20 2017, 4:30 AM · Phame, Design
chad removed projects from T12107: Pick new icon for Phame: Almanac, Accessibility, Android.
Jan 20 2017, 4:30 AM · Phame, Design
chad created T12132: Subscribing to blogs should be easier.
Jan 20 2017, 4:28 AM · Phame
chad added a comment to T12130: DateTime parsing error in phd log.

Beyond that I don't know how you're using Calendar or what types of events you have.

Jan 20 2017, 3:01 AM · Calendar, Bug Report (Needs Information)
chad added a comment to T12130: DateTime parsing error in phd log.

I'd update Phabricator first, then see if it clears.

Jan 20 2017, 3:00 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

Actually this error started quite long ago. In my memory it started after some big changes on Calendar app. I have updated several versions before I fired this bug report. I will try to update to the latest version later. Regarding the reproduction steps, this is a background daemon log, not triggered by direct human action. I have no idea how to provide the reproduction steps. Any hint?

Jan 20 2017, 2:47 AM · Calendar, Bug Report (Needs Information)
chad edited projects for T12130: DateTime parsing error in phd log, added: Bug Report (Needs Information); removed Bug Report.
Jan 20 2017, 2:40 AM · Calendar, Bug Report (Needs Information)
chad added a comment to T12130: DateTime parsing error in phd log.

We will also need reproduction steps to accept this as a valid bug report. See Contributing Bug Reports.

Jan 20 2017, 2:39 AM · Calendar, Bug Report (Needs Information)
chad created T12131: Edit History inserts itself wherever it feels like.
Jan 20 2017, 2:36 AM · Bug Report
chad added a comment to T12130: DateTime parsing error in phd log.

You're at least 6 weeks out of date. Can you update Phabricator and verify the bug at HEAD before filing, please?

Jan 20 2017, 2:34 AM · Calendar, Bug Report (Needs Information)
RuralHunter created T12130: DateTime parsing error in phd log.
Jan 20 2017, 2:31 AM · Calendar, Bug Report (Needs Information)
aurelijus removed a watcher for Community: aurelijus.
Jan 20 2017, 12:22 AM
aurelijus added a watcher for Community: aurelijus.
Jan 20 2017, 12:21 AM

Jan 19 2017

epriestley edited projects for T12129: Mercurial repository updates cause high CPU usage, added: Bug Report (Needs Information); removed Bug Report.
Jan 19 2017, 11:58 PM · Bug Report (Needs Information)
epriestley awarded Image Macro "tarnation" a Pterodactyl token.
Jan 19 2017, 11:57 PM
chad awarded Image Macro "tarnation" a Mountain of Wealth token.
Jan 19 2017, 11:57 PM
chad changed the image for Image Macro "tarnation".
Jan 19 2017, 11:56 PM
chad closed T12126: Probably remove cat facts as Resolved.
Jan 19 2017, 10:59 PM · Profile Menu Item
chad added a revision to T12126: Probably remove cat facts: Unknown Object (Differential Revision).
Jan 19 2017, 10:47 PM · Profile Menu Item
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I am unable to reproduce the issue you described by following the steps provided. To move forward:

Jan 19 2017, 10:06 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Here's what I did to try to reproduce this:

Jan 19 2017, 10:04 PM · Bug Report (Needs Information)
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

The repository at https://bitbucket.org/LeCoyote/brokentest is enough to see unusual CPU usage. Of course, it is nowhere near as bad as the other one, but the CPU is still coasting a noticeable 2 or 3% above average, which seems disproportionate for such a small repo. Also, when calling the update manually:

$ time ./bin/repository update 3
Updated repository "cieltest".
Jan 19 2017, 9:37 PM · Bug Report (Needs Information)
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

Noted. I'll try and reproduce the problem with a different repository.

Jan 19 2017, 9:04 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

(A synthetic repository which you create by running hg commit in a loop, or instructions which allow us to build such a synthetic repository, are also fine.)

Jan 19 2017, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

An existing, open source project is perfectly fine, provided you first verify that it reproduces the problem.

Jan 19 2017, 8:57 PM · Bug Report (Needs Information)
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

Unless you can make this task private to a group of people who would be prepared to sign a NDA in French, that's not going to happen.

Jan 19 2017, 8:55 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

We need specific reproduction steps to move forward, and "a repository with about 2800 commits" isn't sufficiently specific.

Jan 19 2017, 8:35 PM · Bug Report (Needs Information)
LeCoyote created T12129: Mercurial repository updates cause high CPU usage.
Jan 19 2017, 8:31 PM · Bug Report (Needs Information)
aik099 added a comment to T6507: Audit inline comments doesn't account for synthetic authors.

In https://github.com/aik099/phabricator/commits/jenkins-integration branch I've:

Jan 19 2017, 8:29 PM · Audit
epriestley closed T6024: Display (post-push) audit-state in Diffusion commit-list as Resolved by committing Restricted Diffusion Commit.
Jan 19 2017, 7:43 PM · Restricted Project, Audit, Diffusion
chad added a project to T12128: Favorites Menu Errata : Profile Menu Item.
Jan 19 2017, 7:37 PM · Profile Menu Item
chad added a comment to T12127: Allow EditEngine forms to have custom icons.

(I've grown to like the icon-less menus though)

Jan 19 2017, 7:35 PM · Dashboards, EditEngine
chad added a comment to T12127: Allow EditEngine forms to have custom icons.

We'd probably be fine picking 16 per form... Not sure people customize forms outside of Maniphest though.

Jan 19 2017, 7:34 PM · Dashboards, EditEngine
chad created T12128: Favorites Menu Errata .
Jan 19 2017, 7:33 PM · Profile Menu Item
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Inlines to Future on the Audit board.
Jan 19 2017, 7:32 PM · Audit
epriestley added a comment to T12127: Allow EditEngine forms to have custom icons.

This is easy but I think you want to get rid of all the IconSet stuff and just let everything have any icon?

Jan 19 2017, 7:32 PM · Dashboards, EditEngine
chad created T12127: Allow EditEngine forms to have custom icons.
Jan 19 2017, 7:31 PM · Dashboards, EditEngine
epriestley added a comment to T6507: Audit inline comments doesn't account for synthetic authors.

This report is probably correct and the remedy is likely also correct, but getting lint into Diffusion is completely in shambles so I'm actually not immediately sure how to reproduce it, at least in a reasonable / moderately-convenient way.

Jan 19 2017, 7:31 PM · Audit
epriestley added a revision to T11096: Redesign main header / quick create / search: Unknown Object (Differential Revision).
Jan 19 2017, 7:11 PM · Design
chad edited projects for T12126: Probably remove cat facts, added: Profile Menu Item; removed PHUI.
Jan 19 2017, 7:10 PM · Profile Menu Item
chad created T12126: Probably remove cat facts.
Jan 19 2017, 7:04 PM · Profile Menu Item
chad added a comment to T11096: Redesign main header / quick create / search.

And before you file it, no, cat facts are not supported.

Jan 19 2017, 7:03 PM · Design
chad edited this Badge.
Jan 19 2017, 7:01 PM
chad added a comment to T11096: Redesign main header / quick create / search.

C2a4am-UkAAlG7X.jpg (750×750 px, 55 KB)

Jan 19 2017, 7:01 PM · Design
epriestley added a comment to T11096: Redesign main header / quick create / search.

Not intentional -- @chad, I can figure out what's going on there since it might reasonably be me and I have a local repro.

Jan 19 2017, 7:00 PM · Design